Skip to contentSkip to conversation

qapi/qom: Document feature unstable of @x-vfio-user-server

PATCH In review Markus Armbruster 2 participants 3 messages Jul 3, 2024 – Jul 17, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qapi/qom: Document feature unstable of @x-vfio-user-server

Commit 8f9a9259d32c added ObjectType member @x-vfio-user-server with feature unstable, but neglected to explain why it is unstable. Do that now.

Fixes 8f9a9259d32c (vfio-user: define vfio-user-server object)
Cc Elena Ufimtseva <[email protected]>
Cc John G Johnson <[email protected]>
Cc Jagannathan Raman <[email protected]>
---
 qapi/qom.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
qapi/qom.json +2 -1
index 8bd299265e..3c0f8c633d 100644
@@ -1012,7 +1012,8 @@
 #
 # Features:
 #
-# @unstable: Member @x-remote-object is experimental.
+# @unstable: Members @x-remote-object and @x-vfio-user-server are
+# experimental.
 #
 # Since: 6.0
 ##
Signature · 1 line
2.45.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Markus Armbruster

Commit 8f9a9259d32c added ObjectType member @x-vfio-user-server with feature unstable, but neglected to explain why it is unstable. Do that now.

Fixes 8f9a9259d32c (vfio-user: define vfio-user-server object)
Cc Elena Ufimtseva <[email protected]>
Cc John G Johnson <[email protected]>
Cc Jagannathan Raman <[email protected]>

(... This is a joke, to be extremely clear)

Quoted 3 lines
Quoted 22 lines
---
 qapi/qom.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
qapi/qom.json +2 -2
index 8bd299265e..3c0f8c633d 100644
@@ -1012,7 +1012,8 @@
 #
 # Features:
 #
-# @unstable: Member @x-remote-object is experimental.
+# @unstable: Members @x-remote-object and @x-vfio-user-server are
+# experimental.
 #
 # Since: 6.0
 ##
--

2.45.0

#2 lore raw
In reply to Markus Armbruster
Quoted 19 lines · Markus Armbruster

Commit 8f9a9259d32c added ObjectType member @x-vfio-user-server with feature unstable, but neglected to explain why it is unstable. Do that now.

Fixes 8f9a9259d32c (vfio-user: define vfio-user-server object)
Cc Elena Ufimtseva <[email protected]>
Cc John G Johnson <[email protected]>
Cc Jagannathan Raman <[email protected]>
---
 qapi/qom.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
qapi/qom.json +0 -0
index 8bd299265e..3c0f8c633d 100644

qapi/qom.json line 1016

Quoted 6 lines
qapi/qom.json +2 -1
@@ -1012,7 +1012,8 @@
 #
 # Features:
 #
-# @unstable: Member @x-remote-object is experimental.
+# @unstable: Members @x-remote-object and @x-vfio-user-server are
+# experimental.

Second line needs to be indented. Fixed in my tree.

qapi/qom.json line 1019

Quoted 3 lines
qapi/qom.json +0 -0
 #
 # Since: 6.0
 ##

Queued.