Documentation: siphash: Fix typo in the name of offsetofend macro
PATCH 1/1 Documentation: siphash: Fix typo in the name of offsetofend macro
The siphash documentation misspelled "offsetendof" instead of "offsetofend".
--- Documentation/security/siphash.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/security/siphash.rst +1 -1
@@ -85,7 +85,7 @@ Often times the XuY functions will not be large enough, and instead you'll want to pass a pre-filled struct to siphash. When doing this, it's important to always ensure the struct has no padding holes. The easiest way to do this is to simply arrange the members of the struct in descending order of size, -and to use offsetendof() instead of sizeof() for getting the size. For +and to use offsetofend() instead of sizeof() for getting the size. For performance reasons, if possible, it's probably a good thing to align the struct to the right boundary. Here's an example::
Signature · 1 line
2.25.1
Jonathan Corbet
maintainerQuoted 4 lines · Dov Murik
The siphash documentation misspelled "offsetendof" instead of "offsetofend".
Fixes 2c956a60778cbb ("siphash: add cryptographically secure PRF")
When you send a patch with a Fixes tag it's always a good idea to CC the author of the patch being fixed. Adding Jason...let me know if you'd like me to grab this.
Quoted 20 lines
Signed-off-by Dov Murik <[email protected]>--- Documentation/security/siphash.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/security/siphash.rst +1
-1@@ -85,7 +85,7 @@ Often times the XuY functions will not be large enough, and instead you'll want to pass a pre-filled struct to siphash. When doing this, it's important to always ensure the struct has no padding holes. The easiest way to do this is to simply arrange the members of the struct in descending order of size, -and to use offsetendof() instead of sizeof() for getting the size. For +and to use offsetofend() instead of sizeof() for getting the size. For performance reasons, if possible, it's probably a good thing to align the struct to the right boundary. Here's an example::Signature · 1 line
2.25.1
Thanks,
jon
Jason A. Donenfeld
Acked-byHi Jon,
Quoted 10 lines · Jonathan Corbet
Quoted 4 lines · Dov Murik
The siphash documentation misspelled "offsetendof" instead of "offsetofend".
Fixes 2c956a60778cbb ("siphash: add cryptographically secure PRF")When you send a patch with a Fixes tag it's always a good idea to CC the author of the patch being fixed. Adding Jason...let me know if you'd like me to grab this.
Thanks for CC'ing me. Sure, feel free to take this:
Jason
Quoted 10 lines · Jason A. Donenfeld
Hi Jon,
Quoted 7 lines · Jonathan Corbet
Quoted 4 lines · Dov Murik
The siphash documentation misspelled "offsetendof" instead of "offsetofend".
Fixes 2c956a60778cbb ("siphash: add cryptographically secure PRF")
Quoted 7 lines
Quoted 3 lines
When you send a patch with a Fixes tag it's always a good idea to CC the author of the patch being fixed. Adding Jason...let me know if you'd like me to grab this.
Thanks for CC'ing me. Sure, feel free to take this:
Applied, thanks.
jon
Quoted 16 lines · Jonathan Corbet
Quoted 14 lines · Jason A. Donenfeld
Hi Jon,
Quoted 10 lines · Jonathan Corbet
Quoted 4 lines · Dov Murik
The siphash documentation misspelled "offsetendof" instead of "offsetofend".
Fixes 2c956a60778cbb ("siphash: add cryptographically secure PRF")When you send a patch with a Fixes tag it's always a good idea to CC the author of the patch being fixed. Adding Jason...let me know if you'd like me to grab this.
Quoted 5 lines
Quoted 3 lines
Thanks for CC'ing me. Sure, feel free to take this:
Applied, thanks.
Thank you Jon.
I'll try to remember your tip about CC the author of the Fixes tag.
-Dov
Quoted 2 lines
jon