Skip to contentSkip to conversation

dt-bindings: usb: add rk3328 dwc3 docs

PATCH In review [email protected] 4 participants 9 messages Sep 2, 2020 – Jan 21, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/4 dt-bindings: usb: add rk3328 dwc3 docs

From: Cameron Nemo <[email protected]>

Document compatible for dwc3 on the Rockchip rk3328 platform.

---
 Documentation/devicetree/bindings/usb/dwc3.txt          | 1 +
 Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/usb/dwc3.txt +1 -0
index d03edf9d3935..d625cd5966e9 100644
@@ -25,6 +25,7 @@ Exception for clocks:
     "ti,am437x-dwc3"
     "ti,dwc3"
     "ti,keystone-dwc3"
+    "rockchip,rk3328-dwc3"
     "rockchip,rk3399-dwc3"
     "xlnx,zynqmp-dwc3"
 
Documentation/devicetree/bindings/usb/rockchip,dwc3.txt +2 -1
index 94520493233b..b41f30a61be6 100644
@@ -1,7 +1,8 @@
 Rockchip SuperSpeed DWC3 USB SoC controller
 
 Required properties:
-- compatible:	should contain "rockchip,rk3399-dwc3" for rk3399 SoC
+- compatible:	should contain "rockchip,rk3328-dwc3" for rk3328 SoC
+		or "rockchip,rk3399-dwc3" for rk3399 SoC
 - clocks:	A list of phandle + clock-specifier pairs for the
 		clocks listed in clock-names
 - clock-names:	Should contain the following:
Signature · 1 line
2.28.0
#1 lore raw

PATCH v4 2/4 usb: dwc3: of-simple: Add compatible for rk3328

From: Cameron Nemo <[email protected]>

Add a compatible to be hooked into by the Rockchip rk3328 device tree.

The rk3399 compatible cannot be reused because the rk3328 SoCs may require a specialized driver in the future, and old device trees must remain compatible with newer kernels.

---
 drivers/usb/dwc3/dwc3-of-simple.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/dwc3/dwc3-of-simple.c +1 -0
index 7df115012935..0727bf2304b1 100644
@@ -171,6 +171,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
 };
 
 static const struct of_device_id of_dwc3_simple_match[] = {
+	{ .compatible = "rockchip,rk3328-dwc3" },
 	{ .compatible = "rockchip,rk3399-dwc3" },
 	{ .compatible = "xlnx,zynqmp-dwc3" },
 	{ .compatible = "cavium,octeon-7130-usb-uctl" },
Signature · 1 line
2.28.0
#2 lore raw

PATCH v4 3/4 arm64: dts: rockchip: rk3328 usb3 controller node

In reply to [email protected]

From: Cameron Nemo <[email protected]>

RK3328 SoCs have one USB 3.0 OTG controller which uses DWC_USB3 core's general architecture. It can act as static xHCI host controller, static device controller, USB 3.0/2.0 OTG basing on ID of USB3.0 PHY.

---
 arch/arm64/boot/dts/rockchip/rk3328.dtsi | 27 ++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
arch/arm64/boot/dts/rockchip/rk3328.dtsi +27 -0
index bbdb19a3e85d..27e86bf06d3e 100644
@@ -983,6 +983,33 @@ usb_host0_ohci: usb@ff5d0000 {
 		status = "disabled";
 	};
 
+	usbdrd3: usb@ff600000 {
+		compatible = "rockchip,rk3328-dwc3";
+		clocks = <&cru SCLK_USB3OTG_REF>, <&cru SCLK_USB3OTG_SUSPEND>,
+			 <&cru ACLK_USB3OTG>;
+		clock-names = "ref_clk", "suspend_clk",
+			      "bus_clk";
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+		status = "disabled";
+
+		usbdrd_dwc3: dwc3@ff600000 {
+			compatible = "snps,dwc3";
+			reg = <0x0 0xff600000 0x0 0x100000>;
+			interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
+			dr_mode = "otg";
+			phy_type = "utmi_wide";
+			snps,dis_enblslpm_quirk;
+			snps,dis-u2-freeclk-exists-quirk;
+			snps,dis_u2_susphy_quirk;
+			snps,dis_u3_susphy_quirk;
+			snps,dis-del-phy-power-chg-quirk;
+			snps,dis-tx-ipgap-linecheck-quirk;
+			status = "disabled";
+		};
+	};
+
 	gic: interrupt-controller@ff811000 {
 		compatible = "arm,gic-400";
 		#interrupt-cells = <3>;
Signature · 7 lines
2.28.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#3 lore raw

PATCH v4 4/4 arm64: dts: rockchip: enable rk3328-rock64 usb3 nodes

In reply to [email protected]

From: Cameron Nemo <[email protected]>

Enable USB3 nodes for the rk3328-based PINE Rock64 board.

---
 arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/rockchip/rk3328-rock64.dts +9 -0
index 86cfb5c50a94..0cbf59efcef0 100644
@@ -384,6 +384,15 @@ &usb20_otg {
 	status = "okay";
 };
 
+&usbdrd3 {
+	status = "okay";
+};
+
+&usbdrd_dwc3 {
+	dr_mode = "host";
+	status = "okay";
+};
+
 &usb_host0_ehci {
 	status = "okay";
 };
Signature · 1 line
2.28.0
maintainer Acked-by on v4 1/4
#4 lore raw
In reply to [email protected]
Quoted 10 lines · On Wed, 02 Sep 2020 11:12:31 -0700, [email protected] wrote:

From: Cameron Nemo <[email protected]>

Document compatible for dwc3 on the Rockchip rk3328 platform.

---
 Documentation/devicetree/bindings/usb/dwc3.txt          | 1 +
 Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#5 lore raw
In reply to [email protected]
Quoted 4 lines · On Wed, Sep 2, 2020 at 11:12 AM <[email protected]> wrote:

From: Cameron Nemo <[email protected]>

Document compatible for dwc3 on the Rockchip rk3328 platform.

Hi all,

Wanted to give this patch submission a gentle ping.

Rob Herring acked the documentation changes, but I have not heard anything
from the USB or Rockchip maintainers. This patchset would facilitate USB3 support for Rockchip rk3328 devices like the Pine Rock64.

If there is anything I can do to help move this along, please let me know.

Thank you,
Cameron

Quoted 36 lines
---
 Documentation/devicetree/bindings/usb/dwc3.txt          | 1 +
 Documentation/devicetree/bindings/usb/rockchip,dwc3.txt | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/usb/dwc3.txt +1 -0
index d03edf9d3935..d625cd5966e9 100644
@@ -25,6 +25,7 @@ Exception for clocks:
     "ti,am437x-dwc3"
     "ti,dwc3"
     "ti,keystone-dwc3"
+    "rockchip,rk3328-dwc3"
     "rockchip,rk3399-dwc3"
     "xlnx,zynqmp-dwc3"
 
Documentation/devicetree/bindings/usb/rockchip,dwc3.txt +2 -2
index 94520493233b..b41f30a61be6 100644
@@ -1,7 +1,8 @@
 Rockchip SuperSpeed DWC3 USB SoC controller
 
 Required properties:
-- compatible:  should contain "rockchip,rk3399-dwc3" for rk3399 SoC
+- compatible:  should contain "rockchip,rk3328-dwc3" for rk3328 SoC
+               or "rockchip,rk3399-dwc3" for rk3399 SoC
 - clocks:      A list of phandle + clock-specifier pairs for the
                clocks listed in clock-names
 - clock-names: Should contain the following:
--

2.28.0

#6 lore raw

Hi,

Quoted 8 lines · Lindsey Stanpoor
Quoted 4 lines · On Wed, Sep 2, 2020 at 11:12 AM <[email protected]> wrote:

From: Cameron Nemo <[email protected]>

Document compatible for dwc3 on the Rockchip rk3328 platform.

Hi all,

Quoted 8 lines

Wanted to give this patch submission a gentle ping.

Rob Herring acked the documentation changes, but I have not heard anything
from the USB or Rockchip maintainers. This patchset would facilitate USB3 support for Rockchip rk3328 devices like the Pine Rock64.

If there is anything I can do to help move this along, please let me know.

Sorry, it had fallen through the cracks. It's now in my testing/next.

Signature · 1 line
balbi
#7 lore raw
Quoted 15 lines · Felipe Balbi

Hi,

Quoted 10 lines · Lindsey Stanpoor
Quoted 4 lines · On Wed, Sep 2, 2020 at 11:12 AM <[email protected]> wrote:

From: Cameron Nemo <[email protected]>

Document compatible for dwc3 on the Rockchip rk3328 platform.

Hi all,

Wanted to give this patch submission a gentle ping.

Quoted 8 lines
Quoted 6 lines

Rob Herring acked the documentation changes, but I have not heard anything
from the USB or Rockchip maintainers. This patchset would facilitate USB3 support for Rockchip rk3328 devices like the Pine Rock64.

If there is anything I can do to help move this along, please let me know.

Sorry, it had fallen through the cracks. It's now in my testing/next.

Following up on this. Will this move out of your testing/next? --
Cameron

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

#8 lore raw
Quoted 22 lines · Lindsey Stanpoor
Quoted 20 lines · Felipe Balbi

Hi,

Quoted 15 lines · Lindsey Stanpoor
Quoted 4 lines · On Wed, Sep 2, 2020 at 11:12 AM <[email protected]> wrote:

From: Cameron Nemo <[email protected]>

Document compatible for dwc3 on the Rockchip rk3328 platform.

Hi all,

Wanted to give this patch submission a gentle ping.

Rob Herring acked the documentation changes, but I have not heard anything
from the USB or Rockchip maintainers. This patchset would facilitate USB3 support for Rockchip rk3328 devices like the Pine Rock64.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

If there is anything I can do to help move this along, please let me know.

Sorry, it had fallen through the cracks. It's now in my testing/next.

Following up on this. Will this move out of your testing/next?

The binding changes are likely stale now that the dwc3 binding has been converted to YAML. See Greg's USB tree.

Also the DT changes should go through the arm-soc tree separately, so we can stack on additional changes enabling USB3 on other boards.

ChenYu

Quoted 7 lines

--
Cameron

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip