Skip to contentSkip to conversation

libcamera: Fix and update libcamera package

PATCH New Kieran Bingham 6 participants 16 messages Sep 4, 2020 – Nov 17, 2020

lore
Share & tools
lore
#0 lore raw

cover libcamera: Fix and update libcamera package

Prevent compilation of libcamera on m68k architectures as we experience build failures there, and do not currently support that target with libcamera.

Then, update the build to require C++17, in anticipation of bumping the version to the latest upstream.

Kieran Bingham (3):
package/libcamera: Prevent builds on m68k package/libcamera: Update requirements for C++17 package/libcamera: bump version to e59713c6

 package/libcamera/Config.in      | 8 +++++---
 package/libcamera/libcamera.hash | 2 +-
 package/libcamera/libcamera.mk   | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/3 package/libcamera: Prevent builds on m68k

The ControlValue structure is currently defined with a 16-bit hole (causing unaligned access to the numElements_ field, though that's a separate topic).

This structure has a static assertion to ensure that its size does not change without due care, as it forms part of our ABI and is used in Serialisation between the pipeline handlers and IPA componenents.

The m68k architecture is the only target which fails this assertion, which is likely because it can pack the structure more efficiently, producing a different binary size.

This is likely an area we will tackle before stabilising our ABI, but until then, disable m68k builds as libcamera is not expected to be supported on this target.

---
 package/libcamera/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/libcamera/Config.in +2 -0
index 960d78b82e95..1ea747d1c57e 100644
@@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14
 	depends on !BR2_STATIC_LIBS # gnutls
 	depends on BR2_USE_WCHAR # gnutls
+	# Invalid packing size of ControlValue struct on m68k
+	depends on !BR2_m68k
 	select BR2_PACKAGE_GNUTLS
 	select BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
 	help
Signature · 1 line
2.25.1
#2 lore raw

PATCH 1/3 package/libcamera: Prevent builds on m68k

Quoted 12 lines · On Fri, 4 Sep 2020 10:51:45 +0100 Kieran Bingham…

The ControlValue structure is currently defined with a 16-bit hole (causing unaligned access to the numElements_ field, though that's a separate topic).

This structure has a static assertion to ensure that its size does not change without due care, as it forms part of our ABI and is used in Serialisation between the pipeline handlers and IPA componenents.

The m68k architecture is the only target which fails this assertion, which is likely because it can pack the structure more efficiently, producing a different binary size.

Quoted 5 lines

This is likely an area we will tackle before stabilising our ABI, but until then, disable m68k builds as libcamera is not expected to be supported on this target.

We normally ask to have an autobuilder failure reference here. No need to resend just for that, we can add it when applying.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/3 package/libcamera: Prevent builds on m68k

Hi Thomas,

Quoted 15 lines · Thomas Petazzoni
Quoted 12 lines · On Fri, 4 Sep 2020 10:51:45 +0100 Kieran Bingham…

The ControlValue structure is currently defined with a 16-bit hole (causing unaligned access to the numElements_ field, though that's a separate topic).

This structure has a static assertion to ensure that its size does not change without due care, as it forms part of our ABI and is used in Serialisation between the pipeline handlers and IPA componenents.

The m68k architecture is the only target which fails this assertion, which is likely because it can pack the structure more efficiently, producing a different binary size.

Quoted 8 lines
Quoted 5 lines

This is likely an area we will tackle before stabilising our ABI, but until then, disable m68k builds as libcamera is not expected to be supported on this target.

We normally ask to have an autobuilder failure reference here. No need to resend just for that, we can add it when applying.

Sorry, I didn't realise. But don't worry -there are plenty ;-)

Here's the latest:

Quoted 8 lines

Results for the '2020.08.x' branch
----------------------------------

Build failures related to your packages:

arch | reason | url
-------------+--------------------------------+---------------------------------------------------------------------------------

    m68k     | libcamera-96fab38e02792a109... | http://autobuild.buildroot.net/results/9dce26e94299a2c61bba60cbc7803926e2f85e29
Signature · 3 lines
Regards
--
Kieran
#4 lore raw

PATCH 1/3 package/libcamera: Prevent builds on m68k

In reply to Kieran Bingham

package/libcamera/Config.in menuconfig BR2_PACKAGE_LIBCAMERA · line 9

Quoted 10 lines · On Fri, 4 Sep 2020 10:51:45 +0100 Kieran Bingham…
package/libcamera/Config.in +2 -0
index 960d78b82e95..1ea747d1c57e 100644
@@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14
 	depends on !BR2_STATIC_LIBS # gnutls
 	depends on BR2_USE_WCHAR # gnutls
+	# Invalid packing size of ControlValue struct on m68k
+	depends on !BR2_m68k

Another comment: this dependency should be replicated in the Config.in comment for libcamera, so that the comment that says "libcamera needs a toolchain w/ ..." doesn't appear on m68k... which would be meaningless as libcamera is not available at all for this architecture.

In general, we like to have:

config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
config
default y
depends on !BR2_m68k

and then use that in BR2_PACKAGE_LIBCAMERA and the Config.in comment. This way, if other packages select libcamera, they can also re-use this "depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS".

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/3 package/libcamera: Prevent builds on m68k

In reply to Kieran Bingham

Kieran, All,

On 2020-09-04 10:51 +0100, Kieran Bingham spake thusly:

Quoted 12 lines

The ControlValue structure is currently defined with a 16-bit hole (causing unaligned access to the numElements_ field, though that's a separate topic).

This structure has a static assertion to ensure that its size does not change without due care, as it forms part of our ABI and is used in Serialisation between the pipeline handlers and IPA componenents.

The m68k architecture is the only target which fails this assertion, which is likely because it can pack the structure more efficiently, producing a different binary size.

Quoted 5 lines

This is likely an area we will tackle before stabilising our ABI, but until then, disable m68k builds as libcamera is not expected to be supported on this target.

Applied to master, after doing the slight adjustments suggested by Thomas:

- introduce BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
- propagate that to the comment
- add autobuilder reference

Thanks!

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/libcamera/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/libcamera/Config.in +2 -0
index 960d78b82e95..1ea747d1c57e 100644
@@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14
 	depends on !BR2_STATIC_LIBS # gnutls
 	depends on BR2_USE_WCHAR # gnutls
+	# Invalid packing size of ControlValue struct on m68k
+	depends on !BR2_m68k
 	select BR2_PACKAGE_GNUTLS
 	select BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
 	help
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#6 lore raw

PATCH 1/3 package/libcamera: Prevent builds on m68k

Kieran, All,

On 2020-09-04 22:33 +0200, Yann E. MORIN spake thusly:

Quoted 17 lines

On 2020-09-04 10:51 +0100, Kieran Bingham spake thusly:

Quoted 16 lines

The ControlValue structure is currently defined with a 16-bit hole (causing unaligned access to the numElements_ field, though that's a separate topic).

This structure has a static assertion to ensure that its size does not change without due care, as it forms part of our ABI and is used in Serialisation between the pipeline handlers and IPA componenents.

The m68k architecture is the only target which fails this assertion, which is likely because it can pack the structure more efficiently, producing a different binary size.

This is likely an area we will tackle before stabilising our ABI, but until then, disable m68k builds as libcamera is not expected to be supported on this target.

Quoted 8 lines
Quoted 1 line

Applied to master, after doing the slight adjustments suggested by Thomas:

- introduce BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
- propagate that to the comment
- add autobuilder reference

Ah, I forgot to note:
- move the arch dependency to the top (indeed we like to have those dependencies first:
https://buildroot.org/downloads/manual/manual.html#_config_files

Cheers!

Regards,
Yann E. MORIN.

Quoted 41 lines

Thanks!

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/libcamera/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/libcamera/Config.in +2 -0
index 960d78b82e95..1ea747d1c57e 100644
@@ -5,6 +5,8 @@ menuconfig BR2_PACKAGE_LIBCAMERA
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14
 	depends on !BR2_STATIC_LIBS # gnutls
 	depends on BR2_USE_WCHAR # gnutls
+	# Invalid packing size of ControlValue struct on m68k
+	depends on !BR2_m68k
 	select BR2_PACKAGE_GNUTLS
 	select BR2_PACKAGE_LIBCAMERA_PIPELINE_UVCVIDEO if !BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
 	help
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw

PATCH 1/3 package/libcamera: Prevent builds on m68k

In reply to Kieran Bingham
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Kieran" == Kieran Bingham <[email protected]> writes:

The ControlValue structure is currently defined with a 16-bit hole (causing unaligned access to the numElements_ field, though that's a separate topic).

This structure has a static assertion to ensure that its size does not change without due care, as it forms part of our ABI and is used in Serialisation between the pipeline handlers and IPA componenents.

The m68k architecture is the only target which fails this assertion, which is likely because it can pack the structure more efficiently, producing a different binary size.

Quoted 5 lines

This is likely an area we will tackle before stabilising our ABI, but until then, disable m68k builds as libcamera is not expected to be supported on this target.

Committed to 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#8 lore raw

PATCH 2/3 package/libcamera: Update requirements for C++17

In reply to Kieran Bingham

The libcamera project has moved to C++17. Update the toolchain requirements accordingly.

---
 package/libcamera/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/libcamera/Config.in +3 -3
index 1ea747d1c57e..262ea49a0ead 100644
@@ -2,7 +2,7 @@ menuconfig BR2_PACKAGE_LIBCAMERA
 	bool "libcamera"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++14
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
 	depends on !BR2_STATIC_LIBS # gnutls
 	depends on BR2_USE_WCHAR # gnutls
 	# Invalid packing size of ControlValue struct on m68k
@@ -65,6 +65,6 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_VIMC
 
 endif # BR2_PACKAGE_LIBCAMERA
 
-comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 5"
+comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_5 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
Signature · 1 line
2.25.1
#9 lore raw

PATCH 2/3 package/libcamera: Update requirements for C++17

Hello,

Quoted 4 lines · On Fri, 4 Sep 2020 10:51:46 +0100 Kieran Bingham…

The libcamera project has moved to C++17. Update the toolchain requirements accordingly.

Is this fixing some specific autobuilder failure ? If so, do you have a reference ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#10 lore raw

PATCH 2/3 package/libcamera: Update requirements for C++17

Hi Thomas,

Quoted 5 lines · Thomas Petazzoni

Hello,

On Fri, 4 Sep 2020 10:51:46 +0100
Kieran Bingham <[email protected]> wrote:

Quoted 7 lines
Quoted 4 lines

The libcamera project has moved to C++17. Update the toolchain requirements accordingly.

Is this fixing some specific autobuilder failure ? If so, do you have a reference ?

No, that's a pre-requisite for patch 3/3.

libcamera is now built with C++17 as a minimum requirement.

Quoted 3 lines

Thanks!

Thomas

Signature · 3 lines
Regards
--
Kieran
#11 lore raw

PATCH 2/3 package/libcamera: Update requirements for C++17

Quoted 3 lines · On Fri, 4 Sep 2020 13:55:17 +0100 Kieran Bingham…

No, that's a pre-requisite for patch 3/3.

libcamera is now built with C++17 as a minimum requirement.

In this case, we'll squash 2/3 and 3/3 together.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#12 lore raw

PATCH 2/3 package/libcamera: Update requirements for C++17

In reply to Kieran Bingham

Kieran, All,

On 2020-09-04 13:55 +0100, Kieran Bingham spake thusly:

Quoted 7 lines · Thomas Petazzoni
Quoted 6 lines
Quoted 3 lines · On Fri, 4 Sep 2020 10:51:46 +0100 Kieran Bingham…

The libcamera project has moved to C++17. Update the toolchain requirements accordingly.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Is this fixing some specific autobuilder failure ? If so, do you have a reference ?

No, that's a pre-requisite for patch 3/3. libcamera is now built with C++17 as a minimum requirement.

So the C++17 requirement comes with the version bump. In this case, it should be a single patch: bump and add new requirements.

Otherwise, if we end up not applying, or reverting patch 3, then C++17 requirement is superfluous on its own.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#13 lore raw

PATCH 3/3 package/libcamera: bump version to e59713c6

In reply to Kieran Bingham
---
 package/libcamera/libcamera.hash | 2 +-
 package/libcamera/libcamera.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/libcamera/libcamera.hash +1 -1
index 676d3ac73907..bc9122315166 100644
@@ -1,4 +1,4 @@
-sha256  55b7d7e5d8c70b2586b31544e6c4891a994c4e69c18d0ebd760e87b75277c348  libcamera-565f95d64ff92e8712e8090988180c343dd3bcb5.tar.gz
+sha256	a7800b54584dee321874610ef70b1b7690c79d8340c5b134ea35176657681e29  libcamera-e59713c68678f3eb6b6ebe97cabdc88c7042567f.tar.gz
 
 # license files
 sha256  fd38b2c053c0cce46d9c5ef3545a6e34d157a240ba99c9b8dca5d37a8147da6c  LICENSES/BSD-2-Clause.txt
package/libcamera/libcamera.mk +1 -1
index 4a4bc4ea90aa..e6cd71420774 100644
@@ -5,7 +5,7 @@
 ################################################################################
 
 LIBCAMERA_SITE = https://git.linuxtv.org/libcamera.git
-LIBCAMERA_VERSION = 565f95d64ff92e8712e8090988180c343dd3bcb5
+LIBCAMERA_VERSION = e59713c68678f3eb6b6ebe97cabdc88c7042567f
 LIBCAMERA_SITE_METHOD = git
 LIBCAMERA_DEPENDENCIES = \
 	host-openssl \
Signature · 1 line
2.25.1
#14 lore raw

cover libcamera: Fix and update libcamera package

In reply to Kieran Bingham
Quoted 17 lines · Kieran Bingham

Prevent compilation of libcamera on m68k architectures as we experience build failures there, and do not currently support that target with libcamera.

Then, update the build to require C++17, in anticipation of bumping the version to the latest upstream.

Kieran Bingham (3):
package/libcamera: Prevent builds on m68k package/libcamera: Update requirements for C++17 package/libcamera: bump version to e59713c6

  package/libcamera/Config.in      | 8 +++++---
  package/libcamera/libcamera.hash | 2 +-
  package/libcamera/libcamera.mk   | 2 +-
  3 files changed, 7 insertions(+), 5 deletions(-)
Quoted 8 lines

--
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Hello Keiran,

Just a small question if I am not bothering too much: Do we have a buildroot config option to build the gstreamer plugin for libcamera ? I am interested to try it out.

Thanks !

#15 lore raw

cover libcamera: Fix and update libcamera package

Hello Eugen,

Quoted 27 lines · Eugen.Hristev--- via buildroot
Quoted 17 lines · Kieran Bingham

Prevent compilation of libcamera on m68k architectures as we experience build failures there, and do not currently support that target with libcamera.

Then, update the build to require C++17, in anticipation of bumping the version to the latest upstream.

Kieran Bingham (3):
package/libcamera: Prevent builds on m68k package/libcamera: Update requirements for C++17 package/libcamera: bump version to e59713c6

  package/libcamera/Config.in      | 8 +++++---
  package/libcamera/libcamera.hash | 2 +-
  package/libcamera/libcamera.mk   | 2 +-
  3 files changed, 7 insertions(+), 5 deletions(-)
Quoted 8 lines

--
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Quoted 5 lines

Hello Keiran,

Just a small question if I am not bothering too much: Do we have a buildroot config option to build the gstreamer plugin for libcamera ? I am interested to try it out.

There is no extra libcamera package option to enable the gstreamer plugin, but in case the prerequisites are met (BR2_PACKAGE_GSTREAMER1 and BR2_PACKAGE_GST1_PLUGINS_BASE enabled) the plugin should be compiled and installed, see [1]...

Regards,
Peter

[1] https://git.buildroot.net/buildroot/tree/package/libcamera/libcamera.mk#n62

Quoted 6 lines

Thanks !
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot