Skip to contentSkip to conversation

package/kodi-visualisation-goom: needs glm

PATCH New Bernd Kuhls 2 participants 4 messages Jan 27, 2020 – Jan 28, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/kodi-visualisation-goom: needs glm

See CMakeLists.txt:
https://github.com/xbmc/visualization.goom/blob/Leia/CMakeLists.txt#L7

---
 package/kodi-visualisation-goom/Config.in                  | 1 +
 package/kodi-visualisation-goom/kodi-visualisation-goom.mk | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/kodi-visualisation-goom/Config.in +1 -0
index de4d2ef2ff..065bc1d773 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_KODI_VISUALISATION_GOOM
 	bool "kodi-visualisation-goom"
 	depends on BR2_PACKAGE_HAS_LIBGL
+	select BR2_PACKAGE_GLM
 	help
 	  GOOM visualiser for Kodi
 
package/kodi-visualisation-goom/kodi-visualisation-goom.mk +1 -1
index 487a520220..d742e00e5a 100644
@@ -9,6 +9,6 @@ KODI_VISUALISATION_GOOM_SITE = $(call github,xbmc,visualization.goom,$(KODI_VISU
 KODI_VISUALISATION_GOOM_LICENSE = GPL-2.0+
 KODI_VISUALISATION_GOOM_LICENSE_FILES = src/Main.cpp
 
-KODI_VISUALISATION_GOOM_DEPENDENCIES = kodi
+KODI_VISUALISATION_GOOM_DEPENDENCIES = glm kodi
 
 $(eval $(cmake-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 package/kodi-visualisation-goom: fix build with gcc-4.9

Fixes build error:

output/build/kodi-visualisation-goom-2.1.0-Leia/lib/goom/src/lines.c:
In function 'goom_lines_draw':
output/build/kodi-visualisation-goom-2.1.0-Leia/lib/goom/src/lines.c:232:3:
error: 'for' loop initial declarations are only allowed in C99 or C11 mode
for (int i = 1; i < AUDIO_SAMPLE_LEN; i++) {

---
 package/kodi-visualisation-goom/kodi-visualisation-goom.mk | 3 +++
 1 file changed, 3 insertions(+)
package/kodi-visualisation-goom/kodi-visualisation-goom.mk +3 -0
index d742e00e5a..0184d8474c 100644
@@ -11,4 +11,7 @@ KODI_VISUALISATION_GOOM_LICENSE_FILES = src/Main.cpp
 
 KODI_VISUALISATION_GOOM_DEPENDENCIES = glm kodi
 
+KODI_VISUALISATION_GOOM_CONF_OPTS += \
+	-DCMAKE_C_FLAGS="-std=c11"
+
 $(eval $(cmake-package))
Signature · 1 line
2.20.1
#2 lore raw

PATCH 2/2 package/kodi-visualisation-goom: fix build with gcc-4.9

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernd" == Bernd Kuhls <[email protected]> writes:

Fixes build error:
output/build/kodi-visualisation-goom-2.1.0-Leia/lib/goom/src/lines.c:
In function 'goom_lines_draw':
output/build/kodi-visualisation-goom-2.1.0-Leia/lib/goom/src/lines.c:232:3:
error: 'for' loop initial declarations are only allowed in C99 or C11 mode
for (int i = 1; i < AUDIO_SAMPLE_LEN; i++) {

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard