Skip to contentSkip to conversation

package/snort: fix error when building on a Fedora host machine

PATCH New Sergio Prado 3 participants 4 messages Dec 22, 2019 – Dec 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/snort: fix error when building on a Fedora host machine

Remove a logic from configure script that adds unsafe header/library path when cross-compiling on a Fedora host machine.

Fixes:
http://autobuild.buildroot.net/results/47a367c2c5cbf13079b0e60ad7ebe3dbd05756d4
http://autobuild.buildroot.net/results/837e43b085ac30fb8545c67352403ceb7de59976
http://autobuild.buildroot.net/results/a69df3959b45620f811c18744aa661caa479aef4
many more...

---
 ...en-building-on-a-Fedora-host-machine.patch | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 package/snort/0007-Fix-error-when-building-on-a-Fedora-host-machine.patch
package/snort/0007-Fix-error-when-building-on-a-Fedora-host-machine.patch new file +51 -0
new file mode 100644
index 000000000000..afe9672a3c2a
@@ -0,0 +1,51 @@
+From eae97632157b73f0ca7c099232617b2777d0fa54 Mon Sep 17 00:00:00 2001
+From: Sergio Prado <[email protected]>
+Date: Sat, 21 Dec 2019 12:00:42 -0300
+Subject: [PATCH] Fix error when building on a Fedora host machine.
+
+Remove the code that adds unsafe header/library path when
+cross-compiling on a Fedora host machine.
+
+Signed-off-by: Sergio Prado <[email protected]>
+---
+ configure.in | 24 ------------------------
+ 1 file changed, 24 deletions(-)
+
+diff --git a/configure.in b/configure.in
+index e6586f399898..fb35d4d7e3e3 100644
+--- a/configure.in
++++ b/configure.in
+@@ -957,30 +957,6 @@ if test "x$enable_dlclose" = "xno"; then
+     AC_DEFINE([DISABLE_DLCLOSE_FOR_VALGRIND_TESTING],[1],[Don't close opened shared objects for valgrind leak testing of dynamic libraries])
+ fi
+ 
+-##################################################
+-# Fedora 28+ does not have inbuilt SunRPC support#
+-# in glibc and is separately availble in tirpc   #
+-# package. Make sure we've got the library and   #
+-# link it                                        #
+-##################################################
+-
+-if test -f /etc/fedora-release ; then
+-    DISTRO_VERSION=$(awk '{ print $3 }' /etc/fedora-release)
+-    if test $DISTRO_VERSION -ge 28 ; then
+-        TIRPC=""
+-        AC_CHECK_LIB(tirpc,bindresvport,, TIRPC="no")
+-        echo "$TIRPC"
+-        if test "x$TIRPC" = "xno"; then
+-            echo
+-            echo " ERROR! tirpc not found, get it by running "
+-            echo " yum install libtirpc-devel "
+-            exit
+-        fi
+-        LIBS="${LIBS} -ltirpc"
+-        extra_incl="-I/usr/include/tirpc"
+-    fi
+-fi
+-
+ Z_LIB=""
+ AC_CHECK_HEADERS(zlib.h,, Z_LIB="no")
+ if test "x$Z_LIB" = "xno"; then
+-- 
+2.17.1
+
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/snort: fix error when building on a Fedora host machine

Quoted 9 lines · On Sun, 22 Dec 2019 06:17:07 -0300 Sergio Prado <[email protected]>…

Remove a logic from configure script that adds unsafe header/library path when cross-compiling on a Fedora host machine.

Fixes:
http://autobuild.buildroot.net/results/47a367c2c5cbf13079b0e60ad7ebe3dbd05756d4
http://autobuild.buildroot.net/results/837e43b085ac30fb8545c67352403ceb7de59976
http://autobuild.buildroot.net/results/a69df3959b45620f811c18744aa661caa479aef4
many more...

Quoted 5 lines
---
 ...en-building-on-a-Fedora-host-machine.patch | 51 +++++++++++++++++++
 1 file changed, 51 insertions(+)
 create mode 100644 package/snort/0007-Fix-error-when-building-on-a-Fedora-host-machine.patch

Applied to master, thanks. Could you report this bug to the upstream Snort developers, so that they can implement a solution that works well even in cross-compilation situations ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/snort: fix error when building on a Fedora host machine

Hi Thomas,

Quoted 2 lines

Applied to master, thanks. Could you report this bug to the upstream Snort developers, so that they can implement a solution that works well

even

Quoted 1 line

in cross-compilation situations ?

Reported:

https://lists.snort.org/pipermail/snort-devel/2019-December/011390.html

Thanks!

Sergio Prado
Embedded Labworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191222/eebd4903/attachment.html>

#3 lore raw

PATCH 1/1 package/snort: fix error when building on a Fedora host machine

In reply to Sergio Prado
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sergio" == Sergio Prado <[email protected]> writes:

Remove a logic from configure script that adds unsafe header/library path when cross-compiling on a Fedora host machine.

Quoted 7 lines

Fixes:
http://autobuild.buildroot.net/results/47a367c2c5cbf13079b0e60ad7ebe3dbd05756d4
http://autobuild.buildroot.net/results/837e43b085ac30fb8545c67352403ceb7de59976
http://autobuild.buildroot.net/results/a69df3959b45620f811c18744aa661caa479aef4
many more...

Committed to 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard