Skip to contentSkip to conversation

scanpypi: improve BSD licence handling

PATCH New yegorslists at googlemail.com 3 participants 3 messages Oct 11, 2018 – Oct 23, 2018

lore
Share & tools
lore

yegorslists at googlemail.com

author
#0 lore raw

PATCH 1/1 scanpypi: improve BSD licence handling

From: Yegor Yefremov <[email protected]>

When used without spdx_lookup the BSD licence cannot be detected correctly because many Python packages just specify BSD without the exact version in their metadata. So add a special message warning the user instead of the licence id.

Bonus: fix typo.

Signed-off-by Yegor Yefremov <[email protected]>
---
 utils/scanpypi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
utils/scanpypi +2 -2
index 31e242e3db..3983be1ad1 100755
@@ -395,7 +395,7 @@ class BuildrootPackage():
         """
         Try to determine the related license name.
 
-        There are two possibilities. Either the scripts tries to
+        There are two possibilities. Either the script tries to
         get license name from package's metadata or, if spdx_lookup
         package is available, the script compares license files with
         SPDX database.

@@ -404,7 +404,7 @@ class BuildrootPackage():
         if liclookup is None:
             license_dict = {
                 'Apache Software License': 'Apache-2.0',
-                'BSD License': 'BSD',
+                'BSD License': 'FIXME: please specify the exact BSD version',
                 'European Union Public Licence 1.0': 'EUPL-1.0',
                 'European Union Public Licence 1.1': 'EUPL-1.1',
                 "GNU General Public License": "GPL",
Signature · 1 line
2.17.0
Applied
#1 lore raw

PATCH 1/1 scanpypi: improve BSD licence handling

Hello,

Quoted 7 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>

When used without spdx_lookup the BSD licence cannot be detected correctly because many Python packages just specify BSD without the exact version in their metadata. So add a special message warning the user instead of the licence id.

Quoted 6 lines

Bonus: fix typo.

Signed-off-by Yegor Yefremov <[email protected]>
---
 utils/scanpypi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 scanpypi: improve BSD licence handling

In reply to yegorslists at googlemail.com
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"yegorslists" == yegorslists <[email protected]> writes:

From: Yegor Yefremov <[email protected]> When used without spdx_lookup the BSD licence cannot be detected correctly because many Python packages just specify BSD without the exact version in their metadata. So add a special message warning the user instead of the licence id.

Bonus: fix typo.

Signed-off-by Yegor Yefremov <[email protected]>

Committed to 2018.02.x and 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard