Skip to contentSkip to conversation

modem-manager: disable -Werror

PATCH New Peter Korsgaard 2 participants 3 messages May 21, 2018 – May 22, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 modem-manager: disable -Werror

Fixes:
http://autobuild.buildroot.net/results/5d9/5d9e299ff12726d07e8a584a213c1d2a2e419594/

The modem-manager build generates a number of build warnings like:

mm-base-manager.c: In function 'handle_set_logging':
mm-base-manager.c:680:15: error: assignment from incompatible pointer type [-Werror]

     ctx->self = g_object_ref (manager);

Which cause a build failure because of -Werror. Pass --disable-more-warnings to disable -Werror.

---
 package/modem-manager/modem-manager.mk | 1 +
 1 file changed, 1 insertion(+)
package/modem-manager/modem-manager.mk +1 -0
index 100c4a2941..fe4a7a95da 100644
@@ -11,6 +11,7 @@ MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
 MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
 MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2 libgudev
 MODEM_MANAGER_INSTALL_STAGING = YES
+MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
 
 ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
 MODEM_MANAGER_DEPENDENCIES += libqmi
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 modem-manager: disable -Werror

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes:
http://autobuild.buildroot.net/results/5d9/5d9e299ff12726d07e8a584a213c1d2a2e419594/

The modem-manager build generates a number of build warnings like:

mm-base-manager.c: In function 'handle_set_logging':
mm-base-manager.c:680:15: error: assignment from incompatible pointer type [-Werror]

ctx-> self = g_object_ref (manager);

Quoted 4 lines

Which cause a build failure because of -Werror. Pass --disable-more-warnings to disable -Werror.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 modem-manager: disable -Werror

Hello Peter, Carlos,

Quoted 9 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes:
http://autobuild.buildroot.net/results/5d9/5d9e299ff12726d07e8a584a213c1d2a2e419594/

The modem-manager build generates a number of build warnings like:

mm-base-manager.c: In function 'handle_set_logging':
mm-base-manager.c:680:15: error: assignment from incompatible pointer type [-Werror]

Quoted 8 lines

ctx-> self = g_object_ref (manager);

Quoted 4 lines

Which cause a build failure because of -Werror. Pass --disable-more-warnings to disable -Werror.

Committed, thanks.

Peter, thanks for fixing this issue.
Carlos, thanks for handling this issue (IMHO you could have assign yourself as modem-manager developer in DEVELOPERS).

Kind regards,
Petr