Skip to contentSkip to conversation

i2c: bcm2835: Avoid clock stretching timeouts

PATCH In review Stefan Wahren 3 participants 3 messages Feb 23, 2018 – Feb 7, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: bcm2835: Avoid clock stretching timeouts

From: Eric Anholt <[email protected]>

The CLKT register contains at poweron 0x40, which at our typical 100kHz bus rate means .64ms. But there is no specified limit to how long devices should be able to stretch the clocks, so just disable the timeout. We still have a timeout wrapping the entire transfer.

---
Hi,
just like "i2c: bcm2835: Set up the rising/falling edge delays" this is a outstanding bugfix. Unfortunately i only have I2C slaves, which doesn't stretch the clock. So test feedback is very welcome.

 drivers/i2c/busses/i2c-bcm2835.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/i2c/busses/i2c-bcm2835.c +11 -0
index 44deae7..ccd2565 100644
@@ -28,6 +28,11 @@
 #define BCM2835_I2C_FIFO	0x10
 #define BCM2835_I2C_DIV		0x14
 #define BCM2835_I2C_DEL		0x18
+/*
+ * 16-bit field for the number of SCL cycles to wait after rising SCL
+ * before deciding the slave is not responding.  0 disables the
+ * timeout detection.
+ */
 #define BCM2835_I2C_CLKT	0x1c
 
 #define BCM2835_I2C_C_READ	BIT(0)
@@ -386,6 +391,12 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
 	adap->dev.of_node = pdev->dev.of_node;
 	adap->quirks = &bcm2835_i2c_quirks;
 
+	/*
+	 * Disable the hardware clock stretching timeout.  SMBUS
+	 * specifies a limit for how long the device can stretch the
+	 * clock, but core I2C doesn't.
+	 */
+	bcm2835_i2c_writel(i2c_dev, BCM2835_I2C_CLKT, 0);
 	bcm2835_i2c_writel(i2c_dev, BCM2835_I2C_C, 0);
 
 	ret = i2c_add_adapter(adap);
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 i2c: bcm2835: Avoid clock stretching timeouts

Quoted 7 lines · Stefan Wahren

From: Eric Anholt <[email protected]>

The CLKT register contains at poweron 0x40, which at our typical 100kHz bus rate means .64ms. But there is no specified limit to how long devices should be able to stretch the clocks, so just disable the timeout. We still have a timeout wrapping the entire transfer.

Quoted 7 lines

---
Hi,
just like "i2c: bcm2835: Set up the rising/falling edge delays" this is a outstanding bugfix. Unfortunately i only have I2C slaves, which doesn't stretch the clock. So test feedback is very welcome.

I also didn't have any particular devices that this fixed. It was just
an issue that came up in a previous discussion of clock stretching.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180226/0b6ffd48/attachment.sig>

#2 lore raw
In reply to Stefan Wahren
Quoted 9 lines · Stefan Wahren

From: Eric Anholt <[email protected]>

The CLKT register contains at poweron 0x40, which at our typical 100kHz bus rate means .64ms. But there is no specified limit to how long devices should be able to stretch the clocks, so just disable the timeout. We still have a timeout wrapping the entire transfer.

Okay, it has been years but the issue came up again [1] so finally applied to for-current with stable added, thanks!

[1] http://patchwork.ozlabs.org/project/linux-i2c/patch/[email protected]/

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel