Skip to contentSkip to conversation

arm64: dts: marvell: armada-3720-db: Add vmmc regulator for SD slot

PATCH New Gregory CLEMENT 1 participant 2 messages Aug 29, 2017 – Sep 19, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: marvell: armada-3720-db: Add vmmc regulator for SD slot

By adding this regulator, a proper reset is done during boot. Without this, the UHS failed to be detected after a warm reboot when the SD card remained in the slot, then it fallback to an HS.

Note that the vmcc is supported by the xenon driver only with the following fix: "mmc: sdhci-xenon: add set_power callback".

---
 arch/arm64/boot/dts/marvell/armada-3720-db.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm64/boot/dts/marvell/armada-3720-db.dts +11 -0
index 9df0f06ce607..e6e0f38ce6e1 100644
@@ -94,6 +94,16 @@
 			  3300000 0x0>;
 		enable-active-high;
 	};
+
+	vcc_sd_reg2: regulator-vmcc {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_sd2";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		enable-active-high;
+		gpio = <&gpio_exp 4 GPIO_ACTIVE_HIGH>;
+	};
 };
 
 /* Gigabit module on CON19(V2.0)/CON21(V1.4) */
@@ -179,6 +189,7 @@
 	bus-width = <4>;
 	marvell,pad-type = "sd";
 	vqmmc-supply = <&vcc_sd_reg1>;
+	vmmc-supply = <&vcc_sd_reg2>;
 	status = "okay";
 };
 
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 arm64: dts: marvell: armada-3720-db: Add vmmc regulator for SD slot

Hi,

Quoted 8 lines · Gregory CLEMENT

By adding this regulator, a proper reset is done during boot. Without this, the UHS failed to be detected after a warm reboot when the SD card remained in the slot, then it fallback to an HS.

Note that the vmcc is supported by the xenon driver only with the following fix: "mmc: sdhci-xenon: add set_power callback".

Applied on mvebu/dt64

Gregory

Quoted 36 lines
---
 arch/arm64/boot/dts/marvell/armada-3720-db.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm64/boot/dts/marvell/armada-3720-db.dts +11 -0
index 9df0f06ce607..e6e0f38ce6e1 100644
@@ -94,6 +94,16 @@
 			  3300000 0x0>;
 		enable-active-high;
 	};
+
+	vcc_sd_reg2: regulator-vmcc {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc_sd2";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		enable-active-high;
+		gpio = <&gpio_exp 4 GPIO_ACTIVE_HIGH>;
+	};
 };
 
 /* Gigabit module on CON19(V2.0)/CON21(V1.4) */
@@ -179,6 +189,7 @@
 	bus-width = <4>;
 	marvell,pad-type = "sd";
 	vqmmc-supply = <&vcc_sd_reg1>;
+	vmmc-supply = <&vcc_sd_reg2>;
 	status = "okay";
 };
 
Signature · 1 line
2.14.1
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com