Skip to contentSkip to conversation

kmod: workaround for microblaze ld bug

PATCH New Waldemar Brodkorb 2 participants 2 messages Feb 18, 2017 – Feb 19, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kmod: workaround for microblaze ld bug

Add a workaround for a microblaze specific ld bug to avoid segfault.

Fixes:
http://autobuild.buildroot.net/results/aef1b915ffd3e5678af8682727c22c5618edfd89

---
 package/kmod/kmod.mk | 10 ++++++++++
 1 file changed, 10 insertions(+)
package/kmod/kmod.mk +10 -0
index 7492b92..2524bcd 100644
@@ -15,6 +15,16 @@ HOST_KMOD_DEPENDENCIES = host-pkgconf
 KMOD_LICENSE = LGPLv2.1+ (library)
 KMOD_LICENSE_FILES = libkmod/COPYING
 
+# --gc-sections triggers binutils ld segfault
+# https://sourceware.org/bugzilla/show_bug.cgi?id=21180
+ifeq ($(BR2_microblaze),y)
+define KMOD_PRECONFIGURE
+	sed -i 's:-Wl,--gc-sections::g' $(@D)/configure
+endef
+
+KMOD_PRE_CONFIGURE_HOOKS += KMOD_PRECONFIGURE
+endif
+
 # static linking not supported, see
 # https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/?id=b7016153ec8
 KMOD_CONF_OPTS = --disable-static --enable-shared
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 kmod: workaround for microblaze ld bug

Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Waldemar" == Waldemar Brodkorb <[email protected]> writes:

Add a workaround for a microblaze specific ld bug to avoid segfault.

Fixes:
http://autobuild.buildroot.net/results/aef1b915ffd3e5678af8682727c22c5618edfd89

---
 package/kmod/kmod.mk | 10 ++++++++++
 1 file changed, 10 insertions(+)
package/kmod/kmod.mk +0 -0
index 7492b92..2524bcd 100644

package/kmod/kmod.mk HOST_KMOD_DEPENDENCIES = host-pkgconf · line 22

Quoted 8 lines
package/kmod/kmod.mk +5 -0
@@ -15,6 +15,16 @@ HOST_KMOD_DEPENDENCIES = host-pkgconf
 KMOD_LICENSE = LGPLv2.1+ (library)
 KMOD_LICENSE_FILES = libkmod/COPYING
 
+# --gc-sections triggers binutils ld segfault
+# https://sourceware.org/bugzilla/show_bug.cgi?id=21180
+ifeq ($(BR2_microblaze),y)
+define KMOD_PRECONFIGURE
+	sed -i 's:-Wl,--gc-sections::g' $(@D)/configure

Patching the generated configure script is quite icky. We can just tell the configure script that --gc-sections aren't supported, so I've changed it to do:

KMOD_CONF_ENV += cc_cv_LDFLAGS__Wl___gc_sections=false

And committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard