Skip to contentSkip to conversation

core: do not remove dl/ directory on distclean

PATCH New Yann E. MORIN 4 participants 7 messages Jul 10, 2016 – Jul 12, 2016 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 core: do not remove dl/ directory on distclean

Currently, if the dl/ directory is the default location, it is removed on distclean.

However, the dl/ directory is a precious location: it contains all the tarballs downloaded so far, and some can be relatively huge, taking some previous time to re-download, especially on slowish links.

Don't remove it on distclean. If the user really needs to regain some space, leave it to him to clean this directory up manually.

---
 Makefile | 3 ---
 1 file changed, 3 deletions(-)
Makefile +0 -3
index 027f21c..5d840f6 100644
@@ -901,9 +901,6 @@ clean:
 		$(LEGAL_INFO_DIR) $(GRAPHS_DIR)
 
 distclean: clean
-ifeq ($(DL_DIR),$(TOPDIR)/dl)
-	rm -rf $(DL_DIR)
-endif
 ifeq ($(O),output)
 	rm -rf $(O)
 endif
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 core: do not remove dl/ directory on distclean

Hi Yann,

Quoted 9 lines · Yann E. MORIN

Currently, if the dl/ directory is the default location, it is removed on distclean.

However, the dl/ directory is a precious location: it contains all the tarballs downloaded so far, and some can be relatively huge, taking some previous time to re-download, especially on slowish links.

Don't remove it on distclean. If the user really needs to regain some space, leave it to him to clean this directory up manually.

Current Makefile help text for 'distclean' says:

delete all non-source files (including .config)

Not deleting the dl/ directory is not consistent with this description, IMO.

baruch

Quoted 19 lines
---
 Makefile | 3 ---
 1 file changed, 3 deletions(-)
Makefile +0 -3
index 027f21c..5d840f6 100644
@@ -901,9 +901,6 @@ clean:
 		$(LEGAL_INFO_DIR) $(GRAPHS_DIR)
 
 distclean: clean
-ifeq ($(DL_DIR),$(TOPDIR)/dl)
-	rm -rf $(DL_DIR)
-endif
 ifeq ($(O),output)
 	rm -rf $(O)
 endif
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 core: do not remove dl/ directory on distclean

Baruch, All,

On 2016-07-11 06:26 +0300, Baruch Siach spake thusly:

Quoted 8 lines · Yann E. MORIN
Quoted 7 lines

Currently, if the dl/ directory is the default location, it is removed on distclean.

However, the dl/ directory is a precious location: it contains all the tarballs downloaded so far, and some can be relatively huge, taking some previous time to re-download, especially on slowish links.

Quoted 8 lines
Quoted 2 lines

Don't remove it on distclean. If the user really needs to regain some space, leave it to him to clean this directory up manually.

Current Makefile help text for 'distclean' says:

delete all non-source files (including .config)

Not deleting the dl/ directory is not consistent with this description, IMO.

Well, I do understand it the other way: non-source files are deleted, but source files are not deleted.

And I would argue that the content of dl/ *are* source files. If anything, they are the archetype of source files.

Ergo, distclean should not remove them.

Regards,
Yann E. MORIN.

Quoted 26 lines

baruch

Quoted 19 lines
---
 Makefile | 3 ---
 1 file changed, 3 deletions(-)
Makefile +0 -3
index 027f21c..5d840f6 100644
@@ -901,9 +901,6 @@ clean:
 		$(LEGAL_INFO_DIR) $(GRAPHS_DIR)
 
 distclean: clean
-ifeq ($(DL_DIR),$(TOPDIR)/dl)
-	rm -rf $(DL_DIR)
-endif
 ifeq ($(O),output)
 	rm -rf $(O)
 endif
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 core: do not remove dl/ directory on distclean

Quoted 21 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Baruch, All,
On 2016-07-11 06:26 +0300, Baruch Siach spake thusly:

Quoted 8 lines · Yann E. MORIN
Quoted 7 lines

Currently, if the dl/ directory is the default location, it is removed on distclean.

However, the dl/ directory is a precious location: it contains all the tarballs downloaded so far, and some can be relatively huge, taking some previous time to re-download, especially on slowish links.

Quoted 8 lines
Quoted 2 lines

Don't remove it on distclean. If the user really needs to regain some space, leave it to him to clean this directory up manually.

Current Makefile help text for 'distclean' says:

delete all non-source files (including .config)

Not deleting the dl/ directory is not consistent with this description, IMO.

Quoted 7 lines

Well, I do understand it the other way: non-source files are deleted, but source files are not deleted.

And I would argue that the content of dl/ *are* source files. If anything, they are the archetype of source files.

Ergo, distclean should not remove them.

Sorry, I agree with Baruch. Distclean should leave the directory structure like it was when the buildroot tarball was extracted (or git cloned)

E.G. the GNU standard make targets state:

https://www.gnu.org/prep/standards/standards.html#Standard-Targets

?distclean?

Delete all files in the current directory (or created by this makefile) that are created by configuring or building the program. If you have unpacked the source and built the program without creating any other files, ?make distclean? should leave only the files that were in the distribution. However, there is no need to delete parent directories that were created with ?mkdir -p?, since they could have existed anyway.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 core: do not remove dl/ directory on distclean

Peter, All,

On 2016-07-11 22:03 +0200, Peter Korsgaard spake thusly:

Quoted 23 lines
Quoted 22 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Baruch, All,
On 2016-07-11 06:26 +0300, Baruch Siach spake thusly:

Quoted 8 lines · Yann E. MORIN
Quoted 7 lines

Currently, if the dl/ directory is the default location, it is removed on distclean.

However, the dl/ directory is a precious location: it contains all the tarballs downloaded so far, and some can be relatively huge, taking some previous time to re-download, especially on slowish links.

Quoted 8 lines
Quoted 2 lines

Don't remove it on distclean. If the user really needs to regain some space, leave it to him to clean this directory up manually.

Current Makefile help text for 'distclean' says:

delete all non-source files (including .config)

Not deleting the dl/ directory is not consistent with this description, IMO.

Well, I do understand it the other way: non-source files are deleted, but source files are not deleted.

Quoted 8 lines
Quoted 4 lines

And I would argue that the content of dl/ *are* source files. If anything, they are the archetype of source files.

Ergo, distclean should not remove them.

Sorry, I agree with Baruch. Distclean should leave the directory structure like it was when the buildroot tarball was extracted (or git cloned)

Right, on principle. Except...

Quoted 4 lines

E.G. the GNU standard make targets state:

https://www.gnu.org/prep/standards/standards.html#Standard-Targets

Quoted 8 lines

?distclean?

Delete all files in the current directory (or created by this makefile) that are created by configuring or building the program. If you have unpacked the source and built the program without creating any other files, ?make distclean? should leave only the files that were in the distribution. However, there is no need to delete parent directories that were created with ?mkdir -p?, since they could have existed anyway.

... we could (should?) consider that dl/ is a special case. It really holds content that can be difficult to retrieve.

Think of a tarball made from a git clone from a Linux kernel for example. This can be really costly to download, especially on slow links. For example:

Downloaded Repo
-----------------------------------------------------------------------------
1.02 GiB git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
1.43 GiB git://github.com/raspberrypi/linux.git

But Oh well... I'm not impacted as I have BR2_DL_DIR in my environment pointing somehwere else and reliable... I find it just sad that unsuspecting users, especially newcomers) would hit that when told to start over from scratch...

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 1/1 core: do not remove dl/ directory on distclean

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 13 lines

... we could (should?) consider that dl/ is a special case. It really holds content that can be difficult to retrieve.

Think of a tarball made from a git clone from a Linux kernel for example. This can be really costly to download, especially on slow links. For example:

Downloaded Repo
-----------------------------------------------------------------------------
1.02 GiB git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
1.43 GiB git://github.com/raspberrypi/linux.git

Quoted 4 lines

But Oh well... I'm not impacted as I have BR2_DL_DIR in my environment pointing somehwere else and reliable... I find it just sad that unsuspecting users, especially newcomers) would hit that when told to start over from scratch...

But aren't those people using 'make clean' instead of 'make distclean'? They should.

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard 
#6 lore raw

PATCH 1/1 core: do not remove dl/ directory on distclean

In reply to Yann E. MORIN

Hello,

Quoted 11 lines · Yann E. MORIN

Currently, if the dl/ directory is the default location, it is removed on distclean.

However, the dl/ directory is a precious location: it contains all the tarballs downloaded so far, and some can be relatively huge, taking some previous time to re-download, especially on slowish links.

Don't remove it on distclean. If the user really needs to regain some space, leave it to him to clean this directory up manually.

Like Baruch and Peter, I don't really see the need to change this behavior. Buildroot has beeing removing the default dl/ location during distclean for many years, without anybody complaining. It matches the GNU definition of "distclean" and changing this would break existing behavior with no good benefit.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com