Skip to contentSkip to conversation

dropwatch: Remove -Werror from CFLAGS

PATCH New Markos Chandras 2 participants 2 messages Oct 17, 2013 – Oct 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dropwatch: Remove -Werror from CFLAGS

-Werror shouldn't be used in released code since it can cause random build failures on moderate warnings. It also depends on the used toolchain since different toolchains may or may not print the same warnings.

Fixes the following build problem on MIPS64/n64:

main.c: In function handle_dm_alert_msg:
main.c:336:5: error: format %llx expects argument of type long long unsigned int, but argument 4 has type __u64 [-Werror=format=]

---
 package/dropwatch/dropwatch-03-remove-werror.patch | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 package/dropwatch/dropwatch-03-remove-werror.patch
package/dropwatch/dropwatch-03-remove-werror.patch new file +18 -0
new file mode 100644
index 0000000..97b26b7
@@ -0,0 +1,18 @@
+-Werror shouldn't be used in released code since it can
+cause random build failures on moderate warnings. It also
+depends on the used toolchain since different toolchains may
+or may not print the same warnings.
+
+Signed-off-by: Markos Chandras <[email protected]>
+
+Index: dropwatch-1.4/src/Makefile
+===================================================================
+--- dropwatch-1.4.orig/src/Makefile
++++ dropwatch-1.4/src/Makefile
+@@ -1,5 +1,5 @@
+ all: dropwatch
+-CFLAGS+=-c -g -D_GNU_SOURCE -Wall -Werror `pkg-config --cflags libnl-3.0`
++CFLAGS+=-c -g -D_GNU_SOURCE -Wall `pkg-config --cflags libnl-3.0`
+ LDFLAGS=-lbfd -lreadline -lnl-3 -lnl-genl-3
+ OBJFILES := main.o lookup.o\
+ 	 lookup_bfd.o lookup_kas.o
Signature · 1 line
1.8.4
#1 lore raw

PATCH 1/1 dropwatch: Remove -Werror from CFLAGS

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Markos" == Markos Chandras <[email protected]> writes:

-Werror shouldn't be used in released code since it can cause random build failures on moderate warnings. It also depends on the used toolchain since different toolchains may or may not print the same warnings.

Fixes the following build problem on MIPS64/n64:

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard