gpsd: dbus interface requires dbus-glib
PATCH 1/1 gpsd: dbus interface requires dbus-glib
gpsd uses dbus-glib as the dbus interface, so it should only be built if libglib2 has been selected. To simplify things, build dbus support only if dbus-glib is selected.
---
v2:
The select of DBUS_GLIB in Config.in created a circular dependency. So I simplified things by looking at DBUS_GLIB instead of DBUS for automatic enabling of dbus support.
Also added help text to explain this.
package/gpsd/Config.in | 2 ++ package/gpsd/gpsd.mk | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-)
package/gpsd/Config.in +2 -0
@@ -8,6 +8,8 @@ config BR2_PACKAGE_GPSD making all data on the location/course/velocity of the sensors available to be queried on TCP port 2947 of the host computer. + The D-Bus interface is included if dbus-glib is enabled. + http://gpsd.berlios.de/ config BR2_PACKAGE_GPSD_DEVICES
package/gpsd/gpsd.mk +2 -2
@@ -30,9 +30,9 @@ ifeq ($(BR2_PACKAGE_LIBUSB),y) GPSD_DEPENDENCIES += libusb endif -ifeq ($(strip $(BR2_PACKAGE_DBUS)),y) +ifeq ($(BR2_PACKAGE_DBUS_GLIB),y) GPSD_CONF_OPT += --enable-dbus - GPSD_DEPENDENCIES += dbus dbus-glib + GPSD_DEPENDENCIES += dbus-glib endif ifeq ($(BR2_PACKAGE_NCURSES),y)
Signature · 1 line
tg: (15fe220..) t/gpsd (depends on: master)
PATCH 1/1 gpsd: dbus interface requires dbus-glib
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:
Arnout> gpsd uses dbus-glib as the dbus interface, so it should only be Arnout> built if libglib2 has been selected. To simplify things, build Arnout> dbus support only if dbus-glib is selected.
Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <[email protected]> Arnout> ---
Arnout> v2:
Arnout> The select of DBUS_GLIB in Config.in created a circular Arnout> dependency.
Committed, thanks. It makes it easier for me if you also add [PATCHv2] in the subject, so I can easily see this replaces your earlier patch.
Signature · 1 line
Bye, Peter Korsgaard