Skip to contentSkip to conversation

OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0

PATCH New Santosh Shilimkar 2 participants 2 messages Mar 11, 2011 – Mar 24, 2011

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0

On OMAP4430 ES1.0, Power Management features are not supported. Avoid omap4_pm_init() on ES1.0 silicon so that we can continue to use same kernel binary to boot on all OMAP4 silicons.

The ES1.0 boot failure with OMAP4 PM series was because of the clockdomain initialisation code. Hardware supervised clockdomain mode isn't functional for all clockdomains on OMAP4430 ES1.0 silicon so avoid the same.

---
Patch applies on top of OMAP4 PM series

 arch/arm/mach-omap2/pm44xx.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/pm44xx.c +5 -0
index e887a5d..2e18c1d 100644
@@ -203,6 +203,11 @@ static int __init omap4_pm_init(void)
 	if (!cpu_is_omap44xx())
 		return -ENODEV;
 
+	if (omap_rev() == OMAP4430_REV_ES1_0) {
+		WARN(1, "Power Management not supported on OMAP4430 ES1.0\n");
+		return -ENODEV;
+	}
+
 	pr_err("Power Management for TI OMAP4.\n");
 
 #ifdef CONFIG_PM
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 OMAP4: PM: Avoid omap4_pm_init() on OMAP4430 ES1.0

Hi Santosh,

Quoted 9 lines · Santosh Shilimkar

On OMAP4430 ES1.0, Power Management features are not supported. Avoid omap4_pm_init() on ES1.0 silicon so that we can continue to use same kernel binary to boot on all OMAP4 silicons.

The ES1.0 boot failure with OMAP4 PM series was because of the clockdomain initialisation code. Hardware supervised clockdomain mode isn't functional for all clockdomains on OMAP4430 ES1.0 silicon so avoid the same.

Quoted 5 lines

---
Patch applies on top of OMAP4 PM series

This looks OK.

Please include in the repost of your OMAP4 PM series.

Kevin