Skip to contentSkip to conversation

arm: plat-omap: counter_32k: Fix build error due to IS_ERR

PATCH New Sourav Poddar 3 participants 3 messages Dec 7, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: plat-omap: counter_32k: Fix build error due to IS_ERR

Fix the following build error by including linux/err.h arch/arm/plat-omap/counter_32k.c: In function 'omap_init_clocksource_32k':
arch/arm/plat-omap/counter_32k.c:167: error: implicit declaration of
function 'IS_ERR'

The above error is due to the following commit:
subject: arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
commit: 235fbace0334c846c21e902f330020122fc85955

Created on linux-omap-2.6 branch: omap-fixes

---
 arch/arm/plat-omap/counter_32k.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/plat-omap/counter_32k.c +1 -0
index c1e0d00..8722a13 100644
@@ -16,6 +16,7 @@
 #include <linux/init.h>
 #include <linux/clk.h>
 #include <linux/io.h>
+#include <linux/err.h>
 
 #include <plat/common.h>
 #include <plat/board.h>
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 arm: plat-omap: counter_32k: Fix build error due to IS_ERR

Quoted 9 lines · Sourav Poddar

Fix the following build error by including linux/err.h arch/arm/plat-omap/counter_32k.c: In function 'omap_init_clocksource_32k':
arch/arm/plat-omap/counter_32k.c:167: error: implicit declaration of
function 'IS_ERR'

The above error is due to the following commit:
subject: arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
commit: 235fbace0334c846c21e902f330020122fc85955

Quoted 5 lines

Created on linux-omap-2.6 branch: omap-fixes

BTW, since this isn't in mainline yet, Tony you might want to fold into the orignal patch and just a note that Sourav has updated the commit to fix a compile error together with SOB ??

Signature · 1 line
balbi
#2 lore raw

PATCH 1/1 arm: plat-omap: counter_32k: Fix build error due to IS_ERR

In reply to Sourav Poddar
Quoted 9 lines · Sourav Poddar

Fix the following build error by including linux/err.h arch/arm/plat-omap/counter_32k.c: In function 'omap_init_clocksource_32k':
arch/arm/plat-omap/counter_32k.c:167: error: implicit declaration of
function 'IS_ERR'

The above error is due to the following commit:
subject: arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
commit: 235fbace0334c846c21e902f330020122fc85955

Quoted 5 lines

Created on linux-omap-2.6 branch: omap-fixes

Just noticed this one too.

Kevin