Skip to contentSkip to conversation

mach-iop32x/ Add nec ns-50 / ApplianceWare sanmina support

PATCH New Dan Williams 3 participants 4 messages Aug 30, 2009 – Sep 25, 2009 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 mach-iop32x/ Add nec ns-50 / ApplianceWare sanmina support

Quoted 7 lines · Arnaud Patard

Hi,

This patch is adding support for the nec ns-50/ApplianceWare Sanmina platform. This platforms is a nas based on iop80219 SoC.

This code has been tested on 2.6.31-rc*

Looks ok to me except for the bit modifying arch/arm/tools/mach-types.
You missed the notice at the top of the file:

# Please do not send patches to this file; it is automatically generated! # To add an entry into this database, please see Documentation/arm/README,

# or visit:
#
#   http://www.arm.linux.org.uk/developer/machines/?action=new

--
Dan

#2 lore raw

PATCH 1/1 mach-iop32x/ Add nec ns-50 / ApplianceWare sanmina support

Dan Williams <[email protected]> writes:

Hi,

Quoted 10 lines · Arnaud Patard
Quoted 7 lines

Hi,

This patch is adding support for the nec ns-50/ApplianceWare Sanmina platform. This platforms is a nas based on iop80219 SoC.

This code has been tested on 2.6.31-rc*

Looks ok to me except for the bit modifying arch/arm/tools/mach-types.

oops. Sent the wrong patch :(

New patch attached below.

Arnaud

This patch is adding support for the nec ns-50/ApplianceWare Sanmina platform. This platforms is a nas based on iop80219 SoC.

---
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sanmina.patch
Type: text/x-diff
Size: 8050 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20090923/41e60f51/attachment-0001.bin>

#3 lore raw

PATCH 1/1 mach-iop32x/ Add nec ns-50 / ApplianceWare sanmina support

Review

Quoted 4 lines · Arnaud Patard
(quoted diff) +4 -0
+static struct plat_serial8250_port sanmina_serial_port[] = {
+	{
+		.mapbase	= IQ31244_UART,
+		.membase	= (char *)IQ31244_UART,

This can't be right.

Review

Quoted 12 lines
(quoted diff) +12 -0
+		.irq		= IRQ_IOP32X_XINT3,
+		.flags		= UPF_SKIP_TEST | UPF_SHARE_IRQ,
+		.iotype		= UPIO_MEM,
+		.regshift	= 0,
+		.uartclk	= 14745600,
+	},
+	{ },
+};
+
+static struct resource sanmina_uart_resource = {
+	.start		= IQ31244_UART,
+	.end		= IQ31244_UART + 0x3f,

and neither can this. Resources are bus addresses, not virtual addresses.

#4 lore raw

PATCH 1/1 mach-iop32x/ Add nec ns-50 / ApplianceWare sanmina support

Russell King - ARM Linux <[email protected]> writes:

Hi,

Quoted 7 lines · Arnaud Patard

Review

Quoted 4 lines
(quoted diff) +4 -0
+static struct plat_serial8250_port sanmina_serial_port[] = {
+	{
+		.mapbase	= IQ31244_UART,
+		.membase	= (char *)IQ31244_UART,

This can't be right.

It is kind of right and it's working fine. You've made the same remark when I've submitted the em7210 support :) (fwiw, the sanmina.c file is based on my em7210.c code) See
http://lists.arm.linux.org.uk/lurker/message/20070715.164059.ac9fbe0a.en.html

Arnaud