Linux 2.6.16.17
Subsystems (21)
We (the -stable team) are announcing the release of the 2.6.16.17 kernel. Couple security relevant patches in there, the SCTP patches came in post review cycle.
The diffstat and short summary of the fixes are below.
I'll also be replying to this message with a copy of the patch between 2.6.16.16 and 2.6.16.17, as it is small enough to do so.
The updated 2.6.16.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git
and can be browsed at the normal kernel.org git web browser:
www.kernel.org/git/
thanks,
-chris
--------
Makefile | 2 - block/elevator.c | 8 ++++- block/ll_rw_blk.c | 17 ++++++++++- drivers/block/ub.c | 18 ++++++------ drivers/char/pcmcia/cm4000_cs.c | 10 ++++-- drivers/char/pcmcia/cm4040_cs.c | 11 ++++--- drivers/i2c/busses/scx200_acb.c | 4 -- drivers/md/raid10.c | 2 - drivers/net/tg3.c | 8 +++-- drivers/net/via-rhine.c | 6 ++++ drivers/pci/pci-acpi.c | 60 +++++++++++++++++++++++----------------- drivers/pci/quirks.c | 22 ++++++++++++-- fs/compat.c | 2 - fs/locks.c | 30 ++++++++++---------- fs/smbfs/request.c | 4 ++ include/net/sctp/sctp.h | 6 ++-- kernel/ptrace.c | 57 ++++++++++++++++++++++++++------------ mm/mempolicy.c | 1 mm/shmem.c | 1 mm/vmscan.c | 11 +++++++ net/ipv4/netfilter/arp_tables.c | 2 - net/ipv4/netfilter/ip_tables.c | 2 - net/ipv6/netfilter/ip6_tables.c | 2 - net/sctp/sm_statefuns.c | 6 ++++ security/selinux/ss/services.c | 4 ++ 25 files changed, 200 insertions(+), 96 deletions(-)
Summary of changes from v2.6.16.16 to v2.6.16.17
================================================
Alexey Dobriyan:
fs/compat.c: fix 'if (a |= b )' typo
Carl-Daniel Hailfinger:
smbus unhiding kills thermal management
Chris Wedgwood:
PCI quirk: VIA IRQ fixup should only run for VIA southbridges VIA quirk fixup, additional PCI IDs
Chris Wright:
Netfilter: do_add_counters race, possible oops or info leak (CVE-2006-0039) Linux 2.6.16.17
Christoph Lameter:
Remove cond_resched in gather_stats()
page migration: Fix fallback behavior for dirty pages
Craig Brind:
via-rhine: zero pad short packets on Rhine I ethernet cards
Harald Welte:
Fix udev device creation
Jan Niehusmann:
smbfs: Fix slab corruption in samba error path
Jean Delvare:
scx200_acb: Fix resource name use after free
Jens Axboe:
limit request_fn recursion
Karsten Keil:
TG3: ethtool always report port is TP.
Kristen Accardi:
PCI: correctly allocate return buffers for osc calls
Lee Schermerhorn:
add migratepage address space op to shmem
Linus Torvalds:
Fix ptrace_attach()/ptrace_traceme()/de_thread() race
ptrace_attach: fix possible deadlock schenario with irqs
NeilBrown:
md: Avoid oops when attempting to fix read errors on raid10
Pete Zaitcev:
USB: ub oops in block_uevent
Serge E. Hallyn:
selinux: check for failed kmalloc in security_sid_to_context()
Trond Myklebust:
fs/locks.c: Fix sys_flock() race
Vladislav Yasevich:
SCTP: Respect the real chunk length when walking parameters (CVE-2006-1858)
SCTP: Validate the parameter length in HB-ACK chunk (CVE-2006-1857)
Makefile +1 -1
@@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 16 -EXTRAVERSION = .16 +EXTRAVERSION = .17 NAME=Sliding Snow Leopard # *DOCUMENTATION*
block/elevator.c +7 -1
@@ -314,6 +314,7 @@ void elv_insert(request_queue_t *q, stru {struct list_head *pos;unsigned ordseq; +int unplug_it =1 ; rq->q = q;
@@ -378,6 +379,11 @@ void elv_insert(request_queue_t *q, stru }list_add_tail (&rq->queuelist, pos); +/* +* most requeues happen because of a busy condition, don't +* force unplug of the queue for that case. +*/ + unplug_it =0 ;break ;default :
@@ -386,7 +392,7 @@ void elv_insert(request_queue_t *q, struBUG (); } -if (blk_queue_plugged (q)) { +if (unplug_it &&blk_queue_plugged (q)) {int nrq = q->rq.count[READ ] + q->rq.count[WRITE ] - q->in_flight;
block/ll_rw_blk.c +15 -2
@@ -1719,8 +1719,21 @@ void blk_run_queue(struct request_queuespin_lock_irqsave (q->queue_lock, flags);blk_remove_plug (q); -if (!elv_queue_empty (q)) - q->request_fn (q); + +/* +* Only recurse once to avoid overrunning the stack, let the unplug +* handling reinvoke the handler shortly if we already got there. +*/ +if (!elv_queue_empty (q)) { +if (!test_and_set_bit (QUEUE_FLAG_REENTER , &q->queue_flags)) { + q->request_fn (q); +clear_bit (QUEUE_FLAG_REENTER , &q->queue_flags); + }else { +blk_plug_device (q); +kblockd_schedule_work (&q->unplug_work); + } + } +spin_unlock_irqrestore (q->queue_lock, flags); }EXPORT_SYMBOL (blk_run_queue);
drivers/block/ub.c +10 -8
@@ -704,6 +704,9 @@ static void ub_cleanup(struct ub_dev *sckfree (lun); } +usb_set_intfdata (sc->intf,NULL ); +usb_put_intf (sc->intf); +usb_put_dev (sc->dev);kfree (sc); }
@@ -2428,7 +2431,12 @@ static int ub_probe(struct usb_interface// sc->ifnum = intf->cur_altsetting->desc.bInterfaceNumber; usb_set_intfdata (intf, sc);usb_get_dev (sc->dev); -// usb_get_intf(sc->intf); /* Do we need this? */ +/* +* Since we give the interface struct to the block level through +* disk->driverfs_dev, we have to pin it. Otherwise, block_uevent +* oopses on close after a disconnect (kernels 2.6.16 and up). +*/ +usb_get_intf (sc->intf);snprintf (sc->name,12 ,DRV_NAME "(%d.%d)" , sc->dev->bus->busnum, sc->dev->devnum);
@@ -2509,7 +2517,7 @@ #endif err_diag: err_dev_desc:usb_set_intfdata (intf,NULL ); -// usb_put_intf(sc->intf); +usb_put_intf (sc->intf);usb_put_dev (sc->dev);kfree (sc); err_core:
@@ -2688,12 +2696,6 @@ static void ub_disconnect(struct usb_int*/ device_remove_file (&sc->intf->dev, &dev_attr_diag); -usb_set_intfdata (intf,NULL ); -// usb_put_intf(sc->intf); - sc->intf =NULL ; -usb_put_dev (sc->dev); - sc->dev =NULL ; -ub_put (sc); }
drivers/char/pcmcia/cm4000_cs.c +6 -4
@@ -2010,10 +2010,6 @@ static int __init cmm_init(void)if (!cmm_class)return -1 ; - rc =pcmcia_register_driver (&cm4000_driver); -if (rc <0 ) -return rc; - major =register_chrdev (0 ,DEVICE_NAME , &cm4000_fops);if (major <0 ) { printk(KERN_WARNING MODULE_NAME
@@ -2021,6 +2017,12 @@ static int __init cmm_init(void)return -1 ; } + rc =pcmcia_register_driver (&cm4000_driver); +if (rc <0 ) { +unregister_chrdev (major,DEVICE_NAME ); +return rc; + } +return 0 ; }
drivers/char/pcmcia/cm4040_cs.c +7 -4
@@ -769,16 +769,19 @@ static int __init cm4040_init(void)if (!cmx_class)return -1 ; - rc =pcmcia_register_driver (&reader_driver); -if (rc <0 ) -return rc; - major =register_chrdev (0 ,DEVICE_NAME , &reader_fops);if (major <0 ) { printk(KERN_WARNING MODULE_NAME ": could not get major number\n");return -1 ; } + + rc =pcmcia_register_driver (&reader_driver); +if (rc <0 ) { +unregister_chrdev (major,DEVICE_NAME ); +return rc; + } +return 0 ; }
drivers/i2c/busses/scx200_acb.c +1 -3
@@ -440,7 +440,6 @@ static int __init scx200_acb_create(intstruct scx200_acb_iface *iface;struct i2c_adapter *adapter;int rc =0 ; -char description[64 ]; iface =kzalloc (sizeof (*iface),GFP_KERNEL );if (!iface) {
@@ -459,8 +458,7 @@ static int __init scx200_acb_create(intinit_MUTEX (&iface->sem); -snprintf (description,sizeof (description),"NatSemi SCx200 ACCESS.bus [%s]" , adapter->name); -if (request_region (base,8 , description) ==0 ) { +if (!request_region (base,8 , adapter->name)) {dev_err (&adapter->dev,"can't allocate io 0x%x-0x%x\n" , base, base +8 -1 ); rc = -EBUSY ;
drivers/md/raid10.c +1 -1
@@ -1436,9 +1436,9 @@ static void raid10d(mddev_t *mddev) sl--; d = r10_bio->devs[sl].devnum; rdev = conf->mirrors[d].rdev; -atomic_add (s, &rdev->corrected_errors);if (rdev &&test_bit (In_sync, &rdev->flags)) { +atomic_add (s, &rdev->corrected_errors); if (sync_page_io(rdev->bdev, r10_bio->devs[sl].addr + sect + rdev->data_offset,
drivers/net/tg3.c +5 -3
@@ -7368,21 +7368,23 @@ static int tg3_get_settings(struct net_d cmd->supported |= (SUPPORTED_1000baseT_Half | SUPPORTED_1000baseT_Full); -if (!(tp->tg3_flags2 &TG3_FLG2_ANY_SERDES )) +if (!(tp->tg3_flags2 &TG3_FLG2_ANY_SERDES )) { cmd->supported |= (SUPPORTED_100baseT_Half | SUPPORTED_100baseT_Full | SUPPORTED_10baseT_Half | SUPPORTED_10baseT_Full |SUPPORTED_MII ); -else + cmd->port =PORT_TP ; + }else { cmd->supported |=SUPPORTED_FIBRE ; + cmd->port =PORT_FIBRE ; + } cmd->advertising = tp->link_config.advertising;if (netif_running (dev)) { cmd->speed = tp->link_config.active_speed; cmd->duplex = tp->link_config.active_duplex; } - cmd->port =0 ; cmd->phy_address =PHY_ADDR ; cmd->transceiver =0 ; cmd->autoneg = tp->link_config.autoneg;
drivers/net/via-rhine.c +6 -0
@@ -129,6 +129,7 @@- Massive clean-up - Rewrite PHY, media handling (remove options, full_duplex, backoff) - Fix Tx engine race for good +- Craig Brind: Zero padded aligned buffers for short packets. */
@@ -1306,7 +1307,12 @@ static int rhine_start_tx(struct sk_buff rp->stats.tx_dropped++;return 0 ; } + +/* Padding is not copied and so must be redone. */ skb_copy_and_csum_dev (skb, rp->tx_buf[entry]); +if (skb->len <ETH_ZLEN ) +memset (rp->tx_buf[entry] + skb->len,0 , +ETH_ZLEN - skb->len); rp->tx_skbuff_dma[entry] =0 ; rp->tx_ring[entry].addr = cpu_to_le32(rp->tx_bufs_dma + (rp->tx_buf[entry] -
drivers/pci/pci-acpi.c +35 -25
112 lines not on this page · raw message
drivers/pci/quirks.c +19 -3
@@ -631,6 +631,9 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_V* non-x86 architectures (yes Via exists on PPC among other places), * we must mask the PCI_INTERRUPT_LINE value versus 0xf to get * interrupts delivered properly. +* +* Some of the on-chip devices are actually '586 devices' so they are +* listed here. */ static void quirk_via_irq (struct pci_dev *dev) {
@@ -639,13 +642,19 @@ static void quirk_via_irq(struct pci_dev new_irq = dev->irq &0xf ;pci_read_config_byte (dev,PCI_INTERRUPT_LINE , &irq);if (new_irq != irq) { -printk (KERN_INFO "PCI: Via IRQ fixup for %s, from %d to %d\n" , +printk (KERN_INFO "PCI: VIA IRQ fixup for %s, from %d to %d\n" ,pci_name (dev), irq, new_irq);udelay (15 );/* unknown if delay really needed */ pci_write_config_byte (dev,PCI_INTERRUPT_LINE , new_irq); } } -DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_ANY_ID , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_0 , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_1 , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_2 , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_3 , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C686 , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C686_4 , quirk_via_irq); +DECLARE_PCI_FIXUP_ENABLE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C686_5 , quirk_via_irq);/* * VIA VT82C598 has its device ID settable and many BIOSes
@@ -861,6 +870,7 @@ static void __init quirk_eisa_bridge(str }DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82375 , quirk_eisa_bridge ); +#ifndef CONFIG_ACPI_SLEEP /* * On ASUS P4B boards, the SMBus PCI Device within the ICH2/4 southbridge * is not activated. The myth is that Asus said that they do not want the
@@ -872,8 +882,12 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_I* bridge. Unfortunately, this device has no subvendor/subdevice ID. So it * becomes necessary to do this tweak in two steps -- I've chosen the Host * bridge as trigger. +* +* Actually, leaving it unhidden and not redoing the quirk over suspend2ram +* will cause thermal management to break down, and causing machine to +* overheat. */ -static int __initdata asus_hides_smbus =0 ; +static int __initdata asus_hides_smbus;static void __init asus_hides_smbus_hostbridge (struct pci_dev *dev) {
@@ -1008,6 +1022,8 @@ static void __init asus_hides_smbus_lpc_ }DECLARE_PCI_FIXUP_HEADER (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_ICH6_1 , asus_hides_smbus_lpc_ich6 ); +#endif +/* * SiS 96x south bridge: BIOS typically hides SMBus device... */
fs/compat.c +1 -1
@@ -1901,7 +1901,7 @@ asmlinkage long compat_sys_ppoll(struct }if (sigmask) { -if (sigsetsize |=sizeof (compat_sigset_t)) +if (sigsetsize !=sizeof (compat_sigset_t))return -EINVAL ;if (copy_from_user (&ss32, sigmask,sizeof (ss32)))return -EFAULT ;
fs/locks.c +16 -14
@@ -714,8 +714,9 @@ EXPORT_SYMBOL(posix_locks_deadlock);* at the head of the list, but that's secret knowledge known only to * flock_lock_file and posix_lock_file. */ -static int flock_lock_file (struct file *filp,struct file_lock *new_fl) +static int flock_lock_file (struct file *filp,struct file_lock *request) { +struct file_lock *new_fl =NULL ;struct file_lock **before;struct inode * inode = filp->f_dentry->d_inode;int error =0 ;
@@ -730,17 +731,19 @@ static int flock_lock_file(struct file *continue ;if (filp != fl->fl_file)continue ; -if (new_fl->fl_type == fl->fl_type) +if (request->fl_type == fl->fl_type) goto out; found =1 ;locks_delete_lock (before);break ; } -unlock_kernel (); -if (new_fl->fl_type ==F_UNLCK ) -return 0 ; +if (request->fl_type ==F_UNLCK ) + goto out; + new_fl =locks_alloc_lock (); +if (new_fl ==NULL ) + goto out;/* * If a higher-priority process was blocked on the old file lock, * give it the opportunity to lock the file.
@@ -748,26 +751,27 @@ static int flock_lock_file(struct file *if (found)cond_resched (); -lock_kernel ();for_each_lock (inode, before) {struct file_lock *fl = *before;if (IS_POSIX (fl))break ;if (IS_LEASE (fl))continue ; -if (!flock_locks_conflict (new_fl, fl)) +if (!flock_locks_conflict (request, fl))continue ; error = -EAGAIN ; -if (new_fl->fl_flags &FL_SLEEP ) { -locks_insert_block (fl, new_fl); - } +if (request->fl_flags &FL_SLEEP ) +locks_insert_block (fl, request); goto out; } +locks_copy_lock (new_fl, request);locks_insert_lock (&inode->i_flock, new_fl); - error =0 ; + new_fl =NULL ; out:unlock_kernel (); +if (new_fl) +locks_free_lock (new_fl);return error; }
@@ -1532,9 +1536,7 @@ asmlinkage long sys_flock(unsigned int f error =flock_lock_file_wait (filp, lock); out_free: -if (list_empty (&lock->fl_link)) { -locks_free_lock (lock); - } +locks_free_lock (lock); out_putf:fput (filp);
fs/smbfs/request.c +3 -1
@@ -339,9 +339,11 @@ #endif/* * On timeout or on interrupt we want to try and remove the * request from the recvq/xmitq. +* First check if the request is still part of a queue. (May +* have been removed by some error condition) */ smb_lock_server (server); -if (!(req->rq_flags &SMB_REQ_RECEIVED )) { +if (!list_empty (&req->rq_queue)) {list_del_init (&req->rq_queue);smb_rput (req); }
include/net/sctp/sctp.h +3 -3
@@ -461,12 +461,12 @@ static inline int sctp_frag_point(const* there is room for a param header too. */ #define sctp_walk_params (pos, chunk, member)\ -_sctp_walk_params((pos), (chunk), WORD_ROUND(ntohs((chunk)->chunk_hdr.length)), member) +_sctp_walk_params((pos), (chunk), ntohs((chunk)->chunk_hdr.length), member)#define _sctp_walk_params (pos, chunk, end, member)\ for (pos.v = chunk->member;\ pos.v <= (void *)chunk + end - sizeof(sctp_paramhdr_t) &&\ - pos.v <= (void *)chunk + end - WORD_ROUND(ntohs(pos.p->length)) &&\ + pos.v <= (void *)chunk + end - ntohs(pos.p->length) &&\ ntohs(pos.p->length) >= sizeof(sctp_paramhdr_t);\ pos.v += WORD_ROUND(ntohs(pos.p->length)))
@@ -477,7 +477,7 @@ #define _sctp_walk_errors(err, chunk_hdrfor (err = (sctp_errhdr_t *)((void *)chunk_hdr + \sizeof (sctp_chunkhdr_t));\ (void *)err <= (void *)chunk_hdr + end -sizeof (sctp_errhdr_t) &&\ - (void *)err <= (void *)chunk_hdr + end -WORD_ROUND (ntohs (err->length)) &&\ + (void *)err <= (void *)chunk_hdr + end -ntohs (err->length) &&\ntohs (err->length) >=sizeof (sctp_errhdr_t); \ err = (sctp_errhdr_t *)((void *)err +WORD_ROUND (ntohs (err->length))))
kernel/ptrace.c +39 -18
89 lines not on this page · raw message
mm/mempolicy.c +0 -1
@@ -1796,7 +1796,6 @@ static void gather_stats(struct page *pa md->mapcount_max = count; md->node[page_to_nid (page)]++; -cond_resched (); }#ifdef CONFIG_HUGETLB_PAGE
mm/shmem.c +1 -0
@@ -2172,6 +2172,7 @@ #ifdef CONFIG_TMPFS .prepare_write = shmem_prepare_write, .commit_write = simple_commit_write, #endif + .migratepage = migrate_page, }; static struct file_operations shmem_file_operations = {
mm/vmscan.c +11 -0
@@ -949,6 +949,17 @@ redo: goto unlock_both; } +/* Make sure the dirty bit is up to date */ +if (try_to_unmap (page,1 ) ==SWAP_FAIL ) { + rc = -EPERM ; + goto unlock_both; + } + +if (page_mapcount (page)) { + rc = -EAGAIN ; + goto unlock_both; + } +/* * Default handling if a filesystem does not provide * a migration function. We can only migrate clean
net/ipv4/netfilter/arp_tables.c +1 -1
@@ -941,7 +941,7 @@ static int do_add_counters(void __user *write_lock_bh (&t->lock); private = t->private; -if (private->number != paddc->num_counters) { +if (private->number != tmp.num_counters) { ret = -EINVAL ; goto unlock_up_free; }
net/ipv4/netfilter/ip_tables.c +1 -1
@@ -1063,7 +1063,7 @@ do_add_counters(void __user *user, unsigwrite_lock_bh (&t->lock); private = t->private; -if (private->number != paddc->num_counters) { +if (private->number != tmp.num_counters) { ret = -EINVAL ; goto unlock_up_free; }
net/ipv6/netfilter/ip6_tables.c +1 -1
@@ -1120,7 +1120,7 @@ do_add_counters(void __user *user, unsigwrite_lock_bh (&t->lock); private = t->private; -if (private->number != paddc->num_counters) { +if (private->number != tmp.num_counters) { ret = -EINVAL ; goto unlock_up_free; }
net/sctp/sm_statefuns.c +6 -0
@@ -1030,6 +1030,12 @@ sctp_disposition_t sctp_sf_backbeat_8_3( commands); hbinfo = (sctp_sender_hb_info_t *) chunk->skb->data; +/* Make sure that the length of the parameter is what we expect */ +if (ntohs (hbinfo->param_hdr.length) != +sizeof (sctp_sender_hb_info_t)) { +return SCTP_DISPOSITION_DISCARD ; + } + from_addr = hbinfo->daddr; link =sctp_assoc_lookup_paddr (asoc, &from_addr);
security/selinux/ss/services.c +4 -0
@@ -592,6 +592,10 @@ int security_sid_to_context(u32 sid, cha *scontext_len =strlen (initial_sid_to_string[sid]) +1 ; scontextp =kmalloc (*scontext_len,GFP_ATOMIC ); +if (!scontextp) { + rc = -ENOMEM ; + goto out; + }strcpy (scontextp, initial_sid_to_string[sid]); *scontext = scontextp; goto out;
On 21 May 2006, Chris Wright announced:
Quoted 2 lines
Harald Welte:
Fix udev device creation
As an aside, patches Cc:ed to stable that concern only a few specific drivers should probably mention the driver in the short changelog; e.g. this is specific to cm4000_cs.
(Anyone who really cares about system stability and isn't running a distro kernel should probably be checking things at the review phase anyway, so this is rather pedantic of me and may not actually affect anyone. As a mere user I'm very impressed with the -stable process; many other projects could do with something like it.)
Signature · 3 lines
`On a scale of 1-10, X's "brokenness rating" is 1.1, but that's only because bringing Windows into the picture rescaled "brokenness" by a factor of 10.' --- Peter da Silva
Quoted 7 lines · Nix
On 21 May 2006, Chris Wright announced:
Quoted 2 lines
Harald Welte:
Fix udev device creationAs an aside, patches Cc:ed to stable that concern only a few specific drivers should probably mention the driver in the short changelog; e.g. this is specific to
cm4000_cs.
yes, I very much second that. To the best of my knowledge, I didn't submit the patch to stable@ myself, but somebody else picked it up. I wasn't really sure whether it really fits the stable@ policy,
Anyway, my original posting contained the driver name in the subject line.
Signature · 5 lines
- Harald Welte <[email protected]> http://netfilter.org/ ============================================================================ "Fragmentation is like classful addressing -- an interesting early architectural error that shows how much experimentation was going on while IP was being designed." -- Paul Vixie