Skip to contentSkip to conversation

package/libsvgtiny: add patch to fix GCC 15.x build issue

PATCH In review Thomas Petazzoni via buildroot 2 participants 6 messages Aug 28, 2025 – Aug 29, 2025

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 package/libsvgtiny: add patch to fix GCC 15.x build issue

Add a small, easily backportable patch to fix GCC 15.x build issue. The issue is also fixed upstream in later releases, but this patch is a minimal fix that can be backported to LTS independently from a version bump.

Fixes:

https://autobuild.buildroot.org/results/c3d703663faabe40448d908afbdbb351a016aece/

---
v1 -> v2: no changes

 ...ient-svgtiny_list-.c-add-missing-std.patch | 42 +++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 package/libsvgtiny/0005-src-svgtiny_gradient-svgtiny_list-.c-add-missing-std.patch
package/libsvgtiny/0005-src-svgtiny_gradient-svgtiny_list-.c-add-missing-std.patch new file +42 -0
new file mode 100644
index 0000000000..17e63ba541
@@ -0,0 +1,42 @@
+From 1d86ce7e6ea9fae8285eed23d838f87ab3ac083c Mon Sep 17 00:00:00 2001
+From: Thomas Petazzoni <[email protected]>
+Date: Tue, 19 Aug 2025 23:28:35 +0200
+Subject: [PATCH] src/{svgtiny_gradient,svgtiny_list}.c: add missing <stdlib.h>
+
+Needed to get the prototype for malloc()/free().
+
+Upstream: N/A, already fixed upstream in a later release (but as part
+of a larger commit)
+Signed-off-by: Thomas Petazzoni <[email protected]>
+---
+ src/svgtiny_gradient.c | 1 +
+ src/svgtiny_list.c     | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/src/svgtiny_gradient.c b/src/svgtiny_gradient.c
+index 3a8db73..5172223 100644
+--- a/src/svgtiny_gradient.c
++++ b/src/svgtiny_gradient.c
+@@ -8,6 +8,7 @@
+ #include <assert.h>
+ #include <math.h>
+ #include <string.h>
++#include <stdlib.h>
+ #include "svgtiny.h"
+ #include "svgtiny_internal.h"
+ 
+diff --git a/src/svgtiny_list.c b/src/svgtiny_list.c
+index 53cfb34..91e2c98 100644
+--- a/src/svgtiny_list.c
++++ b/src/svgtiny_list.c
+@@ -11,6 +11,7 @@
+  */
+ 
+ #include <assert.h>
++#include <stdlib.h>
+ #include "svgtiny.h"
+ #include "svgtiny_internal.h"
+ 
+-- 
+2.50.1
+
Signature · 6 lines
2.50.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH v2 2/3 package/libsvgtiny: remove package

This package hasn't been updated in years. It has new releases, such as 1.0.8 from December 2023, but nobody updated to it.

Doing the version bump is not straightforward, and the original package submitter, Peter Korsgaard, is no longer using it. This package also had no reverse dependency, and no maintainer in the DEVELOPERS file.

Therefore, let's drop this package.

---
v1 -> v2: also drop from package/Config.in

 .checkpackageignore                           |   4 -
 package/Config.in                             |   1 -
 .../0001-disable-debug-printfs.patch          | 125 ------------------
 package/libsvgtiny/0002-Remove-Werror.patch   |  44 ------
 ...-inlines-and-non-inlines-calling-one.patch |  36 -----
 ...nclude-gperf-generated-code-directly.patch |  99 --------------
 ...ient-svgtiny_list-.c-add-missing-std.patch |  42 ------
 package/libsvgtiny/Config.in                  |   9 --
 package/libsvgtiny/libsvgtiny.hash            |   3 -
 package/libsvgtiny/libsvgtiny.mk              |  47 -------
 10 files changed, 410 deletions(-)
 delete mode 100644 package/libsvgtiny/0001-disable-debug-printfs.patch
 delete mode 100644 package/libsvgtiny/0002-Remove-Werror.patch
 delete mode 100644 package/libsvgtiny/0003-Hopefully-silence-warnings-about-inlines-and-non-inlines-calling-one.patch
 delete mode 100644 package/libsvgtiny/0004-Build-Include-gperf-generated-code-directly.patch
 delete mode 100644 package/libsvgtiny/0005-src-svgtiny_gradient-svgtiny_list-.c-add-missing-std.patch
 delete mode 100644 package/libsvgtiny/Config.in
 delete mode 100644 package/libsvgtiny/libsvgtiny.hash
 delete mode 100644 package/libsvgtiny/libsvgtiny.mk
.checkpackageignore +0 -4
index bc315b3640..fb63cf6a77 100644
@@ -653,10 +653,6 @@ package/libspatialindex/0002-CMakeLists.txt-fix-CMAKE_BUILD_TYPE.patch lib_patch
 package/libsquish/0001-Makefile-add-f-option-for-ln-to-remove-existing-dest.patch lib_patch.Upstream
 package/libsvg/0001-fix-expat-static-declaration.patch lib_patch.Upstream
 package/libsvg/0002-Fix-undefined-symbol-png_set_gray_1_2_4_to_8.patch lib_patch.Upstream
-package/libsvgtiny/0001-disable-debug-printfs.patch lib_patch.Upstream
-package/libsvgtiny/0002-Remove-Werror.patch lib_patch.Upstream
-package/libsvgtiny/0003-Hopefully-silence-warnings-about-inlines-and-non-inlines-calling-one.patch lib_patch.Upstream
-package/libsvgtiny/0004-Build-Include-gperf-generated-code-directly.patch lib_patch.Upstream
 package/libtalloc/0001-buildtools-wafsamba-add-disable-stack-protector-opti.patch lib_patch.Upstream
 package/libtelnet/0001-fix-compilation-without-zlib.patch lib_patch.Upstream
 package/libtheora/0001-link-libtheoradec.patch lib_patch.Upstream
package/Config.in +0 -1
index 137f74ed82..09f242e5db 100644
@@ -1783,7 +1783,6 @@ menu "Graphics"
 	source "package/librsvg/Config.in"
 	source "package/libsvg/Config.in"
 	source "package/libsvg-cairo/Config.in"
-	source "package/libsvgtiny/Config.in"
 	source "package/libva/Config.in"
 	source "package/libva-intel-driver/Config.in"
 	source "package/libvdpau/Config.in"
package/libsvgtiny/0001-disable-debug-printfs.patch deleted +0 -125

125 lines not on this page · raw message

package/libsvgtiny/0002-Remove-Werror.patch deleted +0 -44

44 lines not on this page · raw message

package/libsvgtiny/0003-Hopefully-silence-warnings-about-inlines-and-non-inlines-calling-one.patch deleted +0 -36
deleted file mode 100644
index 9285477d25..0000000000
@@ -1,36 +0,0 @@
-From 21b4836ac9d6c6725590a925daa5d17eda9843e9 Mon Sep 17 00:00:00 2001
-From: Daniel Silverstone <[email protected]>
-Date: Sat, 26 Apr 2014 16:24:54 +0100
-Subject: Hopefully silence warnings about inlines and non inlines calling one
- another.
-
-[Retrieved from:
-https://source.netsurf-browser.org/libsvgtiny.git/commit/src?id=21b4836ac9d6c6725590a925daa5d17eda9843e9]
-Signed-off-by: Fabrice Fontaine <[email protected]>
----
- src/colors.gperf | 9 +++++++++
- 1 file changed, 9 insertions(+)
-
-diff --git a/src/colors.gperf b/src/colors.gperf
-index 89152d2..96d5b9e 100644
---- a/src/colors.gperf
-+++ b/src/colors.gperf
-@@ -16,6 +16,15 @@
- #include <string.h>
- #include "svgtiny.h"
- #include "svgtiny_internal.h"
-+
-+/* This unusual define shennanigan is to try and prevent the gperf
-+ * generated function from being inlined.  This is pointless given
-+ * it (a) is in a separate .c file and (b) has external linkage.
-+ */
-+#ifdef __inline
-+#undef __inline
-+#define __inline
-+#endif
- %}
- 
- struct svgtiny_named_color;
--- 
-cgit v1.2.1
-
package/libsvgtiny/0004-Build-Include-gperf-generated-code-directly.patch deleted +0 -99

99 lines not on this page · raw message

package/libsvgtiny/0005-src-svgtiny_gradient-svgtiny_list-.c-add-missing-std.patch deleted +0 -42

42 lines not on this page · raw message

package/libsvgtiny/Config.in deleted +0 -9
deleted file mode 100644
index 836dec210e..0000000000
@@ -1,9 +0,0 @@
-config BR2_PACKAGE_LIBSVGTINY
-	bool "libsvgtiny"
-	select BR2_PACKAGE_LIBXML2
-	help
-	  Libsvgtiny is an implementation of SVG Tiny, written in C.
-	  It is currently in development for use with NetSurf and is
-	  intended to be suitable for use in other projects too.
-
-	  http://www.netsurf-browser.org/projects/libsvgtiny/
package/libsvgtiny/libsvgtiny.hash deleted +0 -3
deleted file mode 100644
index 55f4093e19..0000000000
@@ -1,3 +0,0 @@
-# Locally computed
-sha256  758641d339b324a76294ef08e323faa2cefb557793f437c08af7deb3b73a453e  libsvgtiny-ea9d99fc8b231c22d06168135e181d61f4eb2f06-git4.tar.gz
-sha256  92b965c77be71661cae51425a6b40a5ca274f44cc13c723c90fb471a9a26a828  README
package/libsvgtiny/libsvgtiny.mk deleted +0 -47

47 lines not on this page · raw message

Signature · 6 lines
2.50.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH v2 2/3] package/libsvgtiny: remove package

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni via buildroot <[email protected]> writes:

This package hasn't been updated in years. It has new releases, such as 1.0.8 from December 2023, but nobody updated to it.

Doing the version bump is not straightforward, and the original package submitter, Peter Korsgaard, is no longer using it. This package also had no reverse dependency, and no maintainer in the DEVELOPERS file.

Quoted 5 lines

Therefore, let's drop this package.

---
v1 -> v2: also drop from package/Config.in

Committed after adding a Config.in.legacy entry (and not for the host-only buildsystem), thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

PATCH v2 3/3 package/netsurf-buildsystem: remove package

In reply to Thomas Petazzoni via buildroot

This host package was only used as a build dependency of libsvgtiny, which itself has been removed, so it can be dropped as well.

---
v1 -> v2: No changes.

 DEVELOPERS                                    |  3 ---
 .../netsurf-buildsystem.hash                  |  3 ---
 .../netsurf-buildsystem.mk                    | 20 -------------------
 3 files changed, 26 deletions(-)
 delete mode 100644 package/netsurf-buildsystem/netsurf-buildsystem.hash
 delete mode 100644 package/netsurf-buildsystem/netsurf-buildsystem.mk
DEVELOPERS +0 -3
index 762cd6d430..9fbdace7c1 100644
@@ -1001,9 +1001,6 @@ F:	package/atest/
 F:	package/crucible/
 F:	package/kmscube/
 
-N:	Fabio Porcedda <[email protected]>
-F:	package/netsurf-buildsystem/
-
 N:	Fabio Urquiza <[email protected]>
 F:	package/bitcoin/
 
package/netsurf-buildsystem/netsurf-buildsystem.hash deleted +0 -3
deleted file mode 100644
index 9da8c67aef..0000000000
@@ -1,3 +0,0 @@
-# Locally computed
-sha256  b8620c6a95ccf071046cdb8e4e0ca149cdd58d292eb9ee02b3b0d63646466b72  netsurf-buildsystem-7574b41345968b5f7e9ca5875faccb1478ce0555-git4.tar.gz
-sha256  b2ddc1d607332423f6cf415b2ac619a1c03dd565facdc39a571282a520929a65  llvm/LICENSE.TXT
package/netsurf-buildsystem/netsurf-buildsystem.mk deleted +0 -20
deleted file mode 100644
index d4efec0e1d..0000000000
@@ -1,20 +0,0 @@
-################################################################################
-#
-# netsurf-buildsystem
-#
-################################################################################
-
-NETSURF_BUILDSYSTEM_VERSION = 7574b41345968b5f7e9ca5875faccb1478ce0555
-NETSURF_BUILDSYSTEM_SITE = http://git.netsurf-browser.org/buildsystem.git
-NETSURF_BUILDSYSTEM_SITE_METHOD = git
-NETSURF_BUILDSYSTEM_LICENSE = MIT, BSD-3-Clause (for llvm/* files)
-NETSURF_BUILDSYSTEM_LICENSE_FILES = llvm/LICENSE.TXT
-
-NETSURF_BUILDSYSTEM_INSTALL_DIR = $(HOST_DIR)/share/netsurf-buildsystem
-
-define HOST_NETSURF_BUILDSYSTEM_INSTALL_CMDS
-	mkdir -p $(NETSURF_BUILDSYSTEM_INSTALL_DIR)
-	cp -dpfr $(@D)/* $(NETSURF_BUILDSYSTEM_INSTALL_DIR)
-endef
-
-$(eval $(host-generic-package))
Signature · 6 lines
2.50.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

Re: [Buildroot] [PATCH v2 3/3] package/netsurf-buildsystem: remove package

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni via buildroot <[email protected]> writes:

This host package was only used as a build dependency of libsvgtiny, which itself has been removed, so it can be dropped as well.

---
v1 -> v2: No changes.

Committed after adding a Config.in.legacy entry, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#5 lore raw
In reply to Thomas Petazzoni via buildroot
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni via buildroot <[email protected]> writes:

Add a small, easily backportable patch to fix GCC 15.x build issue. The issue is also fixed upstream in later releases, but this patch is a minimal fix that can be backported to LTS independently from a version bump.

Quoted 7 lines

Fixes:

https://autobuild.buildroot.org/results/c3d703663faabe40448d908afbdbb351a016aece/

---
v1 -> v2: no changes

Committed, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot