Skip to contentSkip to conversation

ALSA: hda/cirrus_scodec_test: Don't select dependencies

PATCH Applied Richard Fitzgerald 2 participants 2 messages Apr 9, 2025 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda/cirrus_scodec_test: Don't select dependencies

Depend on SND_HDA_CIRRUS_SCODEC and GPIOLIB instead of selecting them.

KUNIT_ALL_TESTS should only build tests that have satisfied dependencies and test components that are already being built. It must not cause other stuff to be added to the build.

Fixes 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test")
---
 sound/pci/hda/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
sound/pci/hda/Kconfig +1 -3
index fb955a205d50..9c427270ff4f 100644
@@ -96,9 +96,7 @@ config SND_HDA_CIRRUS_SCODEC
 
 config SND_HDA_CIRRUS_SCODEC_KUNIT_TEST
 	tristate "KUnit test for Cirrus side-codec library" if !KUNIT_ALL_TESTS
-	select SND_HDA_CIRRUS_SCODEC
-	select GPIOLIB
-	depends on KUNIT
+	depends on SND_HDA_CIRRUS_SCODEC && GPIOLIB && KUNIT
 	default KUNIT_ALL_TESTS
 	help
 	  This builds KUnit tests for the cirrus side-codec library.
Signature · 1 line
2.39.5
Applied
#1 lore raw
Quoted 9 lines · Richard Fitzgerald

Depend on SND_HDA_CIRRUS_SCODEC and GPIOLIB instead of selecting them.

KUNIT_ALL_TESTS should only build tests that have satisfied dependencies and test components that are already being built. It must not cause other stuff to be added to the build.

Fixes 2144833e7b41 ("ALSA: hda: cirrus_scodec: Add KUnit test")

Thanks, applied now.

Takashi