Skip to contentSkip to conversation

wrong channel ids for surround

PATCH In review Sylvain BERTRAND 2 participants 4 messages Jul 31, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wrong channel ids for surround

Hi,

In the USB audio class 1 specifications, page 33 (3.7.2.3 Audio Channel Cluster Format):

Surround is spatially defined as [rear], hence left surround should be SNDRV_CHMAP_RL and not SND_CHMAP_SL (Side). Same for right surround channel.

Right?

I am not a mailing list subscriber, CC me please.

regards,

Signature · 16 lines
Sylvain BERTRAND


--- a/sound/usb/stream.c
+++ b/sound/usb/stream.c
@@ -244,8 +244,8 @@ static struct snd_pcm_chmap_elem *convert_chmap(int channels, unsigned int bits,
 		SNDRV_CHMAP_FR,		/* right front */
 		SNDRV_CHMAP_FC,		/* center front */
 		SNDRV_CHMAP_LFE,	/* LFE */
-		SNDRV_CHMAP_SL,		/* left surround */
-		SNDRV_CHMAP_SR,		/* right surround */
+		SNDRV_CHMAP_RL,		/* left surround */
+		SNDRV_CHMAP_RR,		/* right surround */
 		SNDRV_CHMAP_FLC,	/* left of center */
 		SNDRV_CHMAP_FRC,	/* right of center */
 		SNDRV_CHMAP_RC,		/* surround */
#1 lore raw
Quoted 9 lines · Sylvain BERTRAND

Hi,

In the USB audio class 1 specifications, page 33 (3.7.2.3 Audio Channel Cluster Format):

Surround is spatially defined as [rear], hence left surround should be SNDRV_CHMAP_RL and not SND_CHMAP_SL (Side). Same for right surround channel.

Right?

Yes, this looks rather like a typo, SL/SR appear twice there.

Quoted 4 lines

I am not a mailing list subscriber, CC me please.

regards,

Could you submit a properly formatted patch (with a patch description and your Signed-off-by tag) to linux-sound ML ([email protected]) instead?

thanks,

Takashi

Quoted 19 lines
Signature · 2 lines
-- 
Sylvain BERTRAND
sound/usb/stream.c +2 -2
@@ -244,8 +244,8 @@ static struct snd_pcm_chmap_elem *convert_chmap(int channels, unsigned int bits,
 		SNDRV_CHMAP_FR,		/* right front */
 		SNDRV_CHMAP_FC,		/* center front */
 		SNDRV_CHMAP_LFE,	/* LFE */
-		SNDRV_CHMAP_SL,		/* left surround */
-		SNDRV_CHMAP_SR,		/* right surround */
+		SNDRV_CHMAP_RL,		/* left surround */
+		SNDRV_CHMAP_RR,		/* right surround */
 		SNDRV_CHMAP_FLC,	/* left of center */
 		SNDRV_CHMAP_FRC,	/* right of center */
 		SNDRV_CHMAP_RC,		/* surround */
#2 lore raw
Quoted 3 lines · Takashi Iwai

Could you submit a properly formatted patch (with a patch description and your Signed-off-by tag) to linux-sound ML ([email protected]) instead?

Hi,

I tried to send that patch to the lkml, but some admins removed grey listing and I use a domestic smtp server (with DNS SPF though), then I was blocked.

(I don't use only noscript/basic (x)html browsers, then "Big Tech" email services are not available for me)

(I have a github account, and github is still working with noscript/basic (x)html... as for now... then I did report an issue there)

If you have time and accept to do it, I don't mind you or somebody else doing that on my behalf. What matters is this being fixed I guess.

best regards,

Signature · 1 line
Sylvain
#3 lore raw
Quoted 11 lines · Sylvain BERTRAND
Quoted 3 lines · Takashi Iwai

Could you submit a properly formatted patch (with a patch description and your Signed-off-by tag) to linux-sound ML ([email protected]) instead?

Hi,

I tried to send that patch to the lkml, but some admins removed grey listing and I use a domestic smtp server (with DNS SPF though), then I was blocked.

Quoted 8 lines

(I don't use only noscript/basic (x)html browsers, then "Big Tech" email services are not available for me)

(I have a github account, and github is still working with noscript/basic (x)html... as for now... then I did report an issue there)

If you have time and accept to do it, I don't mind you or somebody else doing that on my behalf. What matters is this being fixed I guess.

OK, as the fix is trivial, I'll submit and merge it.

thanks,

Takashi