ALSA: hda: cs35l56: Enable low-power hibernation mode on SPI
PATCH 1/1 ALSA: hda: cs35l56: Enable low-power hibernation mode on SPI
SPI hibernation is now supported with the latest hibernation/wake sequences in the shared ASoC code.
This has a functional dependency on two commits:
commit 3df761bdbc8b ("ASoC: cs35l56: Wake transactions need to be issued twice")
commit a47cf4dac7dc ("ASoC: cs35l56: Change hibernate sequence to use allow auto hibernate")
To protect against this, enabling hibernation is conditional on CS35L56_WAKE_HOLD_TIME_US being defined, which indicates that the new hibernation sequences are available.
--- sound/pci/hda/cs35l56_hda_spi.c | 4 ++++ 1 file changed, 4 insertions(+)
sound/pci/hda/cs35l56_hda_spi.c +4 -0
@@ -21,6 +21,10 @@ static int cs35l56_hda_spi_probe(struct spi_device *spi)return -ENOMEM ; cs35l56->base.dev = &spi->dev; + +#ifdef CS35L56_WAKE_HOLD_TIME_US + cs35l56->base.can_hibernate = true; +#endif cs35l56->base.regmap =devm_regmap_init_spi (spi, &cs35l56_regmap_spi);if (IS_ERR (cs35l56->base.regmap)) { ret =PTR_ERR (cs35l56->base.regmap);
Signature · 1 line
2.30.2
Quoted 9 lines · Richard Fitzgerald
SPI hibernation is now supported with the latest hibernation/wake sequences in the shared ASoC code.
This has a functional dependency on two commits:
commit
3df761bdbc8b("ASoC: cs35l56: Wake transactions need to be issued twice")
Quoted 8 lines
commit
a47cf4dac7dc("ASoC: cs35l56: Change hibernate sequence to use allow auto hibernate")To protect against this, enabling hibernation is conditional on
CS35L56_WAKE_HOLD_TIME_USbeing defined, which indicates that the new hibernation sequences are available.Signed-off-by Richard Fitzgerald <[email protected]>
Is this expected to be merged for 6.7? Or it can be post 6.7? I guess the former, but just to make sure.
thanks,
Takashi
Quoted 14 lines · Takashi Iwai
Quoted 12 lines · Richard Fitzgerald
SPI hibernation is now supported with the latest hibernation/wake sequences in the shared ASoC code.
This has a functional dependency on two commits:
commit
3df761bdbc8b("ASoC: cs35l56: Wake transactions need to be issued twice")commit
a47cf4dac7dc("ASoC: cs35l56: Change hibernate sequence to use allow auto hibernate")
Quoted 9 lines
Quoted 5 lines
To protect against this, enabling hibernation is conditional on
CS35L56_WAKE_HOLD_TIME_USbeing defined, which indicates that the new hibernation sequences are available.Signed-off-by Richard Fitzgerald <[email protected]>Is this expected to be merged for 6.7? Or it can be post 6.7? I guess the former, but just to make sure.
It would be good to get it into 6.7 because it reduces the power consumption in runtime-suspend and suspend-to-RAM. But it's not critical (it's not a bugfix).
Quoted 4 lines
thanks,
Takashi
Quoted 22 lines · Richard Fitzgerald
Quoted 20 lines · Takashi Iwai
Quoted 17 lines · Richard Fitzgerald
SPI hibernation is now supported with the latest hibernation/wake sequences in the shared ASoC code.
This has a functional dependency on two commits:
commit
3df761bdbc8b("ASoC: cs35l56: Wake transactions need to be issued twice")commit
a47cf4dac7dc("ASoC: cs35l56: Change hibernate sequence to use allow auto hibernate")To protect against this, enabling hibernation is conditional on
CS35L56_WAKE_HOLD_TIME_USbeing defined, which indicates that the new hibernation sequences are available.Signed-off-by Richard Fitzgerald <[email protected]>
Quoted 7 lines
Quoted 3 lines
Is this expected to be merged for 6.7? Or it can be post 6.7? I guess the former, but just to make sure.
It would be good to get it into 6.7 because it reduces the power consumption in runtime-suspend and suspend-to-RAM. But it's not critical (it's not a bugfix).
OK, now applied to for-linus branch (for 6.7).
thanks,
Takashi