irqchip: mtk-sysirq: Skip setting irq-wake
Subsystems (2)
PATCH 1/1 irqchip: mtk-sysirq: Skip setting irq-wake
mtk-sysirq doesn't require specific logic to work with wakeup IRQs. To allow registered IRQs to be used as a wakeup-source, add the flag IRQCHIP_SKIP_SET_WAKE.
--- drivers/irqchip/irq-mtk-sysirq.c | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/irq-mtk-sysirq.c +1 -0
@@ -65,6 +65,7 @@ static struct irq_chip mtk_sysirq_chip = { .irq_set_type = mtk_sysirq_set_type, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_affinity = irq_chip_set_affinity_parent, + .flags = IRQCHIP_SKIP_SET_WAKE, }; static int mtk_sysirq_domain_translate(struct irq_domain *d,
Signature · 7 lines
2.32.0 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hi Markus,
Quoted 15 lines · Markus Schneider-Pargmann
mtk-sysirq doesn't require specific logic to work with wakeup IRQs. To allow registered IRQs to be used as a wakeup-source, add the flag
IRQCHIP_SKIP_SET_WAKE.Signed-off-by Markus Schneider-Pargmann <[email protected]>--- drivers/irqchip/irq-mtk-sysirq.c | 1 + 1 file changed, 1 insertion(+)drivers/irqchip/irq-mtk-sysirq.c +0
-0
drivers/irqchip/irq-mtk-sysirq.c static struct irq_chip mtk_sysirq_chip = { · line 71
Quoted 7 lines
drivers/irqchip/irq-mtk-sysirq.c +1
-0@@ -65,6 +65,7 @@ static struct irq_chip mtk_sysirq_chip = { .irq_set_type = mtk_sysirq_set_type, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_affinity = irq_chip_set_affinity_parent, + .flags = IRQCHIP_SKIP_SET_WAKE, }; static int mtk_sysirq_domain_translate(struct irq_domain *d,
Is this a fix? If so, please provide a Fixes: tag matching the commit it addresses. Add a Cc stable if this requires backporting.
Thanks,
M.
Signature · 6 lines
Without deviation from the norm, progress is not possible. _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hi Marc,
Quoted 25 lines · Marc Zyngier
Hi Markus,
Quoted 21 lines · Markus Schneider-Pargmann
mtk-sysirq doesn't require specific logic to work with wakeup IRQs. To allow registered IRQs to be used as a wakeup-source, add the flag
IRQCHIP_SKIP_SET_WAKE.Signed-off-by Markus Schneider-Pargmann <[email protected]>--- drivers/irqchip/irq-mtk-sysirq.c | 1 + 1 file changed, 1 insertion(+)drivers/irqchip/irq-mtk-sysirq.c +1
-0@@ -65,6 +65,7 @@ static struct irq_chip mtk_sysirq_chip = { .irq_set_type = mtk_sysirq_set_type, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_affinity = irq_chip_set_affinity_parent, + .flags = IRQCHIP_SKIP_SET_WAKE, };
Quoted 4 lines
drivers/irqchip/irq-mtk-sysirq.c static struct irq_chip mtk_sysirq_chip = { · line 71
Quoted 1 line
drivers/irqchip/irq-mtk-sysirq.c +0
-0static int mtk_sysirq_domain_translate(struct irq_domain *d,Is this a fix? If so, please provide a Fixes: tag matching the commit it addresses. Add a Cc stable if this requires backporting.
At least from my point of view I would like to prepare the mtk-sysirq for powermanagement stuff, so not a fix. There may be some components trying to use this already but I would consider this more of a feature as it has probably never worked before.
Currently calls to enable_irq_wake() using IRQs of sysirq will result in -ENXIO.
Thanks,
Markus
Quoted 7 lines
Thanks,
M.Signature · 1 line
Without deviation from the norm, progress is not possible.
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 34 lines · Markus Schneider-Pargmann
Hi Marc,
Quoted 25 lines · Marc Zyngier
Hi Markus,
Quoted 21 lines · Markus Schneider-Pargmann
mtk-sysirq doesn't require specific logic to work with wakeup IRQs. To allow registered IRQs to be used as a wakeup-source, add the flag
IRQCHIP_SKIP_SET_WAKE.Signed-off-by Markus Schneider-Pargmann <[email protected]>--- drivers/irqchip/irq-mtk-sysirq.c | 1 + 1 file changed, 1 insertion(+)drivers/irqchip/irq-mtk-sysirq.c +1
-0@@ -65,6 +65,7 @@ static struct irq_chip mtk_sysirq_chip = { .irq_set_type = mtk_sysirq_set_type, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_affinity = irq_chip_set_affinity_parent, + .flags = IRQCHIP_SKIP_SET_WAKE, };Quoted 4 lines
drivers/irqchip/irq-mtk-sysirq.c static struct irq_chip mtk_sysirq_chip = { · line 71
Quoted 1 line
drivers/irqchip/irq-mtk-sysirq.c +0
-0static int mtk_sysirq_domain_translate(struct irq_domain *d,Is this a fix? If so, please provide a Fixes: tag matching the commit it addresses. Add a Cc stable if this requires backporting.
Quoted 4 lines
At least from my point of view I would like to prepare the mtk-sysirq for powermanagement stuff, so not a fix. There may be some components trying to use this already but I would consider this more of a feature as it has probably never worked before.
Fair enough. I'll keep that for 5.15 then.
Thanks,
M.
Signature · 6 lines
Without deviation from the norm, progress is not possible. _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
[irqchip: irq/irqchip-next] irqchip/mtk-sysirq: Skip setting irq-wake
In reply to Markus Schneider-PargmannThe following commit has been merged into the irq/irqchip-next branch of irqchip:
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: c775626fb3379f0c7c21925743104aeae6d2f8b1 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/c775626fb3379f0c7c21925743104aeae6d2f8b1 Author: Markus Schneider-Pargmann <[email protected]> AuthorDate: Wed, 07 Jul 2021 08:20:04 +02:00 Committer: Marc Zyngier <[email protected]> CommitterDate: Thu, 12 Aug 2021 08:15:15 +01:00
irqchip/mtk-sysirq: Skip setting irq-wake
mtk-sysirq doesn't require specific logic to work with wakeup IRQs. To allow registered IRQs to be used as a wakeup-source, add the flag IRQCHIP_SKIP_SET_WAKE.
--- drivers/irqchip/irq-mtk-sysirq.c | 1 + 1 file changed, 1 insertion(+)
drivers/irqchip/irq-mtk-sysirq.c +1 -0
@@ -65,6 +65,7 @@ static struct irq_chip mtk_sysirq_chip = { .irq_set_type = mtk_sysirq_set_type, .irq_retrigger = irq_chip_retrigger_hierarchy, .irq_set_affinity = irq_chip_set_affinity_parent, + .flags = IRQCHIP_SKIP_SET_WAKE, }; static int mtk_sysirq_domain_translate(struct irq_domain *d,