Skip to contentSkip to conversation

package/gesftpserver: Add host-python as dependency

PATCH New Andreas Naumann 5 participants 8 messages Jun 23, 2021 – Jul 3, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gesftpserver: Add host-python as dependency

gesftpserver needs python for the configure step.

---
 package/gesftpserver/gesftpserver.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/gesftpserver/gesftpserver.mk +1 -1
index 85511a3c97..c67fdb3f79 100644
@@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver
 GESFTPSERVER_CONF_ENV = LIBS=-lpthread
 
 # overwrite openssh version if enabled
-GESFTPSERVER_DEPENDENCIES += \
+GESFTPSERVER_DEPENDENCIES += host-python \
 	$(if $(BR2_ENABLE_LOCALE),,libiconv) \
 	$(if $(BR2_PACKAGE_OPENSSH),openssh)
 
Signature · 1 line
2.32.0
#1 lore raw

PATCH 1/1 package/gesftpserver: Add host-python as dependency

Hi Andreas,

Quoted 12 lines · Andreas Naumann

gesftpserver needs python for the configure step.

---
 package/gesftpserver/gesftpserver.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/gesftpserver/gesftpserver.mk +0 -0
index 85511a3c97..c67fdb3f79 100644

package/gesftpserver/gesftpserver.mk GESFTPSERVER_CPE_ID_PRODUCT = sftpserver · line 22

Quoted 5 lines
package/gesftpserver/gesftpserver.mk +1 -1
@@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver
 GESFTPSERVER_CONF_ENV = LIBS=-lpthread
 
 # overwrite openssh version if enabled
-GESFTPSERVER_DEPENDENCIES += \
+GESFTPSERVER_DEPENDENCIES += host-python \

Does host-python3 also work? We would probably drop python2 in the near future.

baruch

Quoted 2 lines
package/gesftpserver/gesftpserver.mk +0 -0
 	$(if $(BR2_ENABLE_LOCALE),,libiconv) \
 	$(if $(BR2_PACKAGE_OPENSSH),openssh)
Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 package/gesftpserver: Add host-python as dependency

Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Hi Andreas,

Quoted 14 lines · Andreas Naumann

gesftpserver needs python for the configure step.

---
package/gesftpserver/gesftpserver.mk | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
package/gesftpserver/gesftpserver.mk +0 -0
index 85511a3c97..c67fdb3f79 100644
@@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver

GESFTPSERVER_CONF_ENV = LIBS=-lpthread

Quoted 6 lines

package/gesftpserver/gesftpserver.mk GESFTPSERVER_CPE_ID_PRODUCT = sftpserver · line 22

Quoted 3 lines
# overwrite openssh version if enabled
package/gesftpserver/gesftpserver.mk +1 -1
-GESFTPSERVER_DEPENDENCIES += \
+GESFTPSERVER_DEPENDENCIES += host-python \

Does host-python3 also work? We would probably drop python2 in the near future.

Exactly. Looking at it, python also only seems to be used for the tests that we do not need to run, so it is a bit silly to have to pull in host-python3.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 package/gesftpserver: Add host-python as dependency

Hi,

Quoted 18 lines · Peter Korsgaard
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Hi Andreas,

Quoted 14 lines · Andreas Naumann

gesftpserver needs python for the configure step.

---
package/gesftpserver/gesftpserver.mk | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
package/gesftpserver/gesftpserver.mk +0 -0
index 85511a3c97..c67fdb3f79 100644
@@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver

GESFTPSERVER_CONF_ENV = LIBS=-lpthread

Quoted 6 lines
Quoted 6 lines

package/gesftpserver/gesftpserver.mk GESFTPSERVER_CPE_ID_PRODUCT = sftpserver · line 22

Quoted 3 lines
# overwrite openssh version if enabled
package/gesftpserver/gesftpserver.mk +1 -1
-GESFTPSERVER_DEPENDENCIES += \
+GESFTPSERVER_DEPENDENCIES += host-python \

Does host-python3 also work? We would probably drop python2 in the near future.

So I just tried and yes, host-python3 does the job.

Quoted 4 lines

Exactly. Looking at it, python also only seems to be used for the tests that we do not need to run, so it is a bit silly to have to pull in host-python3.

Ok, i didnt look why Python is needed. Also, I never saw the problem until using per-package build. So buildtime-wise it's not a problem in my case because we pull in host-python for some other package anyway.

I will check if I can get rid of the tests though.

regards,
Andreas

Quoted 1 line
#4 lore raw

PATCH 1/1 package/gesftpserver: Add host-python as dependency

Hi

Quoted 37 lines · Andreas Naumann

Hi,

Quoted 23 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

? > Hi Andreas,
? > On Wed, Jun 23 2021, Andreas Naumann wrote:
? >> gesftpserver needs python for the configure step. ? >>
? >> Signed-off-by: Andreas Naumann <[email protected]> ? >> ---
? >> package/gesftpserver/gesftpserver.mk | 2 +-
? >> 1 file changed, 1 insertion(+), 1 deletion(-)
? >>
? >> diff --git a/package/gesftpserver/gesftpserver.mk b/package/gesftpserver/gesftpserver.mk
? >> index 85511a3c97..c67fdb3f79 100644
? >> --- a/package/gesftpserver/gesftpserver.mk
? >> +++ b/package/gesftpserver/gesftpserver.mk
? >> @@ -19,7 +19,7 @@ GESFTPSERVER_CPE_ID_PRODUCT = sftpserver ? >> GESFTPSERVER_CONF_ENV = LIBS=-lpthread
? >>
? >> # overwrite openssh version if enabled
? >> -GESFTPSERVER_DEPENDENCIES += \
? >> +GESFTPSERVER_DEPENDENCIES += host-python \

Quoted 3 lines

? > Does host-python3 also work? We would probably drop python2 in the near
? > future.

So I just tried and yes, host-python3 does the job.

Quoted 4 lines

Exactly. Looking at it, python also only seems to be used for the tests that we do not need to run, so it is a bit silly to have to pull in host-python3.

Quoted 5 lines

Ok, i didnt look why Python is needed. Also, I never saw the problem until using per-package build. So buildtime-wise it's not a problem in my case because we pull in host-python for some other package anyway.

I will check if I can get rid of the tests though.

... The configure script does not provide an option to skip test, so I could patch the configure script or somehow fake that python is there even if it doesnt. Both solutions seem not very elegant to so if you agree I'd just repost the patch with host-python3 as dependency.

regards,
Andreas

Quoted 10 lines

regards,
Andreas

Quoted 1 line

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#5 lore raw

PATCH 1/1 package/gesftpserver: Add host-python as dependency

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Andreas" == Andreas Naumann <[email protected]> writes:

Hi,

Quoted 11 lines
Quoted 6 lines

Ok, i didnt look why Python is needed. Also, I never saw the problem until using per-package build. So buildtime-wise it's not a problem in my case because we pull in host-python for some other package anyway.

I will check if I can get rid of the tests though.

... The configure script does not provide an option to skip test, so I could patch the configure script or somehow fake that python is there even if it doesnt. Both solutions seem not very elegant to so if you agree I'd just repost the patch with host-python3 as dependency.

A simple hack would just to pass rjk_cv_python24=true in GESFTPSERVER_CONF_ENV.

The tests themselves are afaik only executed if you run 'make check' (which we don't).

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/1 package/gesftpserver: Add host-python as dependency

Hi Peter,

Quoted 11 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Andreas" == Andreas Naumann <[email protected]> writes:

Hi,

Quoted 6 lines
Quoted 6 lines

Ok, i didnt look why Python is needed. Also, I never saw the problem until using per-package build. So buildtime-wise it's not a problem in my case because we pull in host-python for some other package anyway.

I will check if I can get rid of the tests though.

Quoted 7 lines
Quoted 4 lines

... The configure script does not provide an option to skip test, so I could patch the configure script or somehow fake that python is there even if it doesnt. Both solutions seem not very elegant to so if you agree I'd just repost the patch with host-python3 as dependency.

A simple hack would just to pass rjk_cv_python24=true in GESFTPSERVER_CONF_ENV.

just send v2 with your suggestion, but slightly altered because telling configure that Python is not there also works.

regards,
Andreas

Quoted 4 lines

The tests themselves are afaik only executed if you run 'make check' (which we don't).

#7 lore raw

PATCH 1/1 package/gesftpserver: Add host-python as dependency

In reply to Andreas Naumann
Quoted 6 lines · On Wed, 23 Jun 2021 10:36:34 +0200 Andreas Naumann <[email protected]>…

gesftpserver needs python for the configure step.

---
 package/gesftpserver/gesftpserver.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I've marked as Changes Requested in patchwork, since you posted v2, and I have already applied v2.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com