Skip to contentSkip to conversation

package/gerbera: fix linking with std::filesystem

PATCH New Fabrice Fontaine 3 participants 5 messages Jan 26, 2021 – Jan 28, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/gerbera: fix linking with std::filesystem

Do not force to CXX_FILESYSTEM_NO_LINK_NEEDED to ON to allow gerbera to link with the approriate library for std::filesystem

It should be noted that check_cxx_source_runs has been dropped since version 1.6.0 and
https://github.com/gerbera/gerbera/commit/a3a64bed1d78fc51c7ab298db019c89852acb80c

Fixes:
- http://autobuild.buildroot.org/results/0fcd0ce167c04f788bf1b9414ae5e7677691c7cf

---
 package/gerbera/gerbera.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
package/gerbera/gerbera.mk +1 -2
index 9468def041..6e36377798 100644
@@ -18,8 +18,7 @@ GERBERA_DEPENDENCIES = \
 	zlib
 GERBERA_CONF_OPTS = \
 	-DWITH_DEBUG=OFF \
-	-DWITH_JS=OFF \
-	-DCXX_FILESYSTEM_NO_LINK_NEEDED=ON
+	-DWITH_JS=OFF
 
 # Uses __atomic_fetch_add_4
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
Signature · 1 line
2.29.2
#1 lore raw

PATCH 2/2 package/gerbera: needs xpath in pugixml

Fixes:
- http://autobuild.buildroot.org/results/0fcd0ce167c04f788bf1b9414ae5e7677691c7cf

---
 package/gerbera/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/gerbera/Config.in +1 -0
index 5025b3753f..a07bcc5c57 100644
@@ -10,6 +10,7 @@ config BR2_PACKAGE_GERBERA
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	select BR2_PACKAGE_LIBUPNP if !BR2_PACKAGE_LIBNPUPNP
 	select BR2_PACKAGE_PUGIXML
+	select BR2_PACKAGE_PUGIXML_XPATH_SUPPORT
 	select BR2_PACKAGE_SPDLOG
 	select BR2_PACKAGE_SQLITE
 	select BR2_PACKAGE_UTIL_LINUX
Signature · 1 line
2.29.2
#3 lore raw

PATCH 1/2 package/gerbera: fix linking with std::filesystem

In reply to Fabrice Fontaine

Fabrice, All,

On 2021-01-26 18:25 +0100, Fabrice Fontaine spake thusly:

Quoted 11 lines

Do not force to CXX_FILESYSTEM_NO_LINK_NEEDED to ON to allow gerbera to link with the approriate library for std::filesystem

It should be noted that check_cxx_source_runs has been dropped since version 1.6.0 and
https://github.com/gerbera/gerbera/commit/a3a64bed1d78fc51c7ab298db019c89852acb80c

Fixes:
- http://autobuild.buildroot.org/results/0fcd0ce167c04f788bf1b9414ae5e7677691c7cf

Series of 2 applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/gerbera/gerbera.mk | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
package/gerbera/gerbera.mk +1 -2
index 9468def041..6e36377798 100644
@@ -18,8 +18,7 @@ GERBERA_DEPENDENCIES = \
 	zlib
 GERBERA_CONF_OPTS = \
 	-DWITH_DEBUG=OFF \
-	-DWITH_JS=OFF \
-	-DCXX_FILESYSTEM_NO_LINK_NEEDED=ON
+	-DWITH_JS=OFF
 
 # Uses __atomic_fetch_add_4
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
Signature · 6 lines
2.29.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/2 package/gerbera: fix linking with std::filesystem

In reply to Fabrice Fontaine
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Do not force to CXX_FILESYSTEM_NO_LINK_NEEDED to ON to allow gerbera to link with the approriate library for std::filesystem

Quoted 8 lines

It should be noted that check_cxx_source_runs has been dropped since version 1.6.0 and
https://github.com/gerbera/gerbera/commit/a3a64bed1d78fc51c7ab298db019c89852acb80c

Fixes:
- http://autobuild.buildroot.org/results/0fcd0ce167c04f788bf1b9414ae5e7677691c7cf

Committed to 2020.02.x and 2020.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard