Skip to contentSkip to conversation

package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling

PATCH New Peter Seiderer 4 participants 4 messages Nov 17, 2020 – Dec 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling

Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from 'depends on BR2_m68k' to 'depends on !BR2_m68k'.

---
 package/libcamera/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libcamera/Config.in +1 -1
index aadea56d19..b9c243084e 100644
@@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
 	bool
 	default y
 	# Invalid packing size of ControlValue struct on m68k
-	depends on BR2_m68k
+	depends on !BR2_m68k
 
 menuconfig BR2_PACKAGE_LIBCAMERA
 	bool "libcamera"
Signature · 1 line
2.29.2
#1 lore raw

PATCH 1/1 package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling

Hi Peter,

Quoted 13 lines · Peter Seiderer

Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from 'depends on BR2_m68k' to 'depends on !BR2_m68k'.

---
 package/libcamera/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libcamera/Config.in +0 -0
index aadea56d19..b9c243084e 100644

package/libcamera/Config.in config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS · line 5

Quoted 5 lines
package/libcamera/Config.in +1 -1
@@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
 	bool
 	default y
 	# Invalid packing size of ControlValue struct on m68k
-	depends on BR2_m68k
+	depends on !BR2_m68k

Oh dear, this was definitely negated in the patch I submitted [0], but looks like it landed as this in [1], which was incorrect.

[0]
https://lists.libcamera.org/pipermail/libcamera-devel/2020-September/012519.html

[1]
https://git.buildroot.net/buildroot/commit/?id=66526e3518e01a3fe16dede165c7890d194b7816

Fix looks good to me.

Quoted 4 lines
package/libcamera/Config.in +0 -0
 menuconfig BR2_PACKAGE_LIBCAMERA
 	bool "libcamera"
 
Signature · 3 lines
Regards
--
Kieran
#2 lore raw

PATCH 1/1 package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling

In reply to Peter Seiderer

Peter, All,

On 2020-11-17 22:25 +0100, Peter Seiderer spake thusly:

Quoted 2 lines

Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from 'depends on BR2_m68k' to 'depends on !BR2_m68k'.

Uh-oh... My bad...

Quoted 1 line

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 20 lines
---
 package/libcamera/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libcamera/Config.in +1 -1
index aadea56d19..b9c243084e 100644
@@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS
 	bool
 	default y
 	# Invalid packing size of ControlValue struct on m68k
-	depends on BR2_m68k
+	depends on !BR2_m68k
 
 menuconfig BR2_PACKAGE_LIBCAMERA
 	bool "libcamera"
Signature · 1 line
2.29.2
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/libcamera: fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling

In reply to Peter Seiderer
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Seiderer <[email protected]> writes:

Fix BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS handling, change from 'depends on BR2_m68k' to 'depends on !BR2_m68k'.

Committed to 2020.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard