irqdomain: fix -Wshadow warning
Subsystems (23)
PATCH 1/1 irqdomain: fix -Wshadow warning
From: Arnd Bergmann <[email protected]>
When building with W=2, there are tons of warnings about conflicting local and global definitions of 'nr_irqs' in common header files:
include/linux/irqdomain.h: In function 'irq_domain_alloc_irqs':include/linux/irqdomain.h:482:17: warning: declaration of 'nr_irqs' shadows a global declaration [-Wshadow]
482 | unsigned int nr_irqs, int node, void *arg)
| ~~~~~~~~~~~~~^~~~~~~
In file included from ../include/linux/interrupt.h:10,
from ../include/linux/kernel_stat.h:9,
from ../include/linux/cgroup.h:26,
from ../include/linux/perf_event.h:57,
from ../include/linux/trace_events.h:10,
from ../include/trace/syscall.h:7,
from ../include/linux/syscalls.h:84,
from ../init/main.c:21:
include/linux/irqnr.h:8:12: note: shadowed declaration is here
8 | extern int nr_irqs;
| ^~~~~~~Rename the local in irqdomain.h to shut up those warnings
--- include/linux/irqdomain.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/irqdomain.h +2 -2
@@ -479,9 +479,9 @@ extern int irq_domain_activate_irq(struct irq_data *irq_data, bool early);extern void irq_domain_deactivate_irq (struct irq_data *irq_data);static inline int irq_domain_alloc_irqs (struct irq_domain *domain, -unsigned int nr_irqs,int node,void *arg) +unsigned int num_irqs,int node,void *arg) { -return __irq_domain_alloc_irqs (domain,-1 , nr_irqs, node, arg, false, +return __irq_domain_alloc_irqs (domain,-1 , num_irqs, node, arg, false,NULL ); }
Signature · 1 line
2.27.0
Quoted 21 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When building with W=2, there are tons of warnings about conflicting local and global definitions of '
nr_irqs' in common header files:
include/linux/irqdomain.h: In function 'irq_domain_alloc_irqs':include/linux/irqdomain.h:482:17: warning: declaration of 'nr_irqs' shadows a global declaration [-Wshadow]482 | unsigned int nr_irqs, int node, void *arg) | ~~~~~~~~~~~~~^~~~~~~ In file included from ../include/linux/interrupt.h:10, from ../include/linux/kernel_stat.h:9, from ../include/linux/cgroup.h:26, from ../include/linux/perf_event.h:57, from ../include/linux/trace_events.h:10, from ../include/trace/syscall.h:7, from ../include/linux/syscalls.h:84, from ../init/main.c:21: include/linux/irqnr.h:8:12: note: shadowed declaration is here 8 | extern int nr_irqs; | ^~~~~~~
Quoted 1 line
Rename the local in
irqdomain.hto shut up those warnings
That's lame tinkering. There are gazillion of other functions which have the very same problem and nr_irqs is used all over the place for local variables.
So instead of trying to chase all these places we really want to rename the global 'nr_irqs' variable.
Something like the uncompiled below which is purely mechanical and does not even try to look at some of the places which use it for the very wrong reasons and purpose * Shudder *.
Thanks,
tglx
--- arch/arm/kernel/irq.c | 4 ++-- arch/powerpc/platforms/cell/axon_msi.c | 2 +- arch/s390/kernel/irq.c | 2 +- arch/x86/kernel/acpi/boot.c | 4 ++-- arch/x86/kernel/apic/vector.c | 8 ++++---- drivers/char/hpet.c | 2 +- drivers/gpio/gpio-vr41xx.c | 2 +- drivers/net/ethernet/3com/3c59x.c | 2 +- drivers/net/hamradio/baycom_ser_fdx.c | 4 ++-- drivers/net/hamradio/scc.c | 6 +++--- drivers/net/wan/sbni.c | 2 +- drivers/pcmcia/at91_cf.c | 2 +- drivers/pcmcia/vrc4171_card.c | 2 +- drivers/scsi/aha152x.c | 2 +- drivers/sh/intc/virq-debugfs.c | 2 +- drivers/tty/serial/8250/8250_port.c | 2 +- drivers/tty/serial/amba-pl010.c | 2 +- drivers/tty/serial/amba-pl011.c | 2 +- drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 +- drivers/tty/serial/serial_core.c | 2 +- drivers/tty/serial/ucc_uart.c | 2 +- drivers/xen/events/events_base.c | 2 +- fs/proc/interrupts.c | 4 ++-- fs/proc/stat.c | 4 ++-- include/linux/irqnr.h | 15 +++++++-------- kernel/irq/irqdesc.c | 26 +++++++++++++------------- kernel/irq/irqdomain.c | 2 +- kernel/irq/proc.c | 4 ++-- kernel/irq/resend.c | 4 ++-- 29 files changed, 59 insertions(+), 60 deletions(-)
arch/arm/kernel/irq.c +2 -2
@@ -100,7 +100,7 @@ void __init init_IRQ(void)#ifdef CONFIG_SPARSE_IRQ int __init arch_probe_nr_irqs (void ) { - nr_irqs = machine_desc->nr_irqs ? machine_desc->nr_irqs :NR_IRQS ; -return nr_irqs; + max_nr_irqs = machine_desc->nr_irqs ? machine_desc->nr_irqs :NR_IRQS ; +return max_nr_irqs; }#endif
arch/powerpc/platforms/cell/axon_msi.c +1 -1
@@ -111,7 +111,7 @@ static void axon_msi_cascade(struct irq_pr_devel ("axon_msi: woff %x roff %x msi %x\n" , write_offset, msic->read_offset, msi); -if (msi < nr_irqs &&irq_get_chip_data (msi) == msic) { +if (msi < max_nr_irqs &&irq_get_chip_data (msi) == msic) {generic_handle_irq (msi); msic->fifo_virt[idx] =cpu_to_le32 (0xffffffff ); }else {
arch/s390/kernel/irq.c +1 -1
@@ -161,7 +161,7 @@ int show_interrupts(struct seq_file *p,seq_putc (p,'\n' ); goto out; } -if (index < nr_irqs) { +if (index < max_nr_irqs) {show_msi_interrupt (p, index); goto out; }
arch/x86/kernel/acpi/boot.c +2 -2
@@ -1195,7 +1195,7 @@ static int __init acpi_parse_madt_ioapic } count =acpi_table_parse_madt (ACPI_MADT_TYPE_INTERRUPT_OVERRIDE , - acpi_parse_int_src_ovr, nr_irqs); + acpi_parse_int_src_ovr, max_nr_irqs);if (count <0 ) { printk(KERN_ERR PREFIX "Error parsing interrupt source overrides entry\n");
@@ -1216,7 +1216,7 @@ static int __init acpi_parse_madt_ioapicmp_config_acpi_legacy_irqs (); count =acpi_table_parse_madt (ACPI_MADT_TYPE_NMI_SOURCE , - acpi_parse_nmi_src, nr_irqs); + acpi_parse_nmi_src, max_nr_irqs);if (count <0 ) { printk(KERN_ERR PREFIX "Error parsing NMI SRC entry\n");/* TBD: Cleanup to allow fallback to MPS */
arch/x86/kernel/apic/vector.c +4 -4
@@ -650,8 +650,8 @@ int __init arch_probe_nr_irqs(void) {int nr; -if (nr_irqs > (NR_VECTORS * nr_cpu_ids)) - nr_irqs =NR_VECTORS * nr_cpu_ids; +if (max_nr_irqs > (NR_VECTORS * nr_cpu_ids)) + max_nr_irqs =NR_VECTORS * nr_cpu_ids; nr = (gsi_top +nr_legacy_irqs ()) +8 * nr_cpu_ids;#if defined(CONFIG_PCI_MSI )
@@ -663,8 +663,8 @@ int __init arch_probe_nr_irqs(void) else nr += gsi_top * 16;#endif -if (nr < nr_irqs) - nr_irqs = nr; +if (nr < max_nr_irqs) + max_nr_irqs = nr;/* * We don't know if PIC is present at this point so we need to do
drivers/char/hpet.c +1 -1
@@ -230,7 +230,7 @@ static void hpet_timer_set_irq(struct hp v &= ~0xffff ;for_each_set_bit (irq, &v,HPET_MAX_IRQ ) { -if (irq >= nr_irqs) { +if (irq >= max_nr_irqs) { irq =HPET_MAX_IRQ ;break ; }
drivers/gpio/gpio-vr41xx.c +1 -1
@@ -517,7 +517,7 @@ static int giu_probe(struct platform_dev } irq =platform_get_irq (pdev,0 ); -if (irq <0 || irq >= nr_irqs) +if (irq <0 || irq >= max_nr_irqs)return -EBUSY ;return cascade_irq (irq, giu_get_irq);
drivers/net/ethernet/3com/3c59x.c +1 -1
@@ -1300,7 +1300,7 @@ static int vortex_probe1(struct device *if (print_info)pr_cont (", IRQ %d\n" , dev->irq);/* Tell them about an invalid IRQ. */ -if (dev->irq <=0 || dev->irq >= nr_irqs) +if (dev->irq <=0 || dev->irq >= max_nr_irqs)pr_warn (" *** Warning: IRQ %d is unlikely to work! ***\n" , dev->irq);
drivers/net/hamradio/baycom_ser_fdx.c +2 -2
@@ -379,10 +379,10 @@ static int ser12_open(struct net_deviceif (!dev || !bc)return -ENXIO ;if (!dev->base_addr || dev->base_addr >0xffff -SER12_EXTENT || - dev->irq <2 || dev->irq > nr_irqs) { + dev->irq <2 || dev->irq > max_nr_irqs) {printk (KERN_INFO "baycom_ser_fdx: invalid portnumber (max %u) " "or irq (2 <= irq <= %d)\n" , -0xffff -SER12_EXTENT , nr_irqs); +0xffff -SER12_EXTENT , max_nr_irqs);return -ENXIO ; }if (bc->baud <300 || bc->baud >4800 ) {
drivers/net/hamradio/scc.c +3 -3
@@ -1467,7 +1467,7 @@ static void z8530_init(void)printk (KERN_INFO "Init Z8530 driver: %u channels, IRQ" , Nchips*2 ); flag=" " ; -for (k =0 ; k < nr_irqs; k++) +for (k =0 ; k < max_nr_irqs; k++)if (Ivec[k].used) {printk ("%s%d" , flag, k);
@@ -1732,7 +1732,7 @@ static int scc_net_ioctl(struct net_deviif (hwcfg.irq ==2 ) hwcfg.irq =9 ; -if (hwcfg.irq <0 || hwcfg.irq >= nr_irqs) +if (hwcfg.irq <0 || hwcfg.irq >= max_nr_irqs)return -EINVAL ;if (!Ivec[hwcfg.irq].used && hwcfg.irq)
@@ -2137,7 +2137,7 @@ static void __exit scc_cleanup_driver(vo }/* To unload the port must be closed so no real IRQ pending */ -for (k =0 ; k < nr_irqs ; k++) +for (k =0 ; k < max_nr_irqs ; k++)if (Ivec[k].used)free_irq (k,NULL );local_irq_enable ();
drivers/net/wan/sbni.c +1 -1
@@ -321,7 +321,7 @@ sbni_pci_probe( struct net_device *devcontinue ; } -if (pci_irq_line <=0 || pci_irq_line >= nr_irqs) +if (pci_irq_line <=0 || pci_irq_line >= max_nr_irqs) pr_warn( "WARNING: The PCI BIOS assigned this PCI card to IRQ %d, which is unlikely to work!.\n" "You should use the PCI BIOS setup to assign a valid IRQ line.\n",
drivers/pcmcia/at91_cf.c +1 -1
@@ -312,7 +312,7 @@ static int at91_cf_probe(struct platform goto fail0a; cf->socket.pci_irq =gpio_to_irq (board->irq_pin); }else - cf->socket.pci_irq = nr_irqs +1 ; + cf->socket.pci_irq = max_nr_irqs +1 ;/* * pcmcia layer only remaps "real" memory not iospace
drivers/pcmcia/vrc4171_card.c +1 -1
@@ -628,7 +628,7 @@ static int vrc4171_card_setup(char *optiint irq; options +=4 ; irq =simple_strtoul (options, &options,0 ); -if (irq >=0 && irq < nr_irqs) +if (irq >=0 && irq < max_nr_irqs) vrc4171_irq = irq;if (*options !=',' )
drivers/scsi/aha152x.c +1 -1
@@ -292,7 +292,7 @@ CMD_INC_RESID(struct scsi_cmnd *cmd, int#else #define IRQ_MIN 9#if defined(__PPC) -#define IRQ_MAX (nr_irqs-1) +#define IRQ_MAX (max_nr_irqs - 1)#else #define IRQ_MAX 12#endif
drivers/sh/intc/virq-debugfs.c +1 -1
@@ -22,7 +22,7 @@ static int intc_irq_xlate_debug(struct sseq_printf (m,"%-5s %-7s %-15s\n" ,"irq" ,"enum" ,"chip name" ); -for (i =1 ; i < nr_irqs; i++) { +for (i =1 ; i < max_nr_irqs; i++) {struct intc_map_entry *entry =intc_irq_xlate_get (i);struct intc_desc_int *desc = entry->desc;
drivers/tty/serial/8250/8250_port.c +1 -1
@@ -3152,7 +3152,7 @@ static void serial8250_config_port(strucstatic int serial8250_verify_port (struct uart_port *port,struct serial_struct *ser) { -if (ser->irq >= nr_irqs || ser->irq <0 || +if (ser->irq >= max_nr_irqs || ser->irq <0 || ser->baud_base <9600 || ser->type <PORT_UNKNOWN || ser->type >=ARRAY_SIZE (uart_config) || ser->type ==PORT_CIRRUS || ser->type ==PORT_STARTECH )
drivers/tty/serial/amba-pl010.c +1 -1
@@ -530,7 +530,7 @@ static int pl010_verify_port(struct uartint ret =0 ;if (ser->type !=PORT_UNKNOWN && ser->type !=PORT_AMBA ) ret = -EINVAL ; -if (ser->irq <0 || ser->irq >= nr_irqs) +if (ser->irq <0 || ser->irq >= max_nr_irqs) ret = -EINVAL ;if (ser->baud_base <9600 ) ret = -EINVAL ;
drivers/tty/serial/amba-pl011.c +1 -1
@@ -2119,7 +2119,7 @@ static int pl011_verify_port(struct uartint ret =0 ;if (ser->type !=PORT_UNKNOWN && ser->type !=PORT_AMBA ) ret = -EINVAL ; -if (ser->irq <0 || ser->irq >= nr_irqs) +if (ser->irq <0 || ser->irq >= max_nr_irqs) ret = -EINVAL ;if (ser->baud_base <9600 ) ret = -EINVAL ;
drivers/tty/serial/cpm_uart/cpm_uart_core.c +1 -1
@@ -657,7 +657,7 @@ static int cpm_uart_verify_port(struct uif (ser->type !=PORT_UNKNOWN && ser->type !=PORT_CPM ) ret = -EINVAL ; -if (ser->irq <0 || ser->irq >= nr_irqs) +if (ser->irq <0 || ser->irq >= max_nr_irqs) ret = -EINVAL ;if (ser->baud_base <9600 ) ret = -EINVAL ;
drivers/tty/serial/serial_core.c +1 -1
@@ -875,7 +875,7 @@ static int uart_set_info(struct tty_struif (uport->ops->verify_port) retval = uport->ops->verify_port (uport, new_info); -if ((new_info->irq >= nr_irqs) || (new_info->irq <0 ) || +if ((new_info->irq >= max_nr_irqs) || (new_info->irq <0 ) || (new_info->baud_base <9600 )) retval = -EINVAL ;
drivers/tty/serial/ucc_uart.c +1 -1
@@ -1065,7 +1065,7 @@ static int qe_uart_verify_port(struct uaif (ser->type !=PORT_UNKNOWN && ser->type !=PORT_CPM )return -EINVAL ; -if (ser->irq <0 || ser->irq >= nr_irqs) +if (ser->irq <0 || ser->irq >= max_nr_irqs)return -EINVAL ;if (ser->baud_base <9600 )
drivers/xen/events/events_base.c +1 -1
@@ -348,7 +348,7 @@ evtchn_port_t evtchn_from_irq(unsigned i {const struct irq_info *info =NULL ; -if (likely (irq < nr_irqs)) +if (likely (irq < max_nr_irqs)) info =info_for_irq (irq);if (!info)return 0 ;
fs/proc/interrupts.c +2 -2
@@ -11,13 +11,13 @@*/ static void *int_seq_start (struct seq_file *f,loff_t *pos) { -return (*pos <= nr_irqs) ? pos :NULL ; +return (*pos <= max_nr_irqs) ? pos :NULL ; }static void *int_seq_next (struct seq_file *f,void *v,loff_t *pos) { (*pos)++; -if (*pos > nr_irqs) +if (*pos > max_nr_irqs)return NULL ;return pos; }
fs/proc/stat.c +2 -2
@@ -101,7 +101,7 @@ static void show_all_irqs(struct seq_filseq_put_decimal_ull (p," " ,kstat_irqs_usr (i)); next = i +1 ; } -show_irq_gap (p, nr_irqs - next); +show_irq_gap (p, max_nr_irqs - next); }static int show_stat (struct seq_file *p,void *v)
@@ -219,7 +219,7 @@ static int stat_open(struct inode *inodeunsigned int size =1024 +128 *num_online_cpus ();/* minimum size to display an interrupt count : 2 bytes */ - size +=2 * nr_irqs; + size +=2 * max_nr_irqs;return single_open_size (file, show_stat,NULL , size); }
include/linux/irqnr.h +7 -8
@@ -4,13 +4,12 @@#include <uapi/linux/irqnr.h> - -extern int nr_irqs; +extern int max_nr_irqs;extern struct irq_desc *irq_to_desc (unsigned int irq);unsigned int irq_get_next_irq (unsigned int offset);# define for_each_irq_desc (irq, desc) \ - for (irq = 0, desc = irq_to_desc(irq); irq < nr_irqs; \ + for (irq = 0, desc = irq_to_desc(irq); irq < max_nr_irqs; \ irq++, desc = irq_to_desc(irq)) \ if (!desc) \ ; \
@@ -18,17 +17,17 @@ unsigned int irq_get_next_irq(unsigned i# define for_each_irq_desc_reverse (irq, desc) \ - for (irq = nr_irqs - 1, desc = irq_to_desc(irq); irq >= 0; \ + for (irq = max_nr_irqs - 1, desc = irq_to_desc(irq); irq >= 0; \ irq--, desc = irq_to_desc(irq)) \ if (!desc) \ ; \ else -# define for_each_active_irq (irq) \ - for (irq = irq_get_next_irq(0); irq < nr_irqs; \ +# define for_each_active_irq (irq) \ + for (irq = irq_get_next_irq(0); irq < max_nr_irqs; \ irq = irq_get_next_irq(irq + 1)) -#define for_each_irq_nr (irq) \ - for (irq = 0; irq < nr_irqs; irq++) +#define for_each_irq_nr (irq) \ + for (irq = 0; irq < max_nr_irqs; irq++)#endif
kernel/irq/irqdesc.c +13 -13
@@ -127,8 +127,8 @@ static void desc_set_defaults(unsigned idesc_smp_init (desc, node, affinity); } -int nr_irqs =NR_IRQS ; -EXPORT_SYMBOL_GPL (nr_irqs); +int max_nr_irqs =NR_IRQS ; +EXPORT_SYMBOL_GPL (max_nr_irqs);static DEFINE_MUTEX (sparse_irq_lock); static DECLARE_BITMAP(allocated_irqs, IRQ_BITMAP_BITS);
@@ -512,7 +512,7 @@ static int irq_expand_nr_irqs(unsigned i {if (nr >IRQ_BITMAP_BITS )return -ENOMEM ; - nr_irqs = nr; + max_nr_irqs = nr;return 0 ; }
@@ -526,16 +526,16 @@ int __init early_irq_init(void)/* Let arch update nr_irqs and return the nr of preallocated irqs */ initcnt =arch_probe_nr_irqs ();printk (KERN_INFO "NR_IRQS: %d, nr_irqs: %d, preallocated irqs: %d\n" , -NR_IRQS , nr_irqs, initcnt); +NR_IRQS , max_nr_irqs, initcnt); -if (WARN_ON (nr_irqs >IRQ_BITMAP_BITS )) - nr_irqs =IRQ_BITMAP_BITS ; +if (WARN_ON (max_nr_irqs >IRQ_BITMAP_BITS )) + max_nr_irqs =IRQ_BITMAP_BITS ;if (WARN_ON (initcnt >IRQ_BITMAP_BITS )) initcnt =IRQ_BITMAP_BITS ; -if (initcnt > nr_irqs) - nr_irqs = initcnt; +if (initcnt > max_nr_irqs) + max_nr_irqs = initcnt;for (i =0 ; i < initcnt; i++) { desc =alloc_desc (i, node,0 ,NULL ,NULL );
@@ -680,7 +680,7 @@ int __handle_domain_irq(struct irq_domai* Some hardware gives randomly wrong interrupts. Rather * than crashing, do something sensible. */ -if (unlikely (!irq || irq >= nr_irqs)) { +if (unlikely (!irq || irq >= max_nr_irqs)) {ack_bad_irq (irq); ret = -EINVAL ; }else {
@@ -743,7 +743,7 @@ void irq_free_descs(unsigned int from, u {int i; -if (from >= nr_irqs || (from + cnt) > nr_irqs) +if (from >= max_nr_irqs || (from + cnt) > max_nr_irqs)return ;mutex_lock (&sparse_irq_lock);
@@ -798,7 +798,7 @@ int __refif (irq >=0 && start != irq) goto unlock; -if (start + cnt > nr_irqs) { +if (start + cnt > max_nr_irqs) { ret =irq_expand_nr_irqs (start + cnt);if (ret) goto unlock;
@@ -814,11 +814,11 @@ EXPORT_SYMBOL_GPL(__irq_alloc_descs);* irq_get_next_irq - get next allocated irq number * @offset: where to start the search * -* Returns next irq number after offset or nr_irqs if none is found. +* Returns next irq number after offset or max_nr_irqs if none is found. */ unsigned int irq_get_next_irq (unsigned int offset) { -return find_next_bit (allocated_irqs, nr_irqs, offset); +return find_next_bit (allocated_irqs, max_nr_irqs, offset); } struct irq_desc *
kernel/irq/irqdomain.c +1 -1
@@ -1030,7 +1030,7 @@ int irq_domain_alloc_descs(int virq, uns virq =__irq_alloc_descs (virq, virq, cnt, node,THIS_MODULE , affinity); }else { - hint = hwirq % nr_irqs; + hint = hwirq % max_nr_irqs;if (hint ==0 ) hint++; virq = __irq_alloc_descs(-1, hint, cnt, node, THIS_MODULE,
kernel/irq/proc.c +2 -2
@@ -454,7 +454,7 @@ int __weak arch_show_interrupts(struct s }#ifndef ACTUAL_NR_IRQS -# define ACTUAL_NR_IRQS nr_irqs +# define ACTUAL_NR_IRQS max_nr_irqs#endif int show_interrupts (struct seq_file *p,void *v)
@@ -474,7 +474,7 @@ int show_interrupts(struct seq_file *p,/* print header and calculate the width of the first column */ if (i ==0 ) { -for (prec =3 , j =1000 ; prec <10 && j <= nr_irqs; ++prec) +for (prec =3 , j =1000 ; prec <10 && j <= max_nr_irqs; ++prec) j *=10 ;seq_printf (p,"%*s" , prec +8 ,"" );
kernel/irq/resend.c +2 -2
@@ -32,8 +32,8 @@ static void resend_irqs(unsigned long arstruct irq_desc *desc;int irq; -while (!bitmap_empty (irqs_resend, nr_irqs)) { - irq =find_first_bit (irqs_resend, nr_irqs); +while (!bitmap_empty (irqs_resend, max_nr_irqs)) { + irq =find_first_bit (irqs_resend, max_nr_irqs);clear_bit (irq, irqs_resend); desc =irq_to_desc (irq);if (!desc)
Quoted 22 lines · Thomas Gleixner
Quoted 21 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When building with W=2, there are tons of warnings about conflicting local and global definitions of '
nr_irqs' in common header files:
include/linux/irqdomain.h: In function 'irq_domain_alloc_irqs':include/linux/irqdomain.h:482:17: warning: declaration of 'nr_irqs' shadows a global declaration [-Wshadow]482 | unsigned int nr_irqs, int node, void *arg) | ~~~~~~~~~~~~~^~~~~~~ In file included from ../include/linux/interrupt.h:10, from ../include/linux/kernel_stat.h:9, from ../include/linux/cgroup.h:26, from ../include/linux/perf_event.h:57, from ../include/linux/trace_events.h:10, from ../include/trace/syscall.h:7, from ../include/linux/syscalls.h:84, from ../init/main.c:21: include/linux/irqnr.h:8:12: note: shadowed declaration is here 8 | extern int nr_irqs; | ^~~~~~~
Quoted 8 lines
Quoted 1 line
Rename the local in
irqdomain.hto shut up those warningsThat's lame tinkering. There are gazillion of other functions which have the very same problem and
nr_irqsis used all over the place for local variables.So instead of trying to chase all these places we really want to rename the global '
nr_irqs' variable.
Fair enough, yes.
Quoted 3 lines
Something like the uncompiled below which is purely mechanical and does not even try to look at some of the places which use it for the very wrong reasons and purpose * Shudder *.
Looks good to me.
If we rename it, we might want to pick an even longer name to make it stand out in code review when it does get used, and easier to grep for.
I don't have my build testing infrastructure running at the moment, once I get that back up, I can start testing your patch.
arch/arm/kernel/irq.c void __init init_IRQ(void) · line 106
Quoted 12 lines
arch/arm/kernel/irq.c +2
-2@@ -100,7 +100,7 @@ void __init init_IRQ(void)#ifdef CONFIG_SPARSE_IRQ int __init arch_probe_nr_irqs (void ) { - nr_irqs = machine_desc->nr_irqs ? machine_desc->nr_irqs :NR_IRQS ; -return nr_irqs; + max_nr_irqs = machine_desc->nr_irqs ? machine_desc->nr_irqs :NR_IRQS ; +return max_nr_irqs; }#endif
I think this one can just lose the assignment and return the value.
arch/powerpc/platforms/cell/axon_msi.c static void axon_msi_cascade(struct irq_ · line 117
Quoted 11 lines
arch/powerpc/platforms/cell/axon_msi.c +1
-1@@ -111,7 +111,7 @@ static void axon_msi_cascade(struct irq_pr_devel ("axon_msi: woff %x roff %x msi %x\n" , write_offset, msic->read_offset, msi); -if (msi < nr_irqs &&irq_get_chip_data (msi) == msic) { +if (msi < max_nr_irqs &&irq_get_chip_data (msi) == msic) {generic_handle_irq (msi); msic->fifo_virt[idx] =cpu_to_le32 (0xffffffff ); }else {
Most of the ones like this seem to have been simply converted from old sanity checks using NR_IRQS and would work just as well without the checks.
Actually removing the checks would have a small regression potential.
drivers/pcmcia/at91_cf.c
Quoted 2 lines
drivers/pcmcia/at91_cf.c +0
-0
potential.
drivers/pcmcia/at91_cf.c static int at91_cf_probe(struct platform · line 318
Quoted 9 lines
drivers/pcmcia/at91_cf.c +1
-1@@ -312,7 +312,7 @@ static int at91_cf_probe(struct platform goto fail0a; cf->socket.pci_irq =gpio_to_irq (board->irq_pin); }else - cf->socket.pci_irq = nr_irqs +1 ; + cf->socket.pci_irq = max_nr_irqs +1 ;/* * pcmcia layer only remaps "real" memory not iospace
This one would seem to actually warrant a bugfix, setting the field to zero.
Arnd
Quoted 10 lines · Arnd Bergmann
Quoted 2 lines · Thomas Gleixner
So instead of trying to chase all these places we really want to rename the global '
nr_irqs' variable.Fair enough, yes.
Quoted 3 lines
Something like the uncompiled below which is purely mechanical and does not even try to look at some of the places which use it for the very wrong reasons and purpose * Shudder *.
Quoted 5 lines
Looks good to me.
If we rename it, we might want to pick an even longer name to make it stand out in code review when it does get used, and easier to grep for.
Sure, I just picked it lazily without much thought.
Quoted 8 lines
Quoted 4 lines
+ if (msi < max_nr_irqs && irq_get_chip_data(msi) == msic) { generic_handle_irq(msi); msic->fifo_virt[idx] = cpu_to_le32(0xffffffff); } else {Most of the ones like this seem to have been simply converted from old sanity checks using
NR_IRQSand would work just as well without the checks.
Yeah. As I said I did not look closely, but the peek already told me that there is cruft.
Quoted 2 lines
Actually removing the checks would have a small regression potential.
Right, it shouldn't cause problems.
Quoted 12 lines
drivers/pcmcia/at91_cf.c
Quoted 2 lines
drivers/pcmcia/at91_cf.c +0
-0potential.
Quoted 7 lines
drivers/pcmcia/at91_cf.c +1
-1@@ -312,7 +312,7 @@ static int at91_cf_probe(struct platform goto fail0a; cf->socket.pci_irq =gpio_to_irq (board->irq_pin); }else - cf->socket.pci_irq = nr_irqs +1 ; + cf->socket.pci_irq = max_nr_irqs +1 ;
Quoted 5 lines
drivers/pcmcia/at91_cf.c static int at91_cf_probe(struct platform · line 318
Quoted 2 lines
drivers/pcmcia/at91_cf.c +0
-0/* * pcmcia layer only remaps "real" memory not iospace This one would seem to actually warrant a bugfix, setting the field to zero.
Indeed.
Thanks,
tglx