Skip to contentSkip to conversation

printk: remove unneeded dead-store assignment

PATCH In review Lukas Bulwahn 5 participants 5 messages Nov 6, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 printk: remove unneeded dead-store assignment

make clang-analyzer on x86_64 defconfig caught my attention with:

kernel/printk/printk_ringbuffer.c:885:3: warning:
Value stored to 'desc' is never read [clang-analyzer-deadcode.DeadStores]

                desc = to_desc(desc_ring, head_id);
                ^

Commit b6cf8b3f3312 ("printk: add lockless ringbuffer") introduced desc_reserve() with this unneeded dead-store assignment.

As discussed with John Ogness privately, this is probably just some minor left-over from previous iterations of the ringbuffer implementation. So, simply remove this unneeded dead assignment to make clang-analyzer happy.

As compilers will detect this unneeded assignment and optimize this anyway, the resulting object code is identical before and after this change.

No functional change. No change to object code.

---
applies cleanly on current master and next-20201105

John, please ack.
Petr, please pick this minor non-urgent clean-up patch.

 kernel/printk/printk_ringbuffer.c | 2 --
 1 file changed, 2 deletions(-)
kernel/printk/printk_ringbuffer.c +0 -2
index 6b1525685277..74e25a1704f2 100644
@@ -882,8 +882,6 @@ static bool desc_reserve(struct printk_ringbuffer *rb, unsigned long *id_out)
 	head_id = atomic_long_read(&desc_ring->head_id); /* LMM(desc_reserve:A) */
 
 	do {
-		desc = to_desc(desc_ring, head_id);
-
 		id = DESC_ID(head_id + 1);
 		id_prev_wrap = DESC_ID_PREV_WRAP(desc_ring, id);
 
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Lukas Bulwahn

make clang-analyzer on x86_64 defconfig caught my attention with:

kernel/printk/printk_ringbuffer.c:885:3: warning:
Value stored to 'desc' is never read [clang-analyzer-deadcode.DeadStores]

                desc = to_desc(desc_ring, head_id);
                ^

Commit b6cf8b3f3312 ("printk: add lockless ringbuffer") introduced desc_reserve() with this unneeded dead-store assignment.

As discussed with John Ogness privately, this is probably just some minor left-over from previous iterations of the ringbuffer implementation. So, simply remove this unneeded dead assignment to make clang-analyzer happy.

Quoted 6 lines

As compilers will detect this unneeded assignment and optimize this anyway, the resulting object code is identical before and after this change.

No functional change. No change to object code.

Quoted 25 lines

---
applies cleanly on current master and next-20201105

John, please ack.
Petr, please pick this minor non-urgent clean-up patch.

 kernel/printk/printk_ringbuffer.c | 2 --
 1 file changed, 2 deletions(-)
kernel/printk/printk_ringbuffer.c +0 -2
index 6b1525685277..74e25a1704f2 100644
@@ -882,8 +882,6 @@ static bool desc_reserve(struct printk_ringbuffer *rb, unsigned long *id_out)
 	head_id = atomic_long_read(&desc_ring->head_id); /* LMM(desc_reserve:A) */
 
 	do {
-		desc = to_desc(desc_ring, head_id);
-
 		id = DESC_ID(head_id + 1);
 		id_prev_wrap = DESC_ID_PREV_WRAP(desc_ring, id);
 
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Lukas Bulwahn
Quoted 14 lines · Lukas Bulwahn

make clang-analyzer on x86_64 defconfig caught my attention with:

kernel/printk/printk_ringbuffer.c:885:3: warning:
Value stored to 'desc' is never read [clang-analyzer-deadcode.DeadStores]

                desc = to_desc(desc_ring, head_id);
                ^

Commit b6cf8b3f3312 ("printk: add lockless ringbuffer") introduced desc_reserve() with this unneeded dead-store assignment.

As discussed with John Ogness privately, this is probably just some minor left-over from previous iterations of the ringbuffer implementation. So, simply remove this unneeded dead assignment to make clang-analyzer happy.

Quoted 6 lines

As compilers will detect this unneeded assignment and optimize this anyway, the resulting object code is identical before and after this change.

No functional change. No change to object code.

	-ss
maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Lukas Bulwahn
Quoted 14 lines · Lukas Bulwahn

make clang-analyzer on x86_64 defconfig caught my attention with:

kernel/printk/printk_ringbuffer.c:885:3: warning:
Value stored to 'desc' is never read [clang-analyzer-deadcode.DeadStores]

                desc = to_desc(desc_ring, head_id);
                ^

Commit b6cf8b3f3312 ("printk: add lockless ringbuffer") introduced desc_reserve() with this unneeded dead-store assignment.

As discussed with John Ogness privately, this is probably just some minor left-over from previous iterations of the ringbuffer implementation. So, simply remove this unneeded dead assignment to make clang-analyzer happy.

Quoted 6 lines

As compilers will detect this unneeded assignment and optimize this anyway, the resulting object code is identical before and after this change.

No functional change. No change to object code.

maintainer
#4 lore raw
In reply to Lukas Bulwahn
Quoted 14 lines · Lukas Bulwahn

make clang-analyzer on x86_64 defconfig caught my attention with:

kernel/printk/printk_ringbuffer.c:885:3: warning:
Value stored to 'desc' is never read [clang-analyzer-deadcode.DeadStores]

                desc = to_desc(desc_ring, head_id);
                ^

Commit b6cf8b3f3312 ("printk: add lockless ringbuffer") introduced desc_reserve() with this unneeded dead-store assignment.

As discussed with John Ogness privately, this is probably just some minor left-over from previous iterations of the ringbuffer implementation. So, simply remove this unneeded dead assignment to make clang-analyzer happy.

Quoted 6 lines

As compilers will detect this unneeded assignment and optimize this anyway, the resulting object code is identical before and after this change.

No functional change. No change to object code.

The patch is committed in printk/linux.git, branch for-5.10-trivial.

It might still go into 5.10 when there is another important fix. Otherwise, it would need to wait for 5.11 merge window.

Best Regards,
Petr