Skip to contentSkip to conversation

busybox: Enable domain search list support in udhcpc

PATCH New Alexey Brodkin 3 participants 5 messages Apr 8, 2019 – Aug 30, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 busybox: Enable domain search list support in udhcpc

This is useful in networks with internal resources as it allows to use much shorter names.

E.g. instead of "server.internal.company.com" it's possible to use just "server" if DHCP server is configured with:
---------------------------->8----------------------- option domain-search "internal.company.com"; ---------------------------->8-----------------------

This improvement consists of 2 parts:

1. Enable handling of RFC3397 so DHCP client is ready for processing corresponding data from DHCP server.

2. Some DHCP servers always send out search list if it is set in server's configuration and some servers only provide search list if client asks for that (sending list of options it expectes to get).

And exactly for those stubborn DHCP servers we need to add "-O search" to udhcp's command line via CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS.

Cc Ignacy Gawedzki <[email protected]>
Cc Peter Korsgaard <[email protected]>
---
 package/busybox/busybox.config | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/busybox/busybox.config +2 -2
index 1d9560d655..ab04854c83 100644
@@ -967,9 +967,9 @@ CONFIG_UDHCPC_DEFAULT_SCRIPT="/usr/share/udhcpc/default.script"
 # CONFIG_FEATURE_UDHCP_PORT is not set
 CONFIG_UDHCP_DEBUG=0
 CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS=80
-# CONFIG_FEATURE_UDHCP_RFC3397 is not set
+CONFIG_FEATURE_UDHCP_RFC3397=y
 CONFIG_FEATURE_UDHCP_8021Q=y
-CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-R -n"
+CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-R -n -O search"
 
 #
 # Print Utilities
Signature · 1 line
2.16.2
#1 lore raw

PATCH 1/1 busybox: Enable domain search list support in udhcpc

Alexey, All,

On 2019-04-08 14:00 +0300, Alexey Brodkin spake thusly:

Quoted 18 lines

This is useful in networks with internal resources as it allows to use much shorter names.

E.g. instead of "server.internal.company.com" it's possible to use just "server" if DHCP server is configured with:
---------------------------->8----------------------- option domain-search "internal.company.com"; ---------------------------->8-----------------------

This improvement consists of 2 parts:

1. Enable handling of RFC3397 so DHCP client is ready for processing corresponding data from DHCP server.

2. Some DHCP servers always send out search list if it is set in server's configuration and some servers only provide search list if client asks for that (sending list of options it expectes to get).

Quoted 6 lines

And exactly for those stubborn DHCP servers we need to add "-O search" to udhcp's command line via CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS.

Cc Ignacy Gawedzki <[email protected]>
Cc Peter Korsgaard <[email protected]>

Regards,
Yann E. MORIN.

Quoted 27 lines
---
 package/busybox/busybox.config | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/busybox/busybox.config +2 -2
index 1d9560d655..ab04854c83 100644
@@ -967,9 +967,9 @@ CONFIG_UDHCPC_DEFAULT_SCRIPT="/usr/share/udhcpc/default.script"
 # CONFIG_FEATURE_UDHCP_PORT is not set
 CONFIG_UDHCP_DEBUG=0
 CONFIG_UDHCPC_SLACK_FOR_BUGGY_SERVERS=80
-# CONFIG_FEATURE_UDHCP_RFC3397 is not set
+CONFIG_FEATURE_UDHCP_RFC3397=y
 CONFIG_FEATURE_UDHCP_8021Q=y
-CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-R -n"
+CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS="-R -n -O search"
 
 #
 # Print Utilities
Signature · 6 lines
2.16.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 busybox: Enable domain search list support in udhcpc

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Alexey, All,
On 2019-04-08 14:00 +0300, Alexey Brodkin spake thusly:

Quoted 5 lines

This is useful in networks with internal resources as it allows to use much shorter names.

E.g. instead of "server.internal.company.com" it's possible to use just "server" if DHCP server is configured with:

----------------------------> 8-----------------------

Quoted 1 line
Quoted 1 line

option domain-search "internal.company.com";

----------------------------> 8-----------------------

Quoted 10 lines
Quoted 10 lines

This improvement consists of 2 parts:

1. Enable handling of RFC3397 so DHCP client is ready for processing corresponding data from DHCP server.

2. Some DHCP servers always send out search list if it is set in server's configuration and some servers only provide search list if client asks for that (sending list of options it expectes to get).

Quoted 8 lines
Quoted 6 lines

And exactly for those stubborn DHCP servers we need to add "-O search" to udhcp's command line via CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS.

Cc Ignacy Gawedzki <[email protected]>
Cc Peter Korsgaard <[email protected]>

Committed, thanks.

Notice: For a single domain, I believe you can just set

option domain-name "internal.company.com"

In the DHCP server config, which will work out of the box using the classic (option 15) domain name option.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 busybox: Enable domain search list support in udhcpc

Hi Peter,

Quoted 37 lines

-----Original Message-----
From: Peter Korsgaard <[email protected]> On Behalf Of Peter Korsgaard
Sent: Saturday, August 3, 2019 7:04 PM
To: Yann E. MORIN <[email protected]>
Cc: Alexey Brodkin <[email protected]>; buildroot at busybox.net; Ignacy Gawedzki <[email protected]>; ARC Buildroot mailing list <[email protected]>
Subject: Re: [PATCH] busybox: Enable domain search list support in udhcpc

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Alexey, All,
On 2019-04-08 14:00 +0300, Alexey Brodkin spake thusly:

Quoted 5 lines

This is useful in networks with internal resources as it allows to use much shorter names.

E.g. instead of "server.internal.company.com" it's possible to use just "server" if DHCP server is configured with:

----------------------------> 8-----------------------

Quoted 1 line
Quoted 1 line

option domain-search "internal.company.com";

----------------------------> 8-----------------------

Quoted 16 lines
Quoted 16 lines

This improvement consists of 2 parts:

1. Enable handling of RFC3397 so DHCP client is ready for processing corresponding data from DHCP server.

2. Some DHCP servers always send out search list if it is set in server's configuration and some servers only provide search list if client asks for that (sending list of options it expectes to get).

And exactly for those stubborn DHCP servers we need to add "-O search" to udhcp's command line via CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS.

Cc Ignacy Gawedzki <[email protected]>
Cc Peter Korsgaard <[email protected]>
Quoted 7 lines
Quoted 1 line

Committed, thanks.

Notice: For a single domain, I believe you can just set

option domain-name "internal.company.com"

Sure that's perfectly possible.
But in some networks (for example) like we have in the company they do use search domains and w/o it boards connected to the network get incomplete configuration and cannot access internal resources.

-Alexey

#4 lore raw

PATCH 1/1 busybox: Enable domain search list support in udhcpc

In reply to Yann E. MORIN
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

On 2019-04-08 14:00 +0300, Alexey Brodkin spake thusly:

Quoted 5 lines

This is useful in networks with internal resources as it allows to use much shorter names.

E.g. instead of "server.internal.company.com" it's possible to use just "server" if DHCP server is configured with:

----------------------------> 8-----------------------

Quoted 1 line
Quoted 1 line

option domain-search "internal.company.com";

----------------------------> 8-----------------------

Quoted 10 lines
Quoted 10 lines

This improvement consists of 2 parts:

1. Enable handling of RFC3397 so DHCP client is ready for processing corresponding data from DHCP server.

2. Some DHCP servers always send out search list if it is set in server's configuration and some servers only provide search list if client asks for that (sending list of options it expectes to get).

Quoted 6 lines
Quoted 6 lines

And exactly for those stubborn DHCP servers we need to add "-O search" to udhcp's command line via CONFIG_IFUPDOWN_UDHCPC_CMD_OPTIONS.

Cc Ignacy Gawedzki <[email protected]>
Cc Peter Korsgaard <[email protected]>

Committed to 2019.02.x and 2019.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard