Skip to contentSkip to conversation

ath10k: Drop WARN_ON()s that always trigger during system resume

PATCH In review Rafael J. Wysocki 2 participants 3 messages Mar 1, 2019 – Mar 3, 2019 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: Drop WARN_ON()s that always trigger during system resume

rom: Rafael J. Wysocki <[email protected]>

ath10k_mac_vif_chan() always returns an error for the given vif during system-wide resume which reliably triggers two WARN_ON()s in ath10k_bss_info_changed() and they are not particularly useful in that code path, so drop them.

---
 drivers/net/wireless/ath/ath10k/mac.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath10k/mac.c +2 -2
Index: linux-pm/drivers/net/wireless/ath/ath10k/mac.c
===================================================================
@@ -5705,7 +5705,7 @@ static void ath10k_bss_info_changed(stru
 	}
 
 	if (changed & BSS_CHANGED_MCAST_RATE &&
-	    !WARN_ON(ath10k_mac_vif_chan(arvif->vif, &def))) {
+	    !ath10k_mac_vif_chan(arvif->vif, &def)) {
 		band = def.chan->band;
 		rateidx = vif->bss_conf.mcast_rate[band] - 1;
 
@@ -5743,7 +5743,7 @@ static void ath10k_bss_info_changed(stru
 	}
 
 	if (changed & BSS_CHANGED_BASIC_RATES) {
-		if (WARN_ON(ath10k_mac_vif_chan(vif, &def))) {
+		if (ath10k_mac_vif_chan(vif, &def)) {
 			mutex_unlock(&ar->conf_mutex);
 			return;
 		}
#1 lore raw
Quoted 1 line · Rafael J. Wysocki

rom: Rafael J. Wysocki <[email protected]>

'F' chraracter is missing.

Quoted 6 lines

ath10k_mac_vif_chan() always returns an error for the given vif during system-wide resume which reliably triggers two WARN_ON()s in ath10k_bss_info_changed() and they are not particularly useful in that code path, so drop them.

And could you CC linux-wireless, please? That way the patchwork will see it and I can take it directly from there.

Signature · 1 line
Kalle Valo
#2 lore raw
Quoted 11 lines · CET Kalle Valo
Quoted 1 line · Rafael J. Wysocki

rom: Rafael J. Wysocki <[email protected]>

'F' chraracter is missing.

Quoted 5 lines

ath10k_mac_vif_chan() always returns an error for the given vif during system-wide resume which reliably triggers two WARN_ON()s in ath10k_bss_info_changed() and they are not particularly useful in that code path, so drop them.

Quoted 4 lines
Quoted 1 line

And could you CC linux-wireless, please? That way the patchwork will see it and I can take it directly from there.

Done, thank you!