Skip to contentSkip to conversation

package/docker-containerd: fix typo in uclibc dependency

PATCH New Thomas Petazzoni 2 participants 3 messages Feb 14, 2019 – Feb 21, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/docker-containerd: fix typo in uclibc dependency

Commit 6e3f7fbc072c88ab344f2ffa39e402464b566f19 ("package/runc: add upstream security fix for CVE-2019-5736") added a dependency of docker-containerd to uclibc (inherited from runc), but the depends on has a typo that makes it ineffective. Due to this, docker-containerd can still be selected in uClibc configurations, causing runc to be build, and failing to build due fexecve() being missing in uClibc.

Fixes:

http://autobuild.buildroot.net/results/64ecdb1e007106fdb05979b10b42b90591255504/

---
 package/docker-containerd/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/docker-containerd/Config.in +1 -1
index bdb5dd7b80..5e0cc1e877 100644
@@ -3,7 +3,7 @@ config BR2_PACKAGE_DOCKER_CONTAINERD
 	depends on BR2_PACKAGE_HOST_GO_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_HOST_GO_CGO_LINKING_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_PACKAGE_TOOLCHAIN_USES_UCLIBC # runc
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC # runc
 	depends on BR2_USE_MMU # util-linux
 	select BR2_PACKAGE_RUNC # runtime dependency
 	select BR2_PACKAGE_UTIL_LINUX # runtime dependency
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/docker-containerd: fix typo in uclibc dependency

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Commit 6e3f7fbc072c88ab344f2ffa39e402464b566f19 ("package/runc: add upstream security fix for CVE-2019-5736") added a dependency of docker-containerd to uclibc (inherited from runc), but the depends on has a typo that makes it ineffective. Due to this, docker-containerd can still be selected in uClibc configurations, causing runc to be build, and failing to build due fexecve() being missing in uClibc.

Quoted 5 lines

Fixes:

http://autobuild.buildroot.net/results/64ecdb1e007106fdb05979b10b42b90591255504/

Ups - Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/docker-containerd: fix typo in uclibc dependency

In reply to Thomas Petazzoni
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Commit 6e3f7fbc072c88ab344f2ffa39e402464b566f19 ("package/runc: add upstream security fix for CVE-2019-5736") added a dependency of docker-containerd to uclibc (inherited from runc), but the depends on has a typo that makes it ineffective. Due to this, docker-containerd can still be selected in uClibc configurations, causing runc to be build, and failing to build due fexecve() being missing in uClibc.

Quoted 5 lines

Fixes:

http://autobuild.buildroot.net/results/64ecdb1e007106fdb05979b10b42b90591255504/

Committed to 2018.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard