Skip to contentSkip to conversation

libsemanage: define installation location of semanage.conf for host

PATCH New Thomas Petazzoni 3 participants 4 messages Nov 9, 2018 – Nov 26, 2018

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 libsemanage: define installation location of semanage.conf for host

When /etc/selinux/semanage.conf does not exist, libsemanage tries to overwrite it. For the target package, it works fine because $(DESTDIR) is taken into account.

However, for the host package, $(DESTDIR) is empty, and the location used for /etc/selinux/semanage.conf is not affected by $(PREFIX). This causes host-libsemanage to try to install /etc/selinux/semanage.conf, which obviously fails with:

test -f /etc/selinux/semanage.conf || install -m 644 -D semanage.conf /etc/selinux/semanage.conf
install: cannot create directory '/etc/selinux': Permission denied

To fix this, this commit passes DEFAULT_SEMANAGE_CONF_LOCATION in the make options when building/installing host-libsemanage, providing a path to semanage.conf that Buildroot can write to.

Fixes:

http://autobuild.buildroot.net/results/cd27e3c66274622d0c3dd5a601a36efb1bc45011/

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/libsemanage/libsemanage.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/libsemanage/libsemanage.mk +2 -1
index d554a33356..bbde50f49f 100644
@@ -31,7 +31,8 @@ HOST_LIBSEMANAGE_DEPENDENCIES = host-bison host-audit host-libsepol host-libseli
 HOST_LIBSEMANAGE_MAKE_OPTS += \
 	$(HOST_CONFIGURE_OPTS) \
 	PREFIX=$(HOST_DIR) \
-	SWIG_LIB="$(HOST_DIR)/share/swig/$(SWIG_VERSION)/"
+	SWIG_LIB="$(HOST_DIR)/share/swig/$(SWIG_VERSION)/" \
+	DEFAULT_SEMANAGE_CONF_LOCATION=$(HOST_DIR)/etc/selinux/semanage.conf
 
 ifeq ($(BR2_PACKAGE_PYTHON3),y)
 HOST_LIBSEMANAGE_DEPENDENCIES += host-python3
Signature · 1 line
2.14.5
#1 lore raw

PATCH 1/1 libsemanage: define installation location of semanage.conf for host

Thomas,

Quoted 17 lines · Thomas Petazzoni

When /etc/selinux/semanage.conf does not exist, libsemanage tries to overwrite it. For the target package, it works fine because $(DESTDIR) is taken into account.

However, for the host package, $(DESTDIR) is empty, and the location used for /etc/selinux/semanage.conf is not affected by $(PREFIX). This causes host-libsemanage to try to install /etc/selinux/semanage.conf, which obviously fails with:

test -f /etc/selinux/semanage.conf || install -m 644 -D semanage.conf /etc/selinux/semanage.conf
install: cannot create directory '/etc/selinux': Permission denied

To fix this, this commit passes DEFAULT_SEMANAGE_CONF_LOCATION in the make options when building/installing host-libsemanage, providing a path to semanage.conf that Buildroot can write to.

Quoted 5 lines

Fixes:

http://autobuild.buildroot.net/results/cd27e3c66274622d0c3dd5a601a36efb1bc45011/

Signed-off-by Thomas Petazzoni <[email protected]>
Tested-by Matt Weber <[email protected]>
Quoted 19 lines
---
 package/libsemanage/libsemanage.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/libsemanage/libsemanage.mk +2 -2
index d554a33356..bbde50f49f 100644
@@ -31,7 +31,8 @@ HOST_LIBSEMANAGE_DEPENDENCIES = host-bison host-audit host-libsepol host-libseli
 HOST_LIBSEMANAGE_MAKE_OPTS += \
        $(HOST_CONFIGURE_OPTS) \
        PREFIX=$(HOST_DIR) \
-       SWIG_LIB="$(HOST_DIR)/share/swig/$(SWIG_VERSION)/"
+       SWIG_LIB="$(HOST_DIR)/share/swig/$(SWIG_VERSION)/" \
+       DEFAULT_SEMANAGE_CONF_LOCATION=$(HOST_DIR)/etc/selinux/semanage.conf
 
 ifeq ($(BR2_PACKAGE_PYTHON3),y)
 HOST_LIBSEMANAGE_DEPENDENCIES += host-python3
--
Quoted 2 lines

2.14.5

--
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / RC Linux Secure Platforms MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted Third Party Intellectual Property (TPIP) content must be encrypted and sent to matthew.weber at corp.rockwellcollins.com.

author Applied
#2 lore raw

PATCH 1/1 libsemanage: define installation location of semanage.conf for host

In reply to Thomas Petazzoni

Hello,

Quoted 16 lines · Thomas Petazzoni

When /etc/selinux/semanage.conf does not exist, libsemanage tries to overwrite it. For the target package, it works fine because $(DESTDIR) is taken into account.

However, for the host package, $(DESTDIR) is empty, and the location used for /etc/selinux/semanage.conf is not affected by $(PREFIX). This causes host-libsemanage to try to install /etc/selinux/semanage.conf, which obviously fails with:

test -f /etc/selinux/semanage.conf || install -m 644 -D semanage.conf /etc/selinux/semanage.conf
install: cannot create directory '/etc/selinux': Permission denied

To fix this, this commit passes DEFAULT_SEMANAGE_CONF_LOCATION in the make options when building/installing host-libsemanage, providing a path to semanage.conf that Buildroot can write to.

Quoted 8 lines

Fixes:

http://autobuild.buildroot.net/results/cd27e3c66274622d0c3dd5a601a36efb1bc45011/

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/libsemanage/libsemanage.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 libsemanage: define installation location of semanage.conf for host

In reply to Thomas Petazzoni
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

When /etc/selinux/semanage.conf does not exist, libsemanage tries to overwrite it. For the target package, it works fine because $(DESTDIR) is taken into account.

However, for the host package, $(DESTDIR) is empty, and the location used for /etc/selinux/semanage.conf is not affected by $(PREFIX). This causes host-libsemanage to try to install /etc/selinux/semanage.conf, which obviously fails with:

test -f /etc/selinux/semanage.conf || install -m 644 -D semanage.conf /etc/selinux/semanage.conf
install: cannot create directory '/etc/selinux': Permission denied

To fix this, this commit passes DEFAULT_SEMANAGE_CONF_LOCATION in the make options when building/installing host-libsemanage, providing a path to semanage.conf that Buildroot can write to.

Quoted 5 lines

Fixes:

http://autobuild.buildroot.net/results/cd27e3c66274622d0c3dd5a601a36efb1bc45011/

Signed-off-by Thomas Petazzoni <[email protected]>

Committed to 2018.02.x and 2018.08.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard