Skip to contentSkip to conversation

arm: dts: kirkwood: fix error in #sound-dai-cells size

PATCH New Rob Herring 3 participants 3 messages Mar 1, 2018 – Mar 5, 2018 Device tree bindings

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 arm: dts: kirkwood: fix error in #sound-dai-cells size

dtc now gives the following warning:

arch/arm/boot/dts/kirkwood-t5325.dtb: Warning (sound_dai_property): /sound/simple-audio-card,cpu:sound-dai: property size (4) too small for cell size 1

The binding documentation gives no indication what the cell size should be (which should be fixed too), so just assume 0 is fine as that is what the consumer has.

Cc Jason Cooper <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory Clement <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>
Signed-off-by Rob Herring <[email protected]>
---
 arch/arm/boot/dts/kirkwood.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/kirkwood.dtsi +1 -1
index eb2bf7409655..81c7eda2c442 100644
@@ -382,7 +382,7 @@
 
 		audio0: audio-controller at a0000 {
 			compatible = "marvell,kirkwood-audio";
-			#sound-dai-cells = <1>;
+			#sound-dai-cells = <0>;
 			reg = <0xa0000 0x2210>;
 			interrupts = <24>;
 			clocks = <&gate_clk 9>;
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 arm: dts: kirkwood: fix error in #sound-dai-cells size

Quoted 8 lines · Rob Herring

dtc now gives the following warning:

arch/arm/boot/dts/kirkwood-t5325.dtb: Warning (sound_dai_property): /sound/simple-audio-card,cpu:sound-dai: property size (4) too small for cell size 1

The binding documentation gives no indication what the cell size should be (which should be fixed too), so just assume 0 is fine as that is what the consumer has.

Quoted 5 lines
Cc Jason Cooper <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory Clement <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>
Signed-off-by Rob Herring <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>

Andrew

#2 lore raw

PATCH 1/1 arm: dts: kirkwood: fix error in #sound-dai-cells size

In reply to Rob Herring

Hi Rob,

Quoted 8 lines · Rob Herring

dtc now gives the following warning:

arch/arm/boot/dts/kirkwood-t5325.dtb: Warning (sound_dai_property): /sound/simple-audio-card,cpu:sound-dai: property size (4) too small for cell size 1

The binding documentation gives no indication what the cell size should be (which should be fixed too), so just assume 0 is fine as that is what the consumer has.

Quoted 5 lines
Cc Jason Cooper <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory Clement <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>
Signed-off-by Rob Herring <[email protected]>

Applied on mvebu/dt with the reviewed-by flag from Andrew.

Thanks,

Gregory

Quoted 25 lines
---
 arch/arm/boot/dts/kirkwood.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/kirkwood.dtsi +1 -1
index eb2bf7409655..81c7eda2c442 100644
@@ -382,7 +382,7 @@
 
 		audio0: audio-controller at a0000 {
 			compatible = "marvell,kirkwood-audio";
-			#sound-dai-cells = <1>;
+			#sound-dai-cells = <0>;
 			reg = <0xa0000 0x2210>;
 			interrupts = <24>;
 			clocks = <&gate_clk 9>;
Signature · 7 lines
2.14.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 3 lines
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com