lttng-babeltrace: fix build failure on gcc14
PATCH v2 1/1 lttng-babeltrace: fix build failure on gcc14
The gcc14 machine has a moderately old host gcc, which was causing a recurrent build failure of host-lttng-babeltrace:
http://autobuild.buildroot.org/results/492/49216052c161874f41738e41e6e0c89a6dd04000/build-end.log
This commit adds a patch to fix this build failure, related to the access of the ULLONG_MAX define on compilers that did not default to the C99 variant of the C language.
---
v2:
Also autoreconf the target package, for consistency.
---
...beltrace-01-no-posix-fallocate-in-uclibc.patch} | 0
...tng-babeltrace-02-fix-build-old-compilers.patch | 27 ++++++++++++++++++++
package/lttng-babeltrace/lttng-babeltrace.mk | 4 +++
3 files changed, 31 insertions(+)
rename package/lttng-babeltrace/{lttng-babeltrace-no-posix-fallocate-in-uclibc.patch => lttng-babeltrace-01-no-posix-fallocate-in-uclibc.patch} (100%)
create mode 100644 package/lttng-babeltrace/lttng-babeltrace-02-fix-build-old-compilers.patchpackage/lttng-babeltrace/lttng-babeltrace-01-no-posix-fallocate-in-uclibc.patch renamed from package/lttng-babeltrace/lttng-babeltrace-no-posix-fallocate-in-uclibc.patch +0 -0
package/lttng-babeltrace/lttng-babeltrace-02-fix-build-old-compilers.patch new file +27 -0
@@ -0,0 +1,27 @@ +Support old compilers + +Some old compilers do not use C99 as their default C language variant, +for example gcc 4.3.x, which is used on some old machines. When such a +compiler is used, by default, ULLONG_MAX is not visible. Adding +-std=gnu99 is needed to make this definition visible. + +In autoconf speak, this translates into the need of using +AC_PROC_CC_STDC instead of AC_PROG_CC. See +http://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/C-Compiler.html +for more details. + +Signed-off-by: Thomas Petazzoni <[email protected]> + +Index: b/configure.ac +=================================================================== +--- a/configure.ac ++++ b/configure.ac +@@ -17,7 +17,7 @@ + AC_SYS_LARGEFILE + + # Checks for programs. +-AC_PROG_CC ++AC_PROG_CC_STDC + AC_PROG_MAKE_SET + LT_INIT + AC_PROG_YACC
package/lttng-babeltrace/lttng-babeltrace.mk +4 -0
@@ -4,5 +4,9 @@ LTTNG_BABELTRACE_SOURCE = babeltrace-$(LTTNG_BABELTRACE_VERSION).tar.bz2 LTTNG_BABELTRACE_DEPENDENCIES = popt util-linux libglib2 +# One patch touches configure.ac +LTTNG_BABELTRACE_AUTORECONF = YES +HOST_LTTNG_BABELTRACE_AUTORECONF = YES + $(eval $(autotools-package)) $(eval $(host-autotools-package))
Signature · 1 line
1.7.9.5
PATCH v2 1/1 lttng-babeltrace: fix build failure on gcc14
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Thomas" == Thomas Petazzoni <[email protected]> writes:
Thomas> The gcc14 machine has a moderately old host gcc, which was causing a Thomas> recurrent build failure of host-lttng-babeltrace:
Thomas> http://autobuild.buildroot.org/results/492/49216052c161874f41738e41e6e0c89a6dd04000/build-end.log
Thomas> This commit adds a patch to fix this build failure, related to the Thomas> access of the ULLONG_MAX define on compilers that did not default to Thomas> the C99 variant of the C language.
Thomas> Signed-off-by: Thomas Petazzoni <[email protected]> Thomas> ---
Thomas> v2:
Thomas> Also autoreconf the target package, for consistency.
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard