target-finalize: fix libthread_db strip fix
PATCH 1/1 target-finalize: fix libthread_db strip fix
The attempt to fix libthread_db for some targets broke others. If you want to match more libs, you shouldn't do so by breaking others. The correct SONAME is libthread_db.so.#.
--- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Makefile +1 -1
@@ -426,7 +426,7 @@ endif ifeq ($(BR2_INSTALL_ELF_CLEANUP),y) PATH="$(HOST_PATH)" toolchain/trim-libs.sh "$(TARGET_DIR)" endif - find $(TARGET_DIR) -type f -perm +111 '!' -name 'libthread_db*.so' | \ + find $(TARGET_DIR) -type f -perm +111 '!' -name 'libthread_db*.so*' | \ xargs $(STRIPCMD) 2>/dev/null || true find $(TARGET_DIR)/lib/modules -type f -name '*.ko' | \ xargs -r $(STRIPCMD) $(STRIP_STRIP_UNNEEDED)
Signature · 1 line
1.7.3.2
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Mike> The attempt to fix libthread_db for some targets broke others. If you Mike> want to match more libs, you shouldn't do so by breaking others. The Mike> correct SONAME is libthread_db.so.#.
Out of interest, what targets got broken, and how are the libthread_db files called?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 7 lines · On Sunday, November 28, 2010 05:09:06 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Mike> The attempt to fix
libthread_dbfor some targets broke others. If
you Mike> want to match more libs, you shouldn't do so by breaking others.
The Mike> correct SONAME is libthread_db.so.#.Out of interest, what targets got broken, and how are the
libthread_dbfiles called?
i only care about Blackin targets. we dont waste space on symlinks and only install SONAMEs.
btw, why is your quoting style so screwed up ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101128/85d6ff53/attachment.pgp>
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Quoted 1 line · Mike> On Sunday, November 28, 2010 05:09:06 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Mike> The attempt to fix libthread_db for some targets broke others. If
Quoted 5 lines
Quoted 5 lines
you Mike> want to match more libs, you shouldn't do so by breaking others. The Mike> correct SONAME is libthread_db.so.#.
Out of interest, what targets got broken, and how are the
libthread_dbfiles called?
Mike> i only care about Blackin targets. we dont waste space on Mike> symlinks and only install SONAMEs.
Ok, I naturally don't share this narrow viewpoint. It's not a use case for any of the supported archs, but ok, it's easy to support.
Again, I know this is probably just you being you, but do take care of your choice of words. To me, this commit message sounds quite aggressive, as if you're upset that Javier's fix broke your nonstandard/unsupported/undocumented setup, which is ofcause pretty silly considering that he clearly spent effort on verifying it with multiple toolchains and the original commit didn't even work for the default configuration.
Anyway, I've fixed up your commit so it applied to master, and committed with a somewhat reworked commit message.
Mike> btw, why is your quoting style so screwed up ?
It's just standard emacs supercite, like I've used for the last 10yrs or so. I find it handy in mailing lists when several people participate in a discussion.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 17 lines · On Sunday, November 28, 2010 16:14:26 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Quoted 1 line · Mike> On Sunday, November 28, 2010 05:09:06 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Mike> The attempt to fix
libthread_dbfor some targets broke others. IfQuoted 5 lines
Quoted 5 lines
you Mike> want to match more libs, you shouldn't do so by breaking others. The Mike> correct SONAME is libthread_db.so.#.
Out of interest, what targets got broken, and how are the
libthread_dbfiles called?Mike> i only care about Blackin targets. we dont waste space on Mike> symlinks and only install SONAMEs.
Ok, I naturally don't share this narrow viewpoint. It's not a use case for any of the supported archs, but ok, it's easy to support.
Quoted 7 lines
Again, I know this is probably just you being you, but do take care of your choice of words. To me, this commit message sounds quite aggressive, as if you're upset that Javier's fix broke your nonstandard/unsupported/undocumented setup, which is ofcause pretty silly considering that he clearly spent effort on verifying it with multiple toolchains and the original commit didn't even work for the default configuration.
my setup isnt any of these things. i've been pushing patches to you but they havent been merged yet (i wonder when/if they will be). ive seen other people doing the same thing with other distros/arches as well because it makes sense. verifying with two arm toolchains is grasping at "multiple toolchains".
Quoted 5 lines
Mike> btw, why is your quoting style so screwed up ?
It's just standard emacs supercite, like I've used for the last 10yrs or so. I find it handy in mailing lists when several people participate in a discussion.
fortunately ive only seen two people (including you) using this style. it
just falls apart with replies.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101128/d065f0a6/attachment.pgp>
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Hi,
Mike> my setup isnt any of these things. i've been pushing patches to Mike> you but they havent been merged yet (i wonder when/if they will Mike> be).
Most of those were feature patches rather than regression fixes, so I won't look at those until post-2010.11.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 7 lines · On Monday, November 29, 2010 02:53:25 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Mike> my setup isnt any of these things. i've been pushing patches to Mike> you but they havent been merged yet (i wonder when/if they will Mike> be).
Most of those were feature patches rather than regression fixes, so I won't look at those until post-2010.11.
which would be nice to know ... from my point of view, these are simply being ignored with no feedback. but perhaps this gets back to the buildroot doc not really covering any dev/release processes yet.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101129/fdf9e69d/attachment.pgp>
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Hi,
Mike> which would be nice to know ... from my point of view, these are Mike> simply being ignored with no feedback. but perhaps this gets Mike> back to the buildroot doc not really covering any dev/release Mike> processes yet.
True. We follow the same general structure as a bunch of other projects (E.G. Linux, u-boot, barebox, ..).
Care to submit a doc patch?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 8 lines · On Monday, November 29, 2010 06:41:40 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Mike> which would be nice to know ... from my point of view, these are Mike> simply being ignored with no feedback. but perhaps this gets Mike> back to the buildroot doc not really covering any dev/release Mike> processes yet.
True. We follow the same general structure as a bunch of other projects (E.G. Linux, u-boot, barebox, ..).
by "structure", i'm guessing you mean "release/development process" ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101129/b34e914c/attachment.pgp>
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Quoted 1 line · Mike> On Monday, November 29, 2010 06:41:40 Peter Korsgaard wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Mike> which would be nice to know ... from my point of view, these are Mike> simply being ignored with no feedback. but perhaps this gets Mike> back to the buildroot doc not really covering any dev/release Mike> processes yet.
Quoted 3 lines
Quoted 3 lines
True. We follow the same general structure as a bunch of other projects (E.G. Linux, u-boot, barebox, ..).
Mike> by "structure", i'm guessing you mean "release/development process" ?
Yes. There's naturally some scale differences, but we follow the general process:
- Releases every 3 months
- Only the maintainer (me) has direct commit access
- A period (2 months) after a release the tree is open for new features, then -rc1 is released and only fixes are accepted.
- We use similar commit msg structure and signed-off-by / acked-by's
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 7 lines · On Monday, November 29, 2010 16:14:47 Peter Korsgaard wrote:
Yes. There's naturally some scale differences, but we follow the general process:
- Releases every 3 months
- Only the maintainer (me) has direct commit access
- A period (2 months) after a release the tree is open for new features, then -rc1 is released and only fixes are accepted.
OK, i'll adjust my merge expectations accordingly
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101129/dc45dc85/attachment-0001.pgp>
PATCH 1/1 target-finalize: fix libthread_db strip fix
In reply to Peter KorsgaardQuoted 3 lines · On Sunday, November 28, 2010 16:14:26 Peter Korsgaard wrote:
Again, I know this is probably just you being you, but do take care of your choice of words. To me, this commit message sounds quite aggressive, as if you're upset that Javier's fix broke your
truthfully, i am a bit annoyed that Javier or you didnt simply CC me and ask before breaking things. it isnt like my e-mail is hidden or i'm AFK or otherwise hard to reach.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101128/d7fd9376/attachment.pgp>
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Quoted 3 lines · Mike> On Sunday, November 28, 2010 16:14:26 Peter Korsgaard wrote:
Quoted 3 lines
Again, I know this is probably just you being you, but do take care of your choice of words. To me, this commit message sounds quite aggressive, as if you're upset that Javier's fix broke your
Mike> truthfully, i am a bit annoyed that Javier or you didnt simply CC Mike> me and ask before breaking things. it isnt like my e-mail is Mike> hidden or i'm AFK or otherwise hard to reach. -mike
Correct. Buildroot people are normally subscribed to the BR list, but it would have been good if you were CC'ed. The patch got committed fast because it fixed real problems (E.G. it didn't work for any BR configs) and we're just about to release.
Anyway, no harm done - Now both configurations work.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 2 lines · On Monday, November 29, 2010 02:57:01 Peter Korsgaard wrote:
The patch got committed fast because it fixed real problems (E.G. it didn't work for any BR configs)
to be clear, there was no change in behavior before and after my first patch
for people using symlinks to SONAMEs. the file was always stripped before,
and it was always stripped after if the SONAME was a symlink.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101129/4d62b065/attachment.pgp>
PATCH 1/1 target-finalize: fix libthread_db strip fix
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Mike" == Mike Frysinger <[email protected]> writes:
Quoted 2 lines · Mike> On Monday, November 29, 2010 02:57:01 Peter Korsgaard wrote:
Quoted 2 lines
The patch got committed fast because it fixed real problems (E.G. it didn't work for any BR configs)
Mike> to be clear, there was no change in behavior before and after my Mike> first patch for people using symlinks to SONAMEs. the file was Mike> always stripped before, and it was always stripped after if the Mike> SONAME was a symlink.
True, but that behaviour was not in sync with the commit message, leading to the fix.
Signature · 1 line
Bye, Peter Korsgaard