Skip to contentSkip to conversation

nilfs2: add reader's lock for cno in nilfs_ioctl_sync

PATCH In review Jiro SEKIBA 2 participants 2 messages Feb 20, 2010 1 message not in the archive NILFS2 filesystem

lore
Share & tools
lore

Jiro SEKIBA

author
#0 lore raw

PATCH 1/1 nilfs2: add reader's lock for cno in nilfs_ioctl_sync

Hi,

This adds reader's lock for the_nilfs->cno in nilfs_ioctl_sync, for the_nilfs->cno should be proctected by segctor_sem when reading.

Signed-off-by Jiro SEKIBA <[email protected]>
---
 fs/nilfs2/ioctl.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
fs/nilfs2/ioctl.c +5 -1
index d6b2b83..32d5103 100644
@@ -575,13 +575,17 @@ static int nilfs_ioctl_sync(struct inode *inode, struct file *filp,
 {
 	__u64 cno;
 	int ret;
+	struct the_nilfs *nilfs;
 
 	ret = nilfs_construct_segment(inode->i_sb);
 	if (ret < 0)
 		return ret;
 
 	if (argp != NULL) {
-		cno = NILFS_SB(inode->i_sb)->s_nilfs->ns_cno - 1;
+		nilfs = NILFS_SB(inode->i_sb)->s_nilfs;
+		down_read(&nilfs->ns_segctor_sem);
+		cno = nilfs->ns_cno - 1;
+		up_read(&nilfs->ns_segctor_sem);
 		if (copy_to_user(argp, &cno, sizeof(cno)))
 			return -EFAULT;
 	}
Signature · 8 lines
1.5.6.5



--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 87hbpc2nfu.wl%[email protected]

#2 lore raw
Quoted 35 lines · Jiro SEKIBA

Hi,

This adds reader's lock for the_nilfs->cno in nilfs_ioctl_sync, for the_nilfs->cno should be proctected by segctor_sem when reading.

Signed-off-by Jiro SEKIBA <[email protected]>
---
 fs/nilfs2/ioctl.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
fs/nilfs2/ioctl.c +5 -1
index d6b2b83..32d5103 100644
@@ -575,13 +575,17 @@ static int nilfs_ioctl_sync(struct inode *inode, struct file *filp,
 {
 	__u64 cno;
 	int ret;
+	struct the_nilfs *nilfs;
 
 	ret = nilfs_construct_segment(inode->i_sb);
 	if (ret < 0)
 		return ret;
 
 	if (argp != NULL) {
-		cno = NILFS_SB(inode->i_sb)->s_nilfs->ns_cno - 1;
+		nilfs = NILFS_SB(inode->i_sb)->s_nilfs;
+		down_read(&nilfs->ns_segctor_sem);
+		cno = nilfs->ns_cno - 1;
+		up_read(&nilfs->ns_segctor_sem);
 		if (copy_to_user(argp, &cno, sizeof(cno)))
 			return -EFAULT;
 	}
Signature · 1 line
1.5.6.5

Right, this should be applied.

Thanks.

Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html