Skip to contentSkip to conversation

gst-plugins-good: make new dependency-less plugins configurable

PATCH New Sven Neumann 3 participants 11 messages Oct 19, 2009 – Oct 21, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 gst-plugins-good: make new dependency-less plugins configurable

gst-plugins-good gained a number of dependency-less plugins with the last update. This commit makes them configurable in buildroot.

---
 package/multimedia/gst-plugins-good/Config.in      |   16 ++++++++-
 .../gst-plugins-good/gst-plugins-good.mk           |   32 +++++++++++++++++--
 2 files changed, 42 insertions(+), 6 deletions(-)
package/multimedia/gst-plugins-good/Config.in +14 -2
index b96f15d..fdb6646 100644
@@ -61,8 +61,11 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_AVI
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_CUTTER
 	bool "cutter"
 
-config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEBUG
-	bool "debug"
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEBUGUTILS
+	bool "debugutils"
+
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEINTERLACE
+	bool "deinterlace"
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_EFFECTV
 	bool "effectv"
@@ -70,6 +73,9 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_EFFECTV
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_EQUALIZER
 	bool "equalizer"
 
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLV
+	bool "flv"
+
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ID3DEMUX
 	bool "id3demux (*.mp3 audio)"
 
@@ -115,6 +121,9 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_REPLAYGAIN
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_RTP
 	bool "rtp"
 
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_RTPMANAGER
+	bool "rtpmanager"
+
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_RTSP
 	bool "rtsp"
 
@@ -143,6 +152,9 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_WAVPARSE
 	bool "wavparse (*.wav audio)"
 	default y
 
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_Y4M
+	bool "y4m"
+
 comment "plugins with external dependencies"
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ANNODEX
package/multimedia/gst-plugins-good/gst-plugins-good.mk +28 -4
index 4f4861b..5dcf64a 100644
@@ -10,8 +10,8 @@ GST_PLUGINS_GOOD_LIBTOOL_PATCH = NO
 
 GST_PLUGINS_GOOD_CONF_OPT = \
 		$(DISABLE_NLS) \
+		--disable-debug \
 		--disable-examples \
-		--disable-directdraw \
 		--disable-directsound \
 		--disable-sunaudio \
 		--disable-osx_audio \
@@ -105,10 +105,16 @@ else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-cutter
 endif
 
-ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEBUG),y)
-GST_PLUGINS_GOOD_CONF_OPT += --enable-debug
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEBUGUTILS),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-debugutils
 else
-GST_PLUGINS_GOOD_CONF_OPT += --disable-debug
+GST_PLUGINS_GOOD_CONF_OPT += --disable-debugutils
+endif
+
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEINTERLACE),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-deinterlace
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-deinterlace
 endif
 
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_EFFECTV),y)
@@ -123,6 +129,12 @@ else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-equalizer
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLV),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-flv
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-flv
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ID3DEMUX),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-id3demux
 else
@@ -213,6 +225,12 @@ else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-rtp
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_RTPMANAGER),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-rtpmanager
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-rtpmanager
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_RTSP),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-rtsp
 else
@@ -267,6 +285,12 @@ else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-wavparse
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_Y4m),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-y4m
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-y4m
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ANNODEX),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-annodex
 GST_PLUGINS_GOOD_DEPENDENCIES += libxml2
Signature · 1 line
1.6.5
#1 lore raw

PATCH 2/2 gst-plugins-good: make new dependency-less plugins configurable

Sven Neumann, 19.10.2009:

package/multimedia/gst-plugins-good/Config.in config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_WAVPARSE

Quoted 5 lines
package/multimedia/gst-plugins-good/Config.in +4 -0
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_Y4M
+	bool "y4m"
+
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_Y4m),y)

Typo: must be an uppercase M in Y4m.

#2 lore raw

PATCH 1/1 gst-plugins-good: make new dependency-less plugins configurable

gst-plugins-good gained a number of dependency-less plugins with the last update. This commit makes them configurable in buildroot.

---
 package/multimedia/gst-plugins-good/Config.in      |   16 ++++++++-
 .../gst-plugins-good/gst-plugins-good.mk           |   32 +++++++++++++++++--
 2 files changed, 42 insertions(+), 6 deletions(-)
package/multimedia/gst-plugins-good/Config.in +14 -2
index b96f15d..fdb6646 100644
@@ -61,8 +61,11 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_AVI
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_CUTTER
 	bool "cutter"
 
-config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEBUG
-	bool "debug"
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEBUGUTILS
+	bool "debugutils"
+
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEINTERLACE
+	bool "deinterlace"
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_EFFECTV
 	bool "effectv"
@@ -70,6 +73,9 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_EFFECTV
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_EQUALIZER
 	bool "equalizer"
 
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLV
+	bool "flv"
+
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ID3DEMUX
 	bool "id3demux (*.mp3 audio)"
 
@@ -115,6 +121,9 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_REPLAYGAIN
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_RTP
 	bool "rtp"
 
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_RTPMANAGER
+	bool "rtpmanager"
+
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_RTSP
 	bool "rtsp"
 
@@ -143,6 +152,9 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_WAVPARSE
 	bool "wavparse (*.wav audio)"
 	default y
 
+config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_Y4M
+	bool "y4m"
+
 comment "plugins with external dependencies"
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ANNODEX
package/multimedia/gst-plugins-good/gst-plugins-good.mk +28 -4
index 4f4861b..7b6f02b 100644
@@ -10,8 +10,8 @@ GST_PLUGINS_GOOD_LIBTOOL_PATCH = NO
 
 GST_PLUGINS_GOOD_CONF_OPT = \
 		$(DISABLE_NLS) \
+		--disable-debug \
 		--disable-examples \
-		--disable-directdraw \
 		--disable-directsound \
 		--disable-sunaudio \
 		--disable-osx_audio \
@@ -105,10 +105,16 @@ else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-cutter
 endif
 
-ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEBUG),y)
-GST_PLUGINS_GOOD_CONF_OPT += --enable-debug
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEBUGUTILS),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-debugutils
 else
-GST_PLUGINS_GOOD_CONF_OPT += --disable-debug
+GST_PLUGINS_GOOD_CONF_OPT += --disable-debugutils
+endif
+
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_DEINTERLACE),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-deinterlace
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-deinterlace
 endif
 
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_EFFECTV),y)
@@ -123,6 +129,12 @@ else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-equalizer
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_FLV),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-flv
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-flv
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ID3DEMUX),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-id3demux
 else
@@ -213,6 +225,12 @@ else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-rtp
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_RTPMANAGER),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-rtpmanager
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-rtpmanager
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_RTSP),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-rtsp
 else
@@ -267,6 +285,12 @@ else
 GST_PLUGINS_GOOD_CONF_OPT += --disable-wavparse
 endif
 
+ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_Y4M),y)
+GST_PLUGINS_GOOD_CONF_OPT += --enable-y4m
+else
+GST_PLUGINS_GOOD_CONF_OPT += --disable-y4m
+endif
+
 ifeq ($(BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ANNODEX),y)
 GST_PLUGINS_GOOD_CONF_OPT += --enable-annodex
 GST_PLUGINS_GOOD_DEPENDENCIES += libxml2
Signature · 1 line
1.6.5
#3 lore raw

PATCH 1/1 gst-plugins-good: make new dependency-less plugins configurable

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Sven> gst-plugins-good gained a number of dependency-less plugins with Sven> the last update. This commit makes them configurable in buildroot.

Sven> GST_PLUGINS_GOOD_CONF_OPT = \
Sven> $(DISABLE_NLS) \
Sven> + --disable-debug \
Sven> --disable-examples \
Sven> - --disable-directdraw \

Why?

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 gst-plugins-good: make new dependency-less plugins configurable

Quoted 10 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Sven> gst-plugins-good gained a number of dependency-less plugins with Sven> the last update. This commit makes them configurable in buildroot.

Sven> GST_PLUGINS_GOOD_CONF_OPT = \
Sven> $(DISABLE_NLS) \
Sven> + --disable-debug \
Sven> --disable-examples \
Sven> - --disable-directdraw \

Hmm, perhaps directdraw should become an option as well, but I thought it's not really interesting for the buildroot target audience.

--disable-debug should perhaps be configurable or depend on BR2_ENABLE_DEBUG ?

Sven

#5 lore raw

PATCH 1/1 gst-plugins-good: make new dependency-less plugins configurable

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Sven> GST_PLUGINS_GOOD_CONF_OPT = \
Sven> $(DISABLE_NLS) \
Sven> + --disable-debug \
Sven> --disable-examples \
Sven> - --disable-directdraw \

Sven> Hmm, perhaps directdraw should become an option as well, but I thought Sven> it's not really interesting for the buildroot target audience.

Is that directdraw as in the component of Microsoft DirectX? That indeed doesn't seem like something we would want to enable. Why did you remove the line?

Sven> --disable-debug should perhaps be configurable or depend on Sven> BR2_ENABLE_DEBUG ?

That might be an idea, yes.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/1 gst-plugins-good: make new dependency-less plugins configurable

Quoted 8 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Sven> GST_PLUGINS_GOOD_CONF_OPT = \
Sven> $(DISABLE_NLS) \
Sven> + --disable-debug \
Sven> --disable-examples \
Sven> - --disable-directdraw \

Quoted 6 lines

Sven> Hmm, perhaps directdraw should become an option as well, but I thought Sven> it's not really interesting for the buildroot target audience.

Is that directdraw as in the component of Microsoft DirectX? That indeed doesn't seem like something we would want to enable. Why did you remove the line?

Ah right, now I rememeber. It is not any longer a valid configure option for the new release. So I removed it.

Sven

#7 lore raw

PATCH 1/1 gst-plugins-good: make new dependency-less plugins configurable

Sven Neumann, 21.10.2009:

Quoted 12 lines · Peter Korsgaard
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Sven> GST_PLUGINS_GOOD_CONF_OPT = \
Sven> $(DISABLE_NLS) \
Sven> + --disable-debug \
Sven> --disable-examples \
Sven> - --disable-directdraw \

Sven> Hmm, perhaps directdraw should become an option as well, but I thought Sven> it's not really interesting for the buildroot target audience.

Quoted 6 lines
Quoted 3 lines

Is that directdraw as in the component of Microsoft DirectX? That indeed doesn't seem like something we would want to enable. Why did you remove the line?

Ah right, now I rememeber. It is not any longer a valid configure option for the new release. So I removed it.

Yes, directdraw moved from gst-plugins-good to gst-plugins-bad. Would be nice to add this to the commit message then as well as the rename from debug to debugutils to avoid confusion.

Markus

#8 lore raw

PATCH 1/1 gst-plugins-good: make new dependency-less plugins configurable

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Markus" == Markus Heidelberg <[email protected]> writes:

Hi,

Quoted 2 lines
Quoted 2 lines

Ah right, now I rememeber. It is not any longer a valid configure option for the new release. So I removed it.

Markus> Yes, directdraw moved from gst-plugins-good to gst-plugins-bad. Markus> Would be nice to add this to the commit message then as well as Markus> the rename from debug to debugutils to avoid confusion.

I agree, but I already committed and pushed that one - For next time please.

Signature · 1 line
Bye, Peter Korsgaard
#9 lore raw

PATCH 1/1 gst-plugins-good: make new dependency-less plugins configurable

Quoted 7 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Markus" == Markus Heidelberg <[email protected]> writes:

Markus> Yes, directdraw moved from gst-plugins-good to gst-plugins-bad. Markus> Would be nice to add this to the commit message then as well as Markus> the rename from debug to debugutils to avoid confusion.

I agree, but I already committed and pushed that one - For next time please.

I'll send a patch for gst-plugins-bad soon and will try to be more careful about the commit messages. Thanks for your review.

Sven

#10 lore raw

PATCH 1/1 gst-plugins-good: make new dependency-less plugins configurable

In reply to Sven Neumann
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sven" == Sven Neumann <[email protected]> writes:

Hi,

Quoted 3 lines
Quoted 3 lines

Is that directdraw as in the component of Microsoft DirectX? That indeed doesn't seem like something we would want to enable. Why did you remove the line?

Sven> Ah right, now I rememeber. It is not any longer a valid configure Sven> option for the new release. So I removed it.

Ok, committed - Thanks.

Signature · 1 line
Bye, Peter Korsgaard