Skip to contentSkip to conversation

ALSA: hda/realtek: Add quirk for Legion S7 15IMH

PATCH Applied Eric Naim 2 participants 5 messages Apr 13 – Apr 22

Subsystems (2)
lore
Share & tools
lore

Eric Naim

author
#0 lore raw

PATCH 1/1 ALSA: hda/realtek: Add quirk for Legion S7 15IMH

Fix speaker output on the Lenovo Legion S7 15IMH05.

---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)
sound/hda/codecs/realtek/alc269.c +1 -0
index 45f9d6487388..ae74e1b69eb3 100644
@@ -7605,6 +7605,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x3801, "Lenovo Yoga9 14IAP7", ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
 	HDA_CODEC_QUIRK(0x17aa, 0x3802, "DuetITL 2021", ALC287_FIXUP_YOGA7_14ITL_SPEAKERS),
 	SND_PCI_QUIRK(0x17aa, 0x3802, "Lenovo Yoga Pro 9 14IRP8", ALC287_FIXUP_TAS2781_I2C),
+	SND_PCI_QUIRK(0x17aa, 0x3811, "Legion S7 15IMH05", ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS),
 	SND_PCI_QUIRK(0x17aa, 0x3813, "Legion 7i 15IMHG05", ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS),
 	SND_PCI_QUIRK(0x17aa, 0x3818, "Lenovo C940 / Yoga Duet 7", ALC298_FIXUP_LENOVO_C940_DUET7),
 	SND_PCI_QUIRK(0x17aa, 0x3819, "Lenovo 13s Gen2 ITL", ALC287_FIXUP_13S_GEN2_SPEAKERS),
Signature · 1 line
2.53.0
author
#2 lore raw
Quoted 5 lines · Takashi Iwai
Quoted 3 lines · Eric Naim

Fix speaker output on the Lenovo Legion S7 15IMH05.

Quoted 7 lines
Quoted 2 lines

Thanks, applied now.

Takashi

Sorry Takashi, can you remove this from your tree? I seem to have gotten the PID wrong for this device. I'll follow up with a v2 or fixup once I've confirmed I got the correct PID. Let me know which of the two resolutions you prefer.

Signature · 2 lines
Regards,
  Eric
#3 lore raw
Quoted 13 lines · Eric Naim
Quoted 11 lines · Takashi Iwai
Quoted 5 lines · Eric Naim

Fix speaker output on the Lenovo Legion S7 15IMH05.

Thanks, applied now.

Quoted 6 lines
Quoted 1 line

Takashi

Sorry Takashi, can you remove this from your tree? I seem to have gotten the PID wrong for this device. I'll follow up with a v2 or fixup once I've confirmed I got the correct PID. Let me know which of the two resolutions you prefer.

As the tree was published, could you rather a correction patch on the top? Put Fixes tag for pointing to the corrected commit.

thanks,

Takashi

author
#4 lore raw
Quoted 22 lines · Takashi Iwai
Quoted 13 lines · Eric Naim
Quoted 11 lines · Takashi Iwai
Quoted 5 lines · Eric Naim

Fix speaker output on the Lenovo Legion S7 15IMH05.

Thanks, applied now.

Quoted 6 lines
Quoted 1 line

Takashi

Sorry Takashi, can you remove this from your tree? I seem to have gotten the PID wrong for this device. I'll follow up with a v2 or fixup once I've confirmed I got the correct PID. Let me know which of the two resolutions you prefer.

Quoted 7 lines

As the tree was published, could you rather a correction patch on the top? Put Fixes tag for pointing to the corrected commit.

thanks,

Takashi

Alright, I finally got a reply from the user that requested this from me. After looking at [1] and reading through [2], it looks like the HDA verbs for ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS are just copied from ALC287_FIXUP_YOGA7_14ITL_SPEAKERS, and is different from the original patch that was tested in [2] and the provided verbs from [1].

Cameron, you submitted the original patch for this. Can you confirm?

Attached is my proposal fix for the ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS quirk. I'll get the reporter to test this and report back.

[1]
https://github.com/thiagotei/linux-realtek-alc287/blob/2a3a57c14adf3313d4c14df1a0a8a8bd3f544369/lenovo-legion/verbs-legion.txt

[2] https://bugzilla.kernel.org/show_bug.cgi?id=208555

Signature · 2 lines
Regards,
  Eric
sound/hda/codecs/realtek/alc269.c +0 -6
index ae74e1b69eb3..1f174b70ec57 100644
@@ -6107,12 +6107,6 @@ static const struct hda_fixup alc269_fixups[] = {
 			 { 0x20, AC_VERB_SET_COEF_INDEX, 0x24 },
 			 { 0x20, AC_VERB_SET_PROC_COEF, 0x41 },
 
-			 { 0x20, AC_VERB_SET_COEF_INDEX, 0x26 },
-			 { 0x20, AC_VERB_SET_PROC_COEF, 0xc },
-			 { 0x20, AC_VERB_SET_PROC_COEF, 0x0 },
-			 { 0x20, AC_VERB_SET_PROC_COEF, 0x1a },
-			 { 0x20, AC_VERB_SET_PROC_COEF, 0xb020 },
-
 			 { 0x20, AC_VERB_SET_COEF_INDEX, 0x26 },
 			 { 0x20, AC_VERB_SET_PROC_COEF, 0x2 },
 			 { 0x20, AC_VERB_SET_PROC_COEF, 0x0 },