mtd: sm_ftl: use strscpy() in sm_attr_show()
PATCH 1/1 mtd: sm_ftl: use strscpy() in sm_attr_show()
In sm_ftl.c, the sm_attr_show() function currently copies attribute data using:
strncpy(buf, sm_attr->data, sm_attr->len);
return sm_attr->len;Using strncpy() can be unsafe because it does not guarantee a NUL terminator if the source length equals the buffer size. Although sm_attr->data comes from internal structures and is NUL-terminated, it is cleaner and safer to use strscpy(), which guarantees NUL termination and avoids zero-padding.
The destination buffer is PAGE_SIZE bytes, which is sufficient to hold sm_attr->data without truncation. The return value of strscpy() matches the expected behavior of sm_attr_show().
Replace the strncpy() call with:
return strscpy(buf, sm_attr->data, PAGE_SIZE);
--- drivers/mtd/sm_ftl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mtd/sm_ftl.c +1 -2
@@ -44,8 +44,7 @@ static ssize_t sm_attr_show(struct device *dev, struct device_attribute *attr,struct sm_sysfs_attribute *sm_attr = container_of(attr, struct sm_sysfs_attribute, dev_attr); -strncpy (buf, sm_attr->data, sm_attr->len); -return sm_attr->len; +return strscpy (buf, sm_attr->data,PAGE_SIZE ); }
Signature · 1 line
2.43.0
Miquel Raynal
maintainerHello,
Quoted 16 lines · Dharanitharan R
In
sm_ftl.c, thesm_attr_show()function currently copies attribute data using:strncpy(buf, sm_attr->data, sm_attr->len); return sm_attr->len;Using
strncpy()can be unsafe because it does not guarantee a NUL terminator if the source length equals the buffer size. Althoughsm_attr->datacomes from internal structures and is NUL-terminated, it is cleaner and safer to usestrscpy(), which guarantees NUL termination and avoids zero-padding.The destination buffer is
PAGE_SIZEbytes, which is sufficient to holdsm_attr->datawithout truncation. The return value ofstrscpy()matches the expected behavior ofsm_attr_show().
Quoted 5 lines
Replace the
strncpy()call with:return strscpy(buf, sm_attr->data, PAGE_SIZE);Signed-off-by Dharanitharan R <[email protected]>
This commit won't apply, please resend based on v6.19-rc1.
Thanks,
Miquèl