Skip to contentSkip to conversation

ALSA: cs4281: Send the PCM period elapsed notification properly

PATCH Applied Chandra Mohan Sundar 2 participants 2 messages Sep 6, 2025 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: cs4281: Send the PCM period elapsed notification properly

As part of spin lock code cleanup using guard(), a new variable (period_elapsed) was introduced. However this variable is never set, causing period elapsed notification to be not sent.

Set the value of period_elapsed appropiately.

This issue was reported by static coverity analyzer.

Fixes 7a5127c2c8a5a ("ALSA: cs4281: Use guard() for spin locks")
---
 sound/pci/cs4281.c | 1 +
 1 file changed, 1 insertion(+)
sound/pci/cs4281.c +1 -0
index c519fb9cdd1e..d00b2c9fb1e3 100644
@@ -1752,6 +1752,7 @@ static irqreturn_t snd_cs4281_interrupt(int irq, void *dev_id)
 					chip->spurious_dtc_irq++;
 					continue;
 				}
+				period_elapsed = true;
 			}
 			if (period_elapsed)
 				snd_pcm_period_elapsed(cdma->substream);
Signature · 1 line
2.43.0
Applied
#1 lore raw
Quoted 11 lines · Chandra Mohan Sundar

As part of spin lock code cleanup using guard(), a new variable (period_elapsed) was introduced. However this variable is never set, causing period elapsed notification to be not sent.

Set the value of period_elapsed appropiately.

This issue was reported by static coverity analyzer.

Fixes 7a5127c2c8a5a ("ALSA: cs4281: Use guard() for spin locks")

Thanks, applied now.

Takashi