Skip to contentSkip to conversation

ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR

PATCH In review Chhayly Leang 3 participants 4 messages Jan 26, 2024 – Jan 30, 2024 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR

Adds sound support for ASUS Zenbook UM3402YAR with missing DSD

---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/cs35l41_hda_property.c +2 -0
index 35277ce890a..2af083183d8 100644
@@ -76,6 +76,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
+	{ "10431683", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
 	{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -410,6 +411,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431533", generic_dsd_config },
 	{ "CSC3551", "10431573", generic_dsd_config },
 	{ "CSC3551", "10431663", generic_dsd_config },
+	{ "CSC3551", "10431683", generic_dsd_config },
 	{ "CSC3551", "104316D3", generic_dsd_config },
 	{ "CSC3551", "104316F3", generic_dsd_config },
 	{ "CSC3551", "104317F3", generic_dsd_config },
Signature · 1 line
2.42.0
#1 lore raw
Quoted 4 lines · Chhayly Leang

Adds sound support for ASUS Zenbook UM3402YAR with missing DSD

Yet another missing entry; can Cirrus people review this before I merge?

thanks,

Takashi

Quoted 27 lines
---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/cs35l41_hda_property.c +2 -0
index 35277ce890a..2af083183d8 100644
@@ -76,6 +76,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, -1, 0, 1000, 4500, 24 },
+	{ "10431683", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 0, 0, 0 },
 	{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 0, 0, 0 },
 	{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -410,6 +411,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "10431533", generic_dsd_config },
 	{ "CSC3551", "10431573", generic_dsd_config },
 	{ "CSC3551", "10431663", generic_dsd_config },
+	{ "CSC3551", "10431683", generic_dsd_config },
 	{ "CSC3551", "104316D3", generic_dsd_config },
 	{ "CSC3551", "104316F3", generic_dsd_config },
 	{ "CSC3551", "104317F3", generic_dsd_config },
Signature · 1 line
2.42.0
#2 lore raw

Hi,

Quoted 16 lines

-----Original Message-----
From: Takashi Iwai <[email protected]>
Sent: Tuesday, January 30, 2024 11:06 AM
To: Chhayly Leang <[email protected]>
Cc: Stefan Binding <[email protected]>; Takashi Iwai <[email protected]>; [email protected]; James Schulman <[email protected]>; David Rhodes <[email protected]>; Richard Fitzgerald <[email protected]>; Jaroslav Kysela <[email protected]>; linux- [email protected]; [email protected]
Subject: Re: [PATCH] ALSA: hda: cs35l41: Support ASUS Zenbook UM3402YAR

Quoted 1 line · Chhayly Leang
Quoted 6 lines
Quoted 3 lines

Adds sound support for ASUS Zenbook UM3402YAR with missing DSD

Yet another missing entry; can Cirrus people review this before I merge?

Looks good to me.

Thanks,
Stefan

Quoted 43 lines

thanks,

Takashi

Review

Quoted 5 lines
---
 sound/pci/hda/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
(quoted diff) +0 -0

b/sound/pci/hda/cs35l41_hda_property.c

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config

Quoted 4 lines

index 35277ce890a..2af083183d8 100644

sound/pci/hda/cs35l41_hda_property.c +0 -0
@@ -76,6 +76,7 @@ static const struct cs35l41_config

cs35l41_config_table[] = {

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 76

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "10431533", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0

}, 0, 1, -1, 1000, 4500, 24 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 77

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "10431573", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0

}, 1, 2, 0, 1000, 4500, 24 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 78

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "10431663", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0

}, 1, -1, 0, 1000, 4500, 24 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 79

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +1 -0
+	{ "10431683", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0

}, 0, 1, -1, 0, 0, 0 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 80

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "104316D3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0

}, 1, 2, 0, 0, 0, 0 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 81

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "104316F3", 2, EXTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0

}, 1, 2, 0, 0, 0, 0 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_config · line 82

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
 	{ "104317F3", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0

}, 0, 1, -1, 1000, 4500, 24 },

sound/pci/hda/cs35l41_hda_property.c static const struct cs35l41_prop_model

Quoted 1 line
sound/pci/hda/cs35l41_hda_property.c +0 -0
@@ -410,6 +411,7 @@ static const struct cs35l41_prop_model

cs35l41_prop_model_table[] = {

Quoted 10 lines
sound/pci/hda/cs35l41_hda_property.c +1 -1
 	{ "CSC3551", "10431533", generic_dsd_config },
 	{ "CSC3551", "10431573", generic_dsd_config },
 	{ "CSC3551", "10431663", generic_dsd_config },
+	{ "CSC3551", "10431683", generic_dsd_config },
 	{ "CSC3551", "104316D3", generic_dsd_config },
 	{ "CSC3551", "104316F3", generic_dsd_config },
 	{ "CSC3551", "104317F3", generic_dsd_config },
--

2.42.0