Skip to contentSkip to conversation

ALSA: hda/hdmi: add force-connect quirks

PATCH Applied Kai Vehmanen 2 participants 4 messages Dec 8, 2023 – Dec 10, 2023 Sound

lore
Share & tools
lore
#0 lore raw

cover ALSA: hda/hdmi: add force-connect quirks

This series addresses problems seen on a few older Intel based systems as found by the DRM i915 CI and the inject-audio test.

The patches in series have been separately tested on top of drm-tip at:
https://patchwork.freedesktop.org/series/127515/
https://patchwork.freedesktop.org/series/127305/

Kai Vehmanen (2):
ALSA: hda/hdmi: add force-connect quirk for NUC5CPYB
ALSA: hda/hdmi: add force-connect quirks for ASUSTeK Z170 variants

 sound/pci/hda/patch_hdmi.c | 3 +++
 1 file changed, 3 insertions(+)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/2 ALSA: hda/hdmi: add force-connect quirk for NUC5CPYB

Add one more older NUC model that requires quirk to force all pins to be connected. The display codec pins are not registered properly without the force-connect quirk. The codec will report only one pin as having external connectivity, but i915 finds all three connectors on the system, so the two drivers are not in sync.

Issue found with DRM igt-gpu-tools test kms_hdmi_inject@inject-audio.

---
 sound/pci/hda/patch_hdmi.c | 1 +
 1 file changed, 1 insertion(+)
sound/pci/hda/patch_hdmi.c +1 -0
index dff2d7221982..88d7e037a57c 100644
@@ -1994,6 +1994,7 @@ static const struct snd_pci_quirk force_connect_list[] = {
 	SND_PCI_QUIRK(0x103c, 0x8711, "HP", 1),
 	SND_PCI_QUIRK(0x103c, 0x8715, "HP", 1),
 	SND_PCI_QUIRK(0x1462, 0xec94, "MS-7C94", 1),
+	SND_PCI_QUIRK(0x8086, 0x2060, "Intel NUC5CPYB", 1),
 	SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", 1),
 	{}
 };
Signature · 1 line
2.43.0
#2 lore raw

PATCH 2/2 ALSA: hda/hdmi: add force-connect quirks for ASUSTeK Z170 variants

In reply to Kai Vehmanen

On ASUSTeK Z170M PLUS and Z170 PRO GAMING systems, the display codec pins are not registered properly without the force-connect quirk. The codec will report only one pin as having external connectivity, but i915 finds all three connectors on the system, so the two drivers are not in sync.

Issue found with DRM igt-gpu-tools test kms_hdmi_inject@inject-audio.

---
 sound/pci/hda/patch_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)
sound/pci/hda/patch_hdmi.c +2 -0
index 88d7e037a57c..200779296a1b 100644
@@ -1993,6 +1993,8 @@ static const struct snd_pci_quirk force_connect_list[] = {
 	SND_PCI_QUIRK(0x103c, 0x871a, "HP", 1),
 	SND_PCI_QUIRK(0x103c, 0x8711, "HP", 1),
 	SND_PCI_QUIRK(0x103c, 0x8715, "HP", 1),
+	SND_PCI_QUIRK(0x1043, 0x86ae, "ASUS", 1),  /* Z170 PRO */
+	SND_PCI_QUIRK(0x1043, 0x86c7, "ASUS", 1),  /* Z170M PLUS */
 	SND_PCI_QUIRK(0x1462, 0xec94, "MS-7C94", 1),
 	SND_PCI_QUIRK(0x8086, 0x2060, "Intel NUC5CPYB", 1),
 	SND_PCI_QUIRK(0x8086, 0x2081, "Intel NUC 10", 1),
Signature · 1 line
2.43.0
Applied
#3 lore raw
In reply to Kai Vehmanen
Quoted 4 lines · Kai Vehmanen

This series addresses problems seen on a few older Intel based systems as found by the DRM i915 CI and the inject-audio test.

Quoted 8 lines

The patches in series have been separately tested on top of drm-tip at:
https://patchwork.freedesktop.org/series/127515/
https://patchwork.freedesktop.org/series/127305/

Kai Vehmanen (2):
ALSA: hda/hdmi: add force-connect quirk for NUC5CPYB
ALSA: hda/hdmi: add force-connect quirks for ASUSTeK Z170 variants

Applied both patches now. Thanks.

Takashi