Skip to contentSkip to conversation

package/gcc: restrict hs4x_rel31 to arc gcc fork

PATCH Applied Romain Naour 3 participants 5 messages May 15, 2022 – May 29, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gcc: restrict hs4x_rel31 to arc gcc fork

ARC hs4x_rel31 cpu is not supported by upstream gcc version. Only the generic HS48 processor (BR2_archs4x) is supported by upstream gcc.

Fixes:
http://autobuild.buildroot.net/results/357a74d53af96d4b868a9d5b9f9ce9432e0c53b5
http://autobuild.buildroot.net/results/bcdf160a3d5ffcccd4402f65aca153faca4b32c2

Cc ARC Maintainers <[email protected]>
---
 package/gcc/Config.in.host | 6 ++++++
 1 file changed, 6 insertions(+)
package/gcc/Config.in.host +6 -0
index f6b9b4fa9d..2b12035c4b 100644
@@ -31,6 +31,8 @@ config BR2_GCC_VERSION_9_X
 	# upstream gcc. C-SKY gcc upstream support not tested
 	# with upstream binutils and glibc.
 	depends on !BR2_csky
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_9
 
 config BR2_GCC_VERSION_10_X
@@ -43,6 +45,8 @@ config BR2_GCC_VERSION_10_X
 	# upstream gcc. C-SKY gcc upstream support not tested
 	# with upstream binutils and glibc.
 	depends on !BR2_csky
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_10
 
 config BR2_GCC_VERSION_11_X
@@ -54,6 +58,8 @@ config BR2_GCC_VERSION_11_X
 	# that need to be reverted since gcc 8.4, 9.3 and 10.1.
 	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98784
 	depends on !BR2_sparc
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_11
 
 endchoice
Signature · 6 lines
2.35.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

On 2022-05-15 21:36 +0200, Romain Naour spake thusly:

Quoted 19 lines

ARC hs4x_rel31 cpu is not supported by upstream gcc version. Only the generic HS48 processor (BR2_archs4x) is supported by upstream gcc.

Fixes:
http://autobuild.buildroot.net/results/357a74d53af96d4b868a9d5b9f9ce9432e0c53b5
http://autobuild.buildroot.net/results/bcdf160a3d5ffcccd4402f65aca153faca4b32c2

Cc ARC Maintainers <[email protected]>
---
 package/gcc/Config.in.host | 6 ++++++
 1 file changed, 6 insertions(+)
package/gcc/Config.in.host +0 -0
index f6b9b4fa9d..2b12035c4b 100644

package/gcc/Config.in.host config BR2_GCC_VERSION_9_X · line 35

Quoted 5 lines
package/gcc/Config.in.host +2 -0
@@ -31,6 +31,8 @@ config BR2_GCC_VERSION_9_X
 	# upstream gcc. C-SKY gcc upstream support not tested
 	# with upstream binutils and glibc.
 	depends on !BR2_csky
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31

So, in the commit log, you say that BR2_archs4x is the only variant supported by upstream gcc, yet this change still allows all the hs38 and the 7x0d variants to use the upstream gcc.

Did I misread the commit log, and you really meant:

Of the hs48 series, only the generic HS48 processor (BR2_archs4x) is supported by upstream gcc, while the hs48 rel31 (hs4x_rel31) is not, and is only suppoerted by the ARC fork.

All the other variants, 7x0d and hs38, are all supported in upstream gcc.

Thoughts?

Regards,
Yann E. MORIN.

Quoted 28 lines
package/gcc/Config.in.host +4 -0
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_9
 
 config BR2_GCC_VERSION_10_X
@@ -43,6 +45,8 @@ config BR2_GCC_VERSION_10_X
 	# upstream gcc. C-SKY gcc upstream support not tested
 	# with upstream binutils and glibc.
 	depends on !BR2_csky
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_10
 
 config BR2_GCC_VERSION_11_X
@@ -54,6 +58,8 @@ config BR2_GCC_VERSION_11_X
 	# that need to be reverted since gcc 8.4, 9.3 and 10.1.
 	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98784
 	depends on !BR2_sparc
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_11
 
 endchoice
Signature · 6 lines
2.35.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Hello Yann,

Le 16/05/2022 à 23:44, Yann E. MORIN a écrit :

Quoted 15 lines

On 2022-05-15 21:36 +0200, Romain Naour spake thusly:

Quoted 14 lines

ARC hs4x_rel31 cpu is not supported by upstream gcc version. Only the generic HS48 processor (BR2_archs4x) is supported by upstream gcc.

Fixes:
http://autobuild.buildroot.net/results/357a74d53af96d4b868a9d5b9f9ce9432e0c53b5
http://autobuild.buildroot.net/results/bcdf160a3d5ffcccd4402f65aca153faca4b32c2

Cc ARC Maintainers <[email protected]>
---
 package/gcc/Config.in.host | 6 ++++++
 1 file changed, 6 insertions(+)
Quoted 14 lines

package/gcc/Config.in.host config BR2_GCC_VERSION_9_X · line 35

Quoted 10 lines
package/gcc/Config.in.host +2 -0
index f6b9b4fa9d..2b12035c4b 100644
@@ -31,6 +31,8 @@ config BR2_GCC_VERSION_9_X
 	# upstream gcc. C-SKY gcc upstream support not tested
 	# with upstream binutils and glibc.
 	depends on !BR2_csky
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31

So, in the commit log, you say that BR2_archs4x is the only variant supported by upstream gcc, yet this change still allows all the hs38 and the 7x0d variants to use the upstream gcc.

I'm only speaking about ARC hs48, not other ARC variant.

Quoted 10 lines

Did I misread the commit log, and you really meant:

Of the hs48 series, only the generic HS48 processor (BR2_archs4x) is supported by upstream gcc, while the hs48 rel31 (hs4x_rel31) is not, and is only suppoerted by the ARC fork.

All the other variants, 7x0d and hs38, are all supported in upstream gcc.>
Thoughts?

hs4x_rel31 seems the only one not supported by upstream gcc.

Best regards,
Romain

Quoted 24 lines

Regards,
Yann E. MORIN.

Quoted 20 lines
package/gcc/Config.in.host +4 -0
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_9
 
 config BR2_GCC_VERSION_10_X
@@ -43,6 +45,8 @@ config BR2_GCC_VERSION_10_X
 	# upstream gcc. C-SKY gcc upstream support not tested
 	# with upstream binutils and glibc.
 	depends on !BR2_csky
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_10
 
 config BR2_GCC_VERSION_11_X
@@ -54,6 +58,8 @@ config BR2_GCC_VERSION_11_X
 	# that need to be reverted since gcc 8.4, 9.3 and 10.1.
 	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98784
 	depends on !BR2_sparc
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_11
 
Quoted 9 lines
Quoted 8 lines
package/gcc/Config.in.host +0 -0
 endchoice
Signature · 6 lines
2.35.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
In reply to Romain Naour

Romain, All,

On 2022-05-15 21:36 +0200, Romain Naour spake thusly:

Quoted 10 lines

ARC hs4x_rel31 cpu is not supported by upstream gcc version. Only the generic HS48 processor (BR2_archs4x) is supported by upstream gcc.

Fixes:
http://autobuild.buildroot.net/results/357a74d53af96d4b868a9d5b9f9ce9432e0c53b5
http://autobuild.buildroot.net/results/bcdf160a3d5ffcccd4402f65aca153faca4b32c2

Cc ARC Maintainers <[email protected]>

Applied to master, after rewording the commit log as we discussed on IRC. Thanks!

Regards,
Yann E. MORIN.

Quoted 42 lines
---
 package/gcc/Config.in.host | 6 ++++++
 1 file changed, 6 insertions(+)
package/gcc/Config.in.host +6 -0
index f6b9b4fa9d..2b12035c4b 100644
@@ -31,6 +31,8 @@ config BR2_GCC_VERSION_9_X
 	# upstream gcc. C-SKY gcc upstream support not tested
 	# with upstream binutils and glibc.
 	depends on !BR2_csky
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_9
 
 config BR2_GCC_VERSION_10_X
@@ -43,6 +45,8 @@ config BR2_GCC_VERSION_10_X
 	# upstream gcc. C-SKY gcc upstream support not tested
 	# with upstream binutils and glibc.
 	depends on !BR2_csky
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_10
 
 config BR2_GCC_VERSION_11_X
@@ -54,6 +58,8 @@ config BR2_GCC_VERSION_11_X
 	# that need to be reverted since gcc 8.4, 9.3 and 10.1.
 	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98784
 	depends on !BR2_sparc
+	# ARC HS48 rel 31 only supported by gcc arc fork.
+	depends on !BR2_archs4x_rel31
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_11
 
 endchoice
Signature · 6 lines
2.35.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw
In reply to Romain Naour
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

ARC hs4x_rel31 cpu is not supported by upstream gcc version. Only the generic HS48 processor (BR2_archs4x) is supported by upstream gcc.

Quoted 6 lines

Fixes:
http://autobuild.buildroot.net/results/357a74d53af96d4b868a9d5b9f9ce9432e0c53b5
http://autobuild.buildroot.net/results/bcdf160a3d5ffcccd4402f65aca153faca4b32c2

Cc ARC Maintainers <[email protected]>

Committed to 2022.02.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot