Skip to contentSkip to conversation

ath11k: select QRTR for AHB as well

PATCH In review Robert Marko 2 participants 5 messages Apr 1, 2022 – Apr 4, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: select QRTR for AHB as well

Currently, ath11k only selects QRTR if ath11k PCI is selected, however AHB support requires QRTR, more precisely QRTR_SMD because it is using QMI as well which in turn uses QRTR.

Without QRTR_SMD AHB does not work, so select QRTR in ATH11K and then select QRTR_SMD for ATH11K_AHB and QRTR_MHI for ATH11K_PCI.

Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1

---
 drivers/net/wireless/ath/ath11k/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/Kconfig +2 -1
index ad5cc6cac05b..b45baad184f6 100644
@@ -5,6 +5,7 @@ config ATH11K
 	depends on CRYPTO_MICHAEL_MIC
 	select ATH_COMMON
 	select QCOM_QMI_HELPERS
+	select QRTR
 	help
 	  This module adds support for Qualcomm Technologies 802.11ax family of
 	  chipsets.
@@ -15,6 +16,7 @@ config ATH11K_AHB
 	tristate "Atheros ath11k AHB support"
 	depends on ATH11K
 	depends on REMOTEPROC
+	select QRTR_SMD
 	help
 	  This module adds support for AHB bus
 
@@ -22,7 +24,6 @@ config ATH11K_PCI
 	tristate "Atheros ath11k PCI support"
 	depends on ATH11K && PCI
 	select MHI_BUS
-	select QRTR
 	select QRTR_MHI
 	help
 	  This module adds support for PCIE bus
Signature · 7 lines
2.35.1


-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#1 lore raw
Quoted 35 lines · Robert Marko

Currently, ath11k only selects QRTR if ath11k PCI is selected, however AHB support requires QRTR, more precisely QRTR_SMD because it is using QMI as well which in turn uses QRTR.

Without QRTR_SMD AHB does not work, so select QRTR in ATH11K and then select QRTR_SMD for ATH11K_AHB and QRTR_MHI for ATH11K_PCI.

Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1

---
 drivers/net/wireless/ath/ath11k/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/Kconfig +2 -0
index ad5cc6cac05b..b45baad184f6 100644
@@ -5,6 +5,7 @@ config ATH11K
 	depends on CRYPTO_MICHAEL_MIC
 	select ATH_COMMON
 	select QCOM_QMI_HELPERS
+	select QRTR
 	help
 	  This module adds support for Qualcomm Technologies 802.11ax family of
 	  chipsets.
@@ -15,6 +16,7 @@ config ATH11K_AHB
 	tristate "Atheros ath11k AHB support"
 	depends on ATH11K
 	depends on REMOTEPROC
+	select QRTR_SMD
 	help
 	  This module adds support for AHB bus
 

drivers/net/wireless/ath/ath11k/Kconfig config ATH11K_PCI · line 29

Quoted 7 lines
drivers/net/wireless/ath/ath11k/Kconfig +0 -1
@@ -22,7 +24,6 @@ config ATH11K_PCI
 	tristate "Atheros ath11k PCI support"
 	depends on ATH11K && PCI
 	select MHI_BUS
-	select QRTR
 	select QRTR_MHI
 	help
 	  This module adds support for PCIE bus

I now see a new warning:

WARNING: unmet direct dependencies detected for QRTR_SMD
Depends on [n]: NET [=y] && QRTR [=m] && (RPMSG [=n] || COMPILE_TEST [=n] && RPMSG [=n]=n) Selected by [m]:
- ATH11K_AHB [=m] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && ATH11K [=m] && REMOTEPROC [=y]

Signature · 8 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath11k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath11k
#2 lore raw
Quoted 48 lines · Kalle Valo
Quoted 35 lines · Robert Marko

Currently, ath11k only selects QRTR if ath11k PCI is selected, however AHB support requires QRTR, more precisely QRTR_SMD because it is using QMI as well which in turn uses QRTR.

Without QRTR_SMD AHB does not work, so select QRTR in ATH11K and then select QRTR_SMD for ATH11K_AHB and QRTR_MHI for ATH11K_PCI.

Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1

---
 drivers/net/wireless/ath/ath11k/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/Kconfig +2 -0
index ad5cc6cac05b..b45baad184f6 100644
@@ -5,6 +5,7 @@ config ATH11K
      depends on CRYPTO_MICHAEL_MIC
      select ATH_COMMON
      select QCOM_QMI_HELPERS
+     select QRTR
      help
        This module adds support for Qualcomm Technologies 802.11ax family of
        chipsets.
@@ -15,6 +16,7 @@ config ATH11K_AHB
      tristate "Atheros ath11k AHB support"
      depends on ATH11K
      depends on REMOTEPROC
+     select QRTR_SMD
      help
        This module adds support for AHB bus
 

drivers/net/wireless/ath/ath11k/Kconfig config ATH11K_PCI · line 29

Quoted 7 lines
drivers/net/wireless/ath/ath11k/Kconfig +0 -1
@@ -22,7 +24,6 @@ config ATH11K_PCI
      tristate "Atheros ath11k PCI support"
      depends on ATH11K && PCI
      select MHI_BUS
-     select QRTR
      select QRTR_MHI
      help
        This module adds support for PCIE bus

I now see a new warning:

Quoted 4 lines

WARNING: unmet direct dependencies detected for QRTR_SMD
Depends on [n]: NET [=y] && QRTR [=m] && (RPMSG [=n] || COMPILE_TEST [=n] && RPMSG [=n]=n) Selected by [m]:
- ATH11K_AHB [=m] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && ATH11K [=m] && REMOTEPROC [=y]

Ahh yeah, since it's SMD then it requires RPMGS which in turn requires more stuff.
What do you think about making it depend on QRTR_SMD instead, because without it AHB literally does not work?

Regards,
Robert

Quoted 5 lines

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

#3 lore raw
Quoted 49 lines · Robert Marko
Quoted 48 lines · Kalle Valo
Quoted 35 lines · Robert Marko

Currently, ath11k only selects QRTR if ath11k PCI is selected, however AHB support requires QRTR, more precisely QRTR_SMD because it is using QMI as well which in turn uses QRTR.

Without QRTR_SMD AHB does not work, so select QRTR in ATH11K and then select QRTR_SMD for ATH11K_AHB and QRTR_MHI for ATH11K_PCI.

Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1

---
 drivers/net/wireless/ath/ath11k/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/Kconfig +2 -0
index ad5cc6cac05b..b45baad184f6 100644
@@ -5,6 +5,7 @@ config ATH11K
      depends on CRYPTO_MICHAEL_MIC
      select ATH_COMMON
      select QCOM_QMI_HELPERS
+     select QRTR
      help
        This module adds support for Qualcomm Technologies 802.11ax family of
        chipsets.
@@ -15,6 +16,7 @@ config ATH11K_AHB
      tristate "Atheros ath11k AHB support"
      depends on ATH11K
      depends on REMOTEPROC
+     select QRTR_SMD
      help
        This module adds support for AHB bus
 

drivers/net/wireless/ath/ath11k/Kconfig config ATH11K_PCI · line 29

Quoted 7 lines
drivers/net/wireless/ath/ath11k/Kconfig +0 -1
@@ -22,7 +24,6 @@ config ATH11K_PCI
      tristate "Atheros ath11k PCI support"
      depends on ATH11K && PCI
      select MHI_BUS
-     select QRTR
      select QRTR_MHI
      help
        This module adds support for PCIE bus

I now see a new warning:

Quoted 8 lines
Quoted 4 lines

WARNING: unmet direct dependencies detected for QRTR_SMD
Depends on [n]: NET [=y] && QRTR [=m] && (RPMSG [=n] || COMPILE_TEST [=n] && RPMSG [=n]=n) Selected by [m]:
- ATH11K_AHB [=m] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && ATH11K [=m] && REMOTEPROC [=y]

Ahh yeah, since it's SMD then it requires RPMGS which in turn requires more stuff. What do you think about making it depend on QRTR_SMD instead, because without it AHB literally does not work?

To be honest I don't know qrtr well enough to comment right now :)

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#4 lore raw
Quoted 57 lines · Kalle Valo
Quoted 54 lines · Robert Marko
Quoted 52 lines · Kalle Valo
Quoted 35 lines · Robert Marko

Currently, ath11k only selects QRTR if ath11k PCI is selected, however AHB support requires QRTR, more precisely QRTR_SMD because it is using QMI as well which in turn uses QRTR.

Without QRTR_SMD AHB does not work, so select QRTR in ATH11K and then select QRTR_SMD for ATH11K_AHB and QRTR_MHI for ATH11K_PCI.

Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1

---
 drivers/net/wireless/ath/ath11k/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/Kconfig +2 -0
index ad5cc6cac05b..b45baad184f6 100644
@@ -5,6 +5,7 @@ config ATH11K
      depends on CRYPTO_MICHAEL_MIC
      select ATH_COMMON
      select QCOM_QMI_HELPERS
+     select QRTR
      help
        This module adds support for Qualcomm Technologies 802.11ax family of
        chipsets.
@@ -15,6 +16,7 @@ config ATH11K_AHB
      tristate "Atheros ath11k AHB support"
      depends on ATH11K
      depends on REMOTEPROC
+     select QRTR_SMD
      help
        This module adds support for AHB bus
 

drivers/net/wireless/ath/ath11k/Kconfig config ATH11K_PCI · line 29

Quoted 7 lines
drivers/net/wireless/ath/ath11k/Kconfig +0 -1
@@ -22,7 +24,6 @@ config ATH11K_PCI
      tristate "Atheros ath11k PCI support"
      depends on ATH11K && PCI
      select MHI_BUS
-     select QRTR
      select QRTR_MHI
      help
        This module adds support for PCIE bus

I now see a new warning:

WARNING: unmet direct dependencies detected for QRTR_SMD
Depends on [n]: NET [=y] && QRTR [=m] && (RPMSG [=n] || COMPILE_TEST [=n] && RPMSG [=n]=n) Selected by [m]:
- ATH11K_AHB [=m] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && ATH11K [=m] && REMOTEPROC [=y]

Quoted 5 lines
Quoted 3 lines

Ahh yeah, since it's SMD then it requires RPMGS which in turn requires more stuff. What do you think about making it depend on QRTR_SMD instead, because without it AHB literally does not work?

To be honest I don't know qrtr well enough to comment right now :)

I dont know details about QRTR as well, but I know that its used for both AHB and PCI versions for QMI.
AHB versions use it over SMD and without it, AHB support wont work, it will find the HW model and revision and that's it, only after the QRTR_SMD is inserted you can use QMI to load the caldata etc.

Regards,
Robert

Quoted 5 lines

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches