drm/i915/display: split out some dpt and fb stuff from intel_display.c
Subsystems (3)
cover drm/i915/display: split out some dpt and fb stuff from intel_display.c
Make some forward progress on reducing intel_display.c size.
Jani Nikula (6):
drm/i915/display: split out dpt out of intel_display.c drm/i915: add HAS_ASYNC_FLIPS feature macro drm/i915/fb: move intel_tile_width_bytes() to intel_fb.c drm/i915/fb: move intel_fb_align_height() to intel_fb.c drm/i915/fb: move intel_surf_alignment() to intel_fb.c drm/i915/fb: move user framebuffer stuff to intel_fb.c
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 709 +------------------ drivers/gpu/drm/i915/display/intel_display.h | 6 - drivers/gpu/drm/i915/display/intel_dpt.c | 229 ++++++ drivers/gpu/drm/i915/display/intel_dpt.h | 19 + drivers/gpu/drm/i915/display/intel_fb.c | 481 +++++++++++++ drivers/gpu/drm/i915/display/intel_fb.h | 20 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 2 + 9 files changed, 752 insertions(+), 716 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.c create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.h
Signature · 1 line
2.20.1
PATCH 1/6 drm/i915/display: split out dpt out of intel_display.c
Let's try to reduce the size of intel_display.c, not increase it.
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 220 +----------------- drivers/gpu/drm/i915/display/intel_dpt.c | 229 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dpt.h | 19 ++ 4 files changed, 250 insertions(+), 219 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.c create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -212,6 +212,7 @@ i915-y += \ display/intel_dpio_phy.o \ display/intel_dpll.o \ display/intel_dpll_mgr.o \ + display/intel_dpt.o \ display/intel_dsb.o \ display/intel_fb.o \ display/intel_fbc.o \
drivers/gpu/drm/i915/display/intel_display.c +1 -219
238 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dpt.c new file +229 -0
229 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dpt.h new file +19 -0
@@ -0,0 +1,19 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2021 Intel Corporation +*/ + +#ifndef __INTEL_DPT_H__ +#define __INTEL_DPT_H__ + +struct i915_address_space ; +struct i915_vma ; +struct intel_framebuffer ; + +void intel_dpt_destroy (struct i915_address_space *vm); +struct i915_vma *intel_dpt_pin (struct i915_address_space *vm); +void intel_dpt_unpin (struct i915_address_space *vm); +struct i915_address_space * +intel_dpt_create (struct intel_framebuffer *fb); + +#endif /* __INTEL_DPT_H__ */
Signature · 1 line
2.20.1
PATCH 2/6 drm/i915: add HAS_ASYNC_FLIPS feature macro
In reply to Jani NikulaThis will be needed in multiple places soon.
--- drivers/gpu/drm/i915/display/intel_display.c | 9 ++------- drivers/gpu/drm/i915/i915_drv.h | 2 ++ 2 files changed, 4 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +2 -7
@@ -977,11 +977,6 @@ static unsigned int intel_linear_alignment(const struct drm_i915_private *dev_prreturn 0 ; } -static bool has_async_flips (struct drm_i915_private *i915) -{ -return DISPLAY_VER (i915) >=5 ; -} -unsigned int intel_surf_alignment (const struct drm_framebuffer *fb,int color_plane) {
@@ -1015,7 +1010,7 @@ unsigned int intel_surf_alignment(const struct drm_framebuffer *fb,case DRM_FORMAT_MOD_LINEAR :return intel_linear_alignment (dev_priv);case I915_FORMAT_MOD_X_TILED : -if (has_async_flips (dev_priv)) +if (HAS_ASYNC_FLIPS (dev_priv))return 256 *1024 ;return 0 ;case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS :
@@ -12161,7 +12156,7 @@ static void intel_mode_config_init(struct drm_i915_private *i915) mode_config->funcs = &intel_mode_funcs; - mode_config->async_page_flip =has_async_flips (i915); + mode_config->async_page_flip =HAS_ASYNC_FLIPS (i915);/* * Maximum framebuffer dimensions, chosen to match
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -1721,6 +1721,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define HAS_VRR (i915) (GRAPHICS_VER(i915) >= 12) +#define HAS_ASYNC_FLIPS (i915) (DISPLAY_VER(i915) >= 5) +/* Only valid when HAS_DISPLAY() is true */ #define INTEL_DISPLAY_ENABLED (dev_priv) \ (drm_WARN_ON(&(dev_priv)->drm, !HAS_DISPLAY(dev_priv)), !(dev_priv)->params.disable_display)
Signature · 1 line
2.20.1
PATCH 3/6 drm/i915/fb: move intel_tile_width_bytes() to intel_fb.c
In reply to Jani NikulaSplit out fb related stuff from intel_display.c to intel_fb.c.
--- drivers/gpu/drm/i915/display/intel_display.c | 54 -------------------- drivers/gpu/drm/i915/display/intel_display.h | 1 - drivers/gpu/drm/i915/display/intel_fb.c | 54 ++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_fb.h | 1 + 4 files changed, 55 insertions(+), 55 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +0 -54
@@ -879,60 +879,6 @@ intel_format_info_is_yuv_semiplanar(const struct drm_format_info *info, info->num_planes == (is_ccs_modifier (modifier) ?4 :2 ); } -unsigned int -intel_tile_width_bytes (const struct drm_framebuffer *fb,int color_plane) -{ -struct drm_i915_private *dev_priv =to_i915 (fb->dev); -unsigned int cpp = fb->format->cpp[color_plane]; - -switch (fb->modifier) { -case DRM_FORMAT_MOD_LINEAR : -return intel_tile_size (dev_priv); -case I915_FORMAT_MOD_X_TILED : -if (DISPLAY_VER (dev_priv) ==2 ) -return 128 ; -else -return 512 ; -case I915_FORMAT_MOD_Y_TILED_CCS : -if (is_ccs_plane (fb, color_plane)) -return 128 ; - fallthrough; -case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : -case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : -case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : -if (is_ccs_plane (fb, color_plane)) -return 64 ; - fallthrough; -case I915_FORMAT_MOD_Y_TILED : -if (DISPLAY_VER (dev_priv) ==2 ||HAS_128_BYTE_Y_TILING (dev_priv)) -return 128 ; -else -return 512 ; -case I915_FORMAT_MOD_Yf_TILED_CCS: -if (is_ccs_plane (fb, color_plane)) -return 128 ; - fallthrough; -case I915_FORMAT_MOD_Yf_TILED: -switch (cpp) { -case 1 : -return 64 ; -case 2 : -case 4 : -return 128 ; -case 8 : -case 16 : -return 256 ; -default : -MISSING_CASE (cpp); -return cpp; - } -break ; -default : -MISSING_CASE (fb->modifier); -return cpp; - } -} -unsigned int intel_fb_align_height (const struct drm_framebuffer *fb,int color_plane,unsigned int height)
drivers/gpu/drm/i915/display/intel_display.h +0 -1
@@ -632,7 +632,6 @@ intel_get_crtc_new_encoder(const struct intel_atomic_state *state,unsigned int intel_surf_alignment (const struct drm_framebuffer *fb,int color_plane); -unsigned int intel_tile_width_bytes (const struct drm_framebuffer *fb,int color_plane);void intel_display_driver_register (struct drm_i915_private *i915);void intel_display_driver_unregister (struct drm_i915_private *i915);
drivers/gpu/drm/i915/display/intel_fb.c +54 -0
60 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_fb.h +1 -0
@@ -28,6 +28,7 @@ int skl_ccs_to_main_plane(const struct drm_framebuffer *fb, int ccs_plane);int skl_main_to_aux_plane (const struct drm_framebuffer *fb,int main_plane);unsigned int intel_tile_size (const struct drm_i915_private *i915); +unsigned int intel_tile_width_bytes (const struct drm_framebuffer *fb,int color_plane);unsigned int intel_tile_height (const struct drm_framebuffer *fb,int color_plane);unsigned int intel_tile_row_size (const struct drm_framebuffer *fb,int color_plane);
Signature · 1 line
2.20.1
PATCH 4/6 drm/i915/fb: move intel_fb_align_height() to intel_fb.c
In reply to Jani NikulaSplit out fb related stuff from intel_display.c to intel_fb.c.
--- drivers/gpu/drm/i915/display/intel_display.c | 9 --------- drivers/gpu/drm/i915/display/intel_display.h | 2 -- drivers/gpu/drm/i915/display/intel_fb.c | 9 +++++++++ drivers/gpu/drm/i915/display/intel_fb.h | 3 ++- drivers/gpu/drm/i915/display/intel_fbdev.c | 1 + 5 files changed, 12 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +0 -9
@@ -879,15 +879,6 @@ intel_format_info_is_yuv_semiplanar(const struct drm_format_info *info, info->num_planes == (is_ccs_modifier (modifier) ?4 :2 ); } -unsigned int -intel_fb_align_height (const struct drm_framebuffer *fb, -int color_plane,unsigned int height) -{ -unsigned int tile_height =intel_tile_height (fb, color_plane); - -return ALIGN (height, tile_height); -} -unsigned int intel_rotation_info_size (const struct intel_rotation_info *rot_info) {unsigned int size =0 ;
drivers/gpu/drm/i915/display/intel_display.h +0 -2
@@ -548,8 +548,6 @@ void intel_init_display_hooks(struct drm_i915_private *dev_priv);unsigned int intel_fb_xy_to_linear (int x,int y,const struct intel_plane_state *state,int plane); -unsigned int intel_fb_align_height (const struct drm_framebuffer *fb, -int color_plane,unsigned int height);void intel_add_fb_offsets (int *x,int *y,const struct intel_plane_state *state,int plane);unsigned int intel_rotation_info_size (const struct intel_rotation_info *rot_info);
drivers/gpu/drm/i915/display/intel_fb.c +9 -0
@@ -163,6 +163,15 @@ unsigned int intel_tile_row_size(const struct drm_framebuffer *fb, int color_plareturn fb->pitches[color_plane] * tile_height; } +unsigned int +intel_fb_align_height (const struct drm_framebuffer *fb, +int color_plane,unsigned int height) +{ +unsigned int tile_height =intel_tile_height (fb, color_plane); + +return ALIGN (height, tile_height); +} +unsigned int intel_cursor_alignment (const struct drm_i915_private *i915) {if (IS_I830 (i915))
drivers/gpu/drm/i915/display/intel_fb.h +2 -1
@@ -31,7 +31,8 @@ unsigned int intel_tile_size(const struct drm_i915_private *i915);unsigned int intel_tile_width_bytes (const struct drm_framebuffer *fb,int color_plane);unsigned int intel_tile_height (const struct drm_framebuffer *fb,int color_plane);unsigned int intel_tile_row_size (const struct drm_framebuffer *fb,int color_plane); - +unsigned int intel_fb_align_height (const struct drm_framebuffer *fb, +int color_plane,unsigned int height);unsigned int intel_cursor_alignment (const struct drm_i915_private *i915); void intel_fb_plane_get_subsampling(int *hsub, int *vsub,
drivers/gpu/drm/i915/display/intel_fbdev.c +1 -0
@@ -45,6 +45,7 @@#include "i915_drv.h" #include "intel_display_types.h" +#include "intel_fb.h" #include "intel_fbdev.h" #include "intel_frontbuffer.h"
Signature · 1 line
2.20.1
PATCH 5/6 drm/i915/fb: move intel_surf_alignment() to intel_fb.c
In reply to Jani NikulaSplit out fb related stuff from intel_display.c to intel_fb.c.
--- drivers/gpu/drm/i915/display/intel_display.c | 64 -------------------- drivers/gpu/drm/i915/display/intel_display.h | 3 - drivers/gpu/drm/i915/display/intel_fb.c | 64 ++++++++++++++++++++ drivers/gpu/drm/i915/display/intel_fb.h | 2 + 4 files changed, 66 insertions(+), 67 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +0 -64
@@ -901,70 +901,6 @@ unsigned int intel_remapped_info_size(const struct intel_remapped_info *rem_inforeturn size; } -static unsigned int intel_linear_alignment (const struct drm_i915_private *dev_priv) -{ -if (DISPLAY_VER (dev_priv) >=9 ) -return 256 *1024 ; -else if (IS_I965G (dev_priv) ||IS_I965GM (dev_priv) || -IS_VALLEYVIEW (dev_priv) ||IS_CHERRYVIEW (dev_priv)) -return 128 *1024 ; -else if (DISPLAY_VER (dev_priv) >=4 ) -return 4 *1024 ; -else -return 0 ; -} - -unsigned int intel_surf_alignment (const struct drm_framebuffer *fb, -int color_plane) -{ -struct drm_i915_private *dev_priv =to_i915 (fb->dev); - -if (intel_fb_uses_dpt (fb)) -return 512 *4096 ; - -/* AUX_DIST needs only 4K alignment */ -if (is_ccs_plane (fb, color_plane)) -return 4096 ; - -if (is_semiplanar_uv_plane (fb, color_plane)) { -/* -* TODO: cross-check wrt. the bspec stride in bytes * 64 bytes -* alignment for linear UV planes on all platforms. -*/ -if (DISPLAY_VER (dev_priv) >=12 ) { -if (fb->modifier ==DRM_FORMAT_MOD_LINEAR ) -return intel_linear_alignment (dev_priv); - -return intel_tile_row_size (fb, color_plane); - } - -return 4096 ; - } - -drm_WARN_ON (&dev_priv->drm, color_plane !=0 ); - -switch (fb->modifier) { -case DRM_FORMAT_MOD_LINEAR : -return intel_linear_alignment (dev_priv); -case I915_FORMAT_MOD_X_TILED : -if (HAS_ASYNC_FLIPS (dev_priv)) -return 256 *1024 ; -return 0 ; -case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : -case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : -case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : -return 16 *1024 ; -case I915_FORMAT_MOD_Y_TILED_CCS : -case I915_FORMAT_MOD_Yf_TILED_CCS: -case I915_FORMAT_MOD_Y_TILED : -case I915_FORMAT_MOD_Yf_TILED: -return 1 *1024 *1024 ; -default : -MISSING_CASE (fb->modifier); -return 0 ; - } -} -static bool intel_plane_uses_fence (const struct intel_plane_state *plane_state) {struct intel_plane *plane =to_intel_plane (plane_state->uapi.plane);
drivers/gpu/drm/i915/display/intel_display.h +0 -3
@@ -628,9 +628,6 @@ struct intel_encoder * intel_get_crtc_new_encoder(const struct intel_atomic_state *state, const struct intel_crtc_state *crtc_state); -unsigned int intel_surf_alignment (const struct drm_framebuffer *fb, -int color_plane); -void intel_display_driver_register (struct drm_i915_private *i915);void intel_display_driver_unregister (struct drm_i915_private *i915);
drivers/gpu/drm/i915/display/intel_fb.c +64 -0
70 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_fb.h +2 -0
@@ -34,6 +34,8 @@ unsigned int intel_tile_row_size(const struct drm_framebuffer *fb, int color_plaunsigned int intel_fb_align_height (const struct drm_framebuffer *fb,int color_plane,unsigned int height);unsigned int intel_cursor_alignment (const struct drm_i915_private *i915); +unsigned int intel_surf_alignment (const struct drm_framebuffer *fb, +int color_plane); void intel_fb_plane_get_subsampling(int *hsub, int *vsub, const struct drm_framebuffer *fb,
Signature · 1 line
2.20.1
PATCH 6/6 drm/i915/fb: move user framebuffer stuff to intel_fb.c
In reply to Jani NikulaSplit out fb related stuff from intel_display.c to intel_fb.c.
--- drivers/gpu/drm/i915/display/intel_display.c | 355 ------------------- drivers/gpu/drm/i915/display/intel_fb.c | 354 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_fb.h | 14 +- 3 files changed, 366 insertions(+), 357 deletions(-)
drivers/gpu/drm/i915/display/intel_display.c +0 -355
@@ -112,9 +112,6 @@ static void i9xx_crtc_clock_get(struct intel_crtc *crtc,static void ilk_pch_clock_get (struct intel_crtc *crtc,struct intel_crtc_state *pipe_config); -static int intel_framebuffer_init (struct intel_framebuffer *ifb, -struct drm_i915_gem_object *obj, -struct drm_mode_fb_cmd2 *mode_cmd);static void intel_set_transcoder_timings (const struct intel_crtc_state *crtc_state);static void intel_set_pipe_src_size (const struct intel_crtc_state *crtc_state); static void intel_cpu_transcoder_set_m_n(const struct intel_crtc_state *crtc_state,
@@ -1134,22 +1131,6 @@ void intel_add_fb_offsets(int *x, int *y, *y += state->view.color_plane[color_plane].y; } -static unsigned int intel_fb_modifier_to_tiling (u64 fb_modifier) -{ -switch (fb_modifier) { -case I915_FORMAT_MOD_X_TILED : -return I915_TILING_X ; -case I915_FORMAT_MOD_Y_TILED : -case I915_FORMAT_MOD_Y_TILED_CCS : -case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS : -case I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC : -case I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS : -return I915_TILING_Y ; -default : -return I915_TILING_NONE ; - } -} -/* * From the Sky Lake PRM: * "The Color Control Surface (CCS) contains the compression status of
@@ -1280,12 +1261,6 @@ intel_get_format_info(const struct drm_mode_fb_cmd2 *cmd) } } -static int gen12_ccs_aux_stride (struct drm_framebuffer *fb,int ccs_plane) -{ -return DIV_ROUND_UP (fb->pitches[skl_ccs_to_main_plane (fb, ccs_plane)], -512 ) *64 ; -} -u32 intel_plane_fb_max_stride (struct drm_i915_private *dev_priv,u32 pixel_format,u64 modifier) {
@@ -1310,71 +1285,6 @@ u32 intel_plane_fb_max_stride(struct drm_i915_private *dev_priv, DRM_MODE_ROTATE_0); } -static -u32 intel_fb_max_stride (struct drm_i915_private *dev_priv, -u32 pixel_format,u64 modifier) -{ -/* -* Arbitrary limit for gen4+ chosen to match the -* render engine max stride. -* -* The new CCS hash mode makes remapping impossible -*/ -if (DISPLAY_VER (dev_priv) <4 ||is_ccs_modifier (modifier) || -intel_modifier_uses_dpt (dev_priv, modifier)) -return intel_plane_fb_max_stride (dev_priv, pixel_format, modifier); -else if (DISPLAY_VER (dev_priv) >=7 ) -return 256 *1024 ; -else -return 128 *1024 ; -} - -static u32 -intel_fb_stride_alignment (const struct drm_framebuffer *fb,int color_plane) -{ -struct drm_i915_private *dev_priv =to_i915 (fb->dev); -u32 tile_width; - -if (is_surface_linear (fb, color_plane)) { -u32 max_stride =intel_plane_fb_max_stride (dev_priv, - fb->format->format, - fb->modifier); - -/* -* To make remapping with linear generally feasible -* we need the stride to be page aligned. -*/ -if (fb->pitches[color_plane] > max_stride && - !is_ccs_modifier (fb->modifier)) -return intel_tile_size (dev_priv); -else -return 64 ; - } - - tile_width =intel_tile_width_bytes (fb, color_plane); -if (is_ccs_modifier (fb->modifier)) { -/* -* Display WA #0531: skl,bxt,kbl,glk -* -* Render decompression and plane width > 3840 -* combined with horizontal panning requires the -* plane stride to be a multiple of 4. We'll just -* require the entire fb to accommodate that to avoid -* potential runtime errors at plane configuration time. -*/ -if ((DISPLAY_VER (dev_priv) ==9 ||IS_GEMINILAKE (dev_priv)) && - color_plane ==0 && fb->width >3840 ) - tile_width *=4 ; -/* -* The main surface pitch must be padded to a multiple of four -* tile widths. -*/ -else if (DISPLAY_VER (dev_priv) >=12 ) - tile_width *=4 ; - } -return tile_width; -} -static struct i915_vma *initial_plane_vma (struct drm_i915_private *i915,struct intel_initial_plane_config *plane_config)
@@ -6182,28 +6092,6 @@ static const struct drm_display_mode load_detect_mode = { 704, 832, 0, 480, 489, 491, 520, 0, DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC), }; -struct drm_framebuffer * -intel_framebuffer_create (struct drm_i915_gem_object *obj, -struct drm_mode_fb_cmd2 *mode_cmd) -{ -struct intel_framebuffer *intel_fb; -int ret; - - intel_fb =kzalloc (sizeof (*intel_fb),GFP_KERNEL ); -if (!intel_fb) -return ERR_PTR (-ENOMEM ); - - ret =intel_framebuffer_init (intel_fb, obj, mode_cmd); -if (ret) - goto err; - -return &intel_fb->base; - -err: -kfree (intel_fb); -return ERR_PTR (ret); -} -static int intel_modeset_disable_planes (struct drm_atomic_state *state,struct drm_crtc *crtc) {
@@ -11356,249 +11244,6 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)drm_helper_move_panel_connectors_to_head (&dev_priv->drm); } -static void intel_user_framebuffer_destroy (struct drm_framebuffer *fb) -{ -struct intel_framebuffer *intel_fb =to_intel_framebuffer (fb); - -drm_framebuffer_cleanup (fb); - -if (intel_fb_uses_dpt (fb)) -intel_dpt_destroy (intel_fb->dpt_vm); - -intel_frontbuffer_put (intel_fb->frontbuffer); - -kfree (intel_fb); -} - -static int intel_user_framebuffer_create_handle (struct drm_framebuffer *fb, -struct drm_file *file, -unsigned int *handle) -{ -struct drm_i915_gem_object *obj =intel_fb_obj (fb); -struct drm_i915_private *i915 =to_i915 (obj->base.dev); - -if (i915_gem_object_is_userptr (obj)) { -drm_dbg (&i915->drm, -"attempting to use a userptr for a framebuffer, denied\n" ); -return -EINVAL ; - } - -return drm_gem_handle_create (file, &obj->base, handle); -} - -static int intel_user_framebuffer_dirty (struct drm_framebuffer *fb, -struct drm_file *file, -unsigned flags,unsigned color, -struct drm_clip_rect *clips, -unsigned num_clips) -{ -struct drm_i915_gem_object *obj =intel_fb_obj (fb); - -i915_gem_object_flush_if_display (obj); -intel_frontbuffer_flush (to_intel_frontbuffer (fb),ORIGIN_DIRTYFB ); - -return 0 ; -} - -static const struct drm_framebuffer_funcs intel_fb_funcs = { - .destroy = intel_user_framebuffer_destroy, - .create_handle = intel_user_framebuffer_create_handle, - .dirty = intel_user_framebuffer_dirty, -}; - -static int intel_framebuffer_init (struct intel_framebuffer *intel_fb, -struct drm_i915_gem_object *obj, -struct drm_mode_fb_cmd2 *mode_cmd) -{ -struct drm_i915_private *dev_priv =to_i915 (obj->base.dev); -struct drm_framebuffer *fb = &intel_fb->base; -u32 max_stride; -unsigned int tiling, stride; -int ret = -EINVAL ; -int i; - - intel_fb->frontbuffer =intel_frontbuffer_get (obj); -if (!intel_fb->frontbuffer) -return -ENOMEM ; - -i915_gem_object_lock (obj,NULL ); - tiling =i915_gem_object_get_tiling (obj); - stride =i915_gem_object_get_stride (obj); -i915_gem_object_unlock (obj); - -if (mode_cmd->flags &DRM_MODE_FB_MODIFIERS ) { -/* -* If there's a fence, enforce that -* the fb modifier and tiling mode match. -*/ -if (tiling !=I915_TILING_NONE && - tiling !=intel_fb_modifier_to_tiling (mode_cmd->modifier[0 ])) { -drm_dbg_kms (&dev_priv->drm, -"tiling_mode doesn't match fb modifier\n" ); - goto err; - } - }else { -if (tiling ==I915_TILING_X ) { - mode_cmd->modifier[0 ] =I915_FORMAT_MOD_X_TILED ; - }else if (tiling ==I915_TILING_Y ) { -drm_dbg_kms (&dev_priv->drm, -"No Y tiling for legacy addfb\n" ); - goto err; - } - } - -if (!drm_any_plane_has_format (&dev_priv->drm, - mode_cmd->pixel_format, - mode_cmd->modifier[0 ])) { -drm_dbg_kms (&dev_priv->drm, -"unsupported pixel format %p4cc / modifier 0x%llx\n" , - &mode_cmd->pixel_format, mode_cmd->modifier[0 ]); - goto err; - } - -/* -* gen2/3 display engine uses the fence if present, -* so the tiling mode must match the fb modifier exactly. -*/ -if (DISPLAY_VER (dev_priv) <4 && - tiling !=intel_fb_modifier_to_tiling (mode_cmd->modifier[0 ])) { -drm_dbg_kms (&dev_priv->drm, -"tiling_mode must match fb modifier exactly on gen2/3\n" ); - goto err; - } - - max_stride =intel_fb_max_stride (dev_priv, mode_cmd->pixel_format, - mode_cmd->modifier[0 ]); -if (mode_cmd->pitches[0 ] > max_stride) { -drm_dbg_kms (&dev_priv->drm, -"%s pitch (%u) must be at most %d\n" , - mode_cmd->modifier[0 ] !=DRM_FORMAT_MOD_LINEAR ? -"tiled" :"linear" , - mode_cmd->pitches[0 ], max_stride); - goto err; - } - -/* -* If there's a fence, enforce that -* the fb pitch and fence stride match. -*/ -if (tiling !=I915_TILING_NONE && mode_cmd->pitches[0 ] != stride) { -drm_dbg_kms (&dev_priv->drm, -"pitch (%d) must match tiling stride (%d)\n" , - mode_cmd->pitches[0 ], stride); - goto err; - } - -/* FIXME need to adjust LINOFF/TILEOFF accordingly. */ -if (mode_cmd->offsets[0 ] !=0 ) { -drm_dbg_kms (&dev_priv->drm, -"plane 0 offset (0x%08x) must be 0\n" , - mode_cmd->offsets[0 ]); - goto err; - } - -drm_helper_mode_fill_fb_struct (&dev_priv->drm, fb, mode_cmd); - -for (i =0 ; i < fb->format->num_planes; i++) { -u32 stride_alignment; - -if (mode_cmd->handles[i] != mode_cmd->handles[0 ]) { -drm_dbg_kms (&dev_priv->drm,"bad plane %d handle\n" , - i); - goto err; - } - - stride_alignment =intel_fb_stride_alignment (fb, i); -if (fb->pitches[i] & (stride_alignment -1 )) { -drm_dbg_kms (&dev_priv->drm, -"plane %d pitch (%d) must be at least %u byte aligned\n" , - i, fb->pitches[i], stride_alignment); - goto err; - } - -if (is_gen12_ccs_plane (fb, i) && !is_gen12_ccs_cc_plane (fb, i)) { -int ccs_aux_stride =gen12_ccs_aux_stride (fb, i); - -if (fb->pitches[i] != ccs_aux_stride) { -drm_dbg_kms (&dev_priv->drm, -"ccs aux plane %d pitch (%d) must be %d\n" , - i, - fb->pitches[i], ccs_aux_stride); - goto err; - } - } - -/* TODO: Add POT stride remapping support for CCS formats as well. */ -if (IS_ALDERLAKE_P (dev_priv) && - mode_cmd->modifier[i] !=DRM_FORMAT_MOD_LINEAR && - !intel_fb_needs_pot_stride_remap (intel_fb) && - !is_power_of_2 (mode_cmd->pitches[i])) { -drm_dbg_kms (&dev_priv->drm, -"plane %d pitch (%d) must be power of two for tiled buffers\n" , - i, mode_cmd->pitches[i]); - goto err; - } - - fb->obj[i] = &obj->base; - } - - ret =intel_fill_fb_info (dev_priv, intel_fb); -if (ret) - goto err; - -if (intel_fb_uses_dpt (fb)) { -struct i915_address_space *vm; - - vm =intel_dpt_create (intel_fb); -if (IS_ERR (vm)) { - ret =PTR_ERR (vm); - goto err; - } - - intel_fb->dpt_vm = vm; - } - - ret =drm_framebuffer_init (&dev_priv->drm, fb, &intel_fb_funcs); -if (ret) { -drm_err (&dev_priv->drm,"framebuffer init failed %d\n" , ret); - goto err; - } - -return 0 ; - -err: -intel_frontbuffer_put (intel_fb->frontbuffer); -return ret; -} - -static struct drm_framebuffer * -intel_user_framebuffer_create (struct drm_device *dev, -struct drm_file *filp, -const struct drm_mode_fb_cmd2 *user_mode_cmd) -{ -struct drm_framebuffer *fb; -struct drm_i915_gem_object *obj; -struct drm_mode_fb_cmd2 mode_cmd = *user_mode_cmd; -struct drm_i915_private *i915; - - obj =i915_gem_object_lookup (filp, mode_cmd.handles[0 ]); -if (!obj) -return ERR_PTR (-ENOENT ); - -/* object is backed with LMEM for discrete */ - i915 =to_i915 (obj->base.dev); -if (HAS_LMEM (i915) && !i915_gem_object_can_migrate (obj,INTEL_REGION_LMEM )) { -/* object is "remote", not in local memory */ -i915_gem_object_put (obj); -return ERR_PTR (-EREMOTE ); - } - - fb =intel_framebuffer_create (obj, &mode_cmd); -i915_gem_object_put (obj); - -return fb; -} -static enum drm_mode_status intel_mode_valid (struct drm_device *dev,const struct drm_display_mode *mode)
drivers/gpu/drm/i915/display/intel_fb.c +354 -0
384 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_fb.h +12 -2
@@ -8,10 +8,12 @@#include <linux/types.h> +struct drm_device ; +struct drm_file ;struct drm_framebuffer ; - +struct drm_i915_gem_object ;struct drm_i915_private ; - +struct drm_mode_fb_cmd2 ;struct intel_fb_view ;struct intel_framebuffer ;struct intel_plane_state ;
@@ -57,4 +59,12 @@ void intel_fb_fill_view(const struct intel_framebuffer *fb, unsigned int rotatio struct intel_fb_view *view);int intel_plane_compute_gtt (struct intel_plane_state *plane_state); +int intel_framebuffer_init (struct intel_framebuffer *ifb, +struct drm_i915_gem_object *obj, +struct drm_mode_fb_cmd2 *mode_cmd); +struct drm_framebuffer * +intel_user_framebuffer_create (struct drm_device *dev, +struct drm_file *filp, +const struct drm_mode_fb_cmd2 *user_mode_cmd); +#endif /* __INTEL_FB_H__ */
Signature · 1 line
2.20.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: split out some dpt and fb stuff from intel_display.c
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/display: split out some dpt and fb stuff from intel_display.c
URL : https://patchwork.freedesktop.org/series/93930/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip dcf25e16d7d4 drm/i915/display: split out dpt out of intel_display.c -:268: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #268: new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 493 lines checked 8cc6afec23c5 drm/i915: add HAS_ASYNC_FLIPS feature macro df9a6d5c1283 drm/i915/fb: move intel_tile_width_bytes() to intel_fb.c 31a81aa5ad38 drm/i915/fb: move intel_fb_align_height() to intel_fb.c f864be12d43c drm/i915/fb: move intel_surf_alignment() to intel_fb.c 2bc9c4d4dbd7 drm/i915/fb: move user framebuffer stuff to intel_fb.c
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: split out some dpt and fb stuff from intel_display.c
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/display: split out some dpt and fb stuff from intel_display.c
URL : https://patchwork.freedesktop.org/series/93930/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. -O:drivers/gpu/drm/i915/display/intel_display.c:1902:21: expected struct i915_vma *[assigned] vma -O:drivers/gpu/drm/i915/display/intel_display.c:1902:21: got void [noderef] __iomem *[assigned] iomem -O:drivers/gpu/drm/i915/display/intel_display.c:1902:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/display/intel_dpt.c:136:21: expected struct i915_vma *[assigned] vma +drivers/gpu/drm/i915/display/intel_dpt.c:136:21: got void [noderef] __iomem *[assigned] iomem +drivers/gpu/drm/i915/display/intel_dpt.c:136:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/i915_gem_context.c:1374:34: expected struct i915_address_space *vm +drivers/gpu/drm/i915/gem/i915_gem_context.c:1374:34: got struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/i915_gem_context.c:1374:34: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: expected struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: got struct i915_address_space * +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: expected struct i915_address_space *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: got struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1392:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1268:24: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/i915_perf.c:1442:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1496:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +./include/linux/stddef.h:17:9: this was the original definition +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined +/usr/lib/gcc/x86_64-linux-gnu/8/include/stddef.h:417:9: warning: preprocessor token offsetof redefined
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: split out some dpt and fb stuff from intel_display.c
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/display: split out some dpt and fb stuff from intel_display.c
URL : https://patchwork.freedesktop.org/series/93930/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10506 -> Patchwork_20874
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/index.html
Known issues
------------
Here are the changes found in Patchwork_20874 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +16 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-kbl-soraka/igt@gem_exec_fence@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-kbl-soraka/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886] / [i915#2291])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@late_gt_pm:
- fi-bsw-n3050: [PASS][4] -> [DMESG-FAIL][5] ([i915#2927])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-bsw-n3050/igt@i915_selftest@live@late_gt_pm.html
* igt@kms_busy@basic@modeset:
- fi-tgl-1115g4: [PASS][6] -> [DMESG-WARN][7] ([i915#4002])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-tgl-1115g4/igt@kms_busy@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-tgl-1115g4/igt@kms_busy@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-kbl-soraka/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#533])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-kbl-soraka/igt@[email protected]
* igt@runner@aborted:
- fi-bsw-n3050: NOTRUN -> [FAIL][10] ([fdo#109271] / [i915#1436])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-bsw-n3050/igt@[email protected]
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-tgl-1115g4: [DMESG-WARN][11] ([i915#4002]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-tgl-1115g4/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-tgl-1115g4/igt@[email protected]
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [DMESG-WARN][13] ([i915#3958]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-1115g4: [FAIL][15] ([i915#1888]) -> [DMESG-WARN][16] ([i915#4002])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-tgl-1115g4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-tgl-1115g4/igt@[email protected]
* igt@kms_chamelium@dp-hpd-fast:
- fi-tgl-1115g4: [SKIP][17] ([fdo#111827] / [i915#1385]) -> [SKIP][18] ([fdo#111827])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/fi-tgl-1115g4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/fi-tgl-1115g4/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1385]: https://gitlab.freedesktop.org/drm/intel/issues/1385
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3958]: https://gitlab.freedesktop.org/drm/intel/issues/3958
[i915#4002]: https://gitlab.freedesktop.org/drm/intel/issues/4002
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Participating hosts (38 -> 34)
------------------------------
Additional (1): fi-kbl-soraka
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-jsl-1 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10506 -> Patchwork_20874
CI-20190529: 20190529
CI_DRM_10506: d6681095a2aa987fa64c6d0ed991674745589c06 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6181: e7a9ab2f21a67b1ab3f4093ec0bd775647308ba6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20874: 2bc9c4d4dbd7690fe57e60098b63f4f8131fe898 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2bc9c4d4dbd7 drm/i915/fb: move user framebuffer stuff to intel_fb.c f864be12d43c drm/i915/fb: move intel_surf_alignment() to intel_fb.c 31a81aa5ad38 drm/i915/fb: move intel_fb_align_height() to intel_fb.c df9a6d5c1283 drm/i915/fb: move intel_tile_width_bytes() to intel_fb.c 8cc6afec23c5 drm/i915: add HAS_ASYNC_FLIPS feature macro dcf25e16d7d4 drm/i915/display: split out dpt out of intel_display.c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: split out some dpt and fb stuff from intel_display.c
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/display: split out some dpt and fb stuff from intel_display.c
URL : https://patchwork.freedesktop.org/series/93930/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10506_full -> Patchwork_20874_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_20874_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-snb2/igt@[email protected]
* igt@gem_eio@in-flight-1us:
- shard-skl: [PASS][2] -> [TIMEOUT][3] ([i915#3063])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl9/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk9/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-glk4/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][6] ([i915#2846])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl8/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-kbl: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl2/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl4/igt@gem_exec_fair@[email protected]
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-tglb3/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-tglb1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk7/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-glk6/igt@gem_exec_fair@[email protected]
- shard-kbl: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl1/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][15] ([i915#2842]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-iclb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_whisper@basic-contexts:
- shard-glk: [PASS][16] -> [DMESG-WARN][17] ([i915#118] / [i915#95])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk6/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-glk3/igt@[email protected]
* igt@gem_media_vme:
- shard-skl: NOTRUN -> [SKIP][18] ([fdo#109271]) +57 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl1/igt@gem_media_vme.html
* igt@gem_mmap_gtt@cpuset-big-copy-odd:
- shard-iclb: [PASS][19] -> [FAIL][20] ([i915#307])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-iclb6/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][21] ([i915#2658])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl6/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][22] ([i915#2658])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl7/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][23] ([i915#1886] / [i915#2291])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl7/igt@i915_selftest@live@gt_pm.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][24] ([i915#3722])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl7/igt@[email protected]
* igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3886]) +4 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl1/igt@kms_ccs@pipe-b-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886]) +5 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl1/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][27] ([fdo#109271]) +288 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-snb2/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html
* igt@kms_chamelium@hdmi-hpd-fast:
- shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +15 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-snb2/igt@[email protected]
* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +15 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl6/igt@[email protected]
* igt@kms_color@pipe-c-ctm-blue-to-red:
- shard-skl: [PASS][30] -> [DMESG-WARN][31] ([i915#1982])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl5/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl2/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-degamma:
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +5 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl1/igt@[email protected]
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][33] ([i915#1319]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl1/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][34] ([i915#2105])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [PASS][35] -> [INCOMPLETE][36] ([i915#300])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl4/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: NOTRUN -> [FAIL][37] ([i915#2346])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][38] -> [DMESG-WARN][39] ([i915#180]) +7 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl2/igt@kms_flip@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [PASS][40] -> [DMESG-WARN][41] ([i915#180])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl2/igt@kms_flip@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][42] ([i915#180])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl8/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271]) +136 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][44] -> [FAIL][45] ([i915#1188])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl5/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl7/igt@[email protected]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#533])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][47] ([fdo#108145] / [i915#265]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][48] ([i915#265])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl1/igt@[email protected]
- shard-skl: NOTRUN -> [FAIL][49] ([i915#265])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][50] ([fdo#108145] / [i915#265])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl7/igt@[email protected]
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#2733])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl1/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#658]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl1/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-skl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#658]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl1/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][54] -> [SKIP][55] ([fdo#109441]) +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-iclb3/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#2437])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl1/igt@[email protected]
* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#2994])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl7/igt@[email protected]
* igt@sysfs_clients@pidname:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2994]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl1/igt@[email protected]
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][59] ([i915#658]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb8/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-iclb2/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][61] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-tglb5/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-tglb5/igt@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][63] ([i915#2842]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl4/igt@gem_exec_fair@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][65] ([i915#2842]) -> [PASS][66] +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk8/igt@gem_exec_fair@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-glk1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-tglb: [FAIL][67] ([i915#2842]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-tglb6/igt@gem_exec_fair@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-wc-read:
- shard-apl: [DMESG-WARN][69] ([i915#165]) -> [PASS][70] +12 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl8/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][71] ([i915#3921]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-snb5/igt@i915_selftest@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-snb2/igt@i915_selftest@[email protected]
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][73] ([i915#118] / [i915#95]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-glk4/igt@[email protected]
* igt@kms_color@pipe-c-ctm-0-75:
- shard-skl: [DMESG-WARN][75] ([i915#1982]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl8/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl3/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-apl: [DMESG-WARN][77] ([i915#203]) -> [PASS][78] +8 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl8/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [FAIL][79] ([i915#2346]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl8/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl2/igt@[email protected]
* igt@kms_flip@flip-vs-absolute-wf_vblank@b-edp1:
- shard-skl: [FAIL][81] ([i915#2122]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl4/igt@kms_flip@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [FAIL][83] ([i915#79]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk4/igt@kms_flip@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-glk5/igt@kms_flip@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid:
- shard-apl: [DMESG-WARN][85] ([i915#165] / [i915#180] / [i915#62]) -> [PASS][86] +23 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl8/igt@[email protected]
* igt@kms_plane_cursor@pipe-a-overlay-size-64:
- shard-apl: [DMESG-WARN][87] ([i915#180] / [i915#203] / [i915#62]) -> [PASS][88] +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl1/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl8/igt@[email protected]
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][89] ([fdo#109441]) -> [PASS][90] +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [INCOMPLETE][91] ([i915#198] / [i915#2828]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl3/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl7/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-glk: [FAIL][93] ([i915#1542]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-glk8/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-glk1/igt@[email protected]
* igt@perf@polling-small-buf:
- shard-skl: [FAIL][95] ([i915#1722]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl7/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl4/igt@[email protected]
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][97] ([i915#1804] / [i915#2684]) -> [WARN][98] ([i915#2684])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb4/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-iclb8/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: [FAIL][99] ([i915#3743]) -> [FAIL][100] ([i915#3722])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-skl2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-skl8/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][101] ([i915#658]) -> [SKIP][102] ([i915#2920]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-iclb8/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: [FAIL][103] ([i915#3002] / [i915#3363]) -> ([FAIL][104], [FAIL][105], [FAIL][106], [FAIL][107], [FAIL][108], [FAIL][109], [FAIL][110]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-kbl7/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl2/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl4/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl4/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl4/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl4/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl6/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-kbl6/igt@[email protected]
- shard-apl: ([FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][115], [FAIL][116], [FAIL][117]) ([i915#180] / [i915#3002] / [i915#3363])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl2/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl3/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl3/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10506/shard-apl8/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl8/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl3/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/shard-apl6/igt@[email protected]
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#2105]: https://gitlab.freedesktop.org/drm/intel/issues/2105
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2733]: https://gitlab.freedesktop.org/drm/intel/issues/2733
[i915#2828]: https://gitlab.freedesktop.org/drm/intel/issues/2828
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3648]: https://gitlab.freedesktop.org/drm/intel/issues/3648
[i915#3722]: https://gitlab.freedesktop.org/drm/intel/issues/3722
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 10)
------------------------------
Missing (1): shard-rkl
Build changes
-------------
* Linux: CI_DRM_10506 -> Patchwork_20874
CI-20190529: 20190529
CI_DRM_10506: d6681095a2aa987fa64c6d0ed991674745589c06 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6181: e7a9ab2f21a67b1ab3f4093ec0bd775647308ba6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20874: 2bc9c4d4dbd7690fe57e60098b63f4f8131fe898 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20874/index.html
Quoted 10 lines · Jani Nikula
Make some forward progress on reducing
intel_display.csize.Jani Nikula (6):
drm/i915/display: split out dpt out ofintel_display.cdrm/i915: addHAS_ASYNC_FLIPSfeature macro drm/i915/fb: moveintel_tile_width_bytes()tointel_fb.cdrm/i915/fb: moveintel_fb_align_height()tointel_fb.cdrm/i915/fb: moveintel_surf_alignment()tointel_fb.cdrm/i915/fb: move user framebuffer stuff tointel_fb.c
Quoted 12 lines
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 709 +------------------ drivers/gpu/drm/i915/display/intel_display.h | 6 - drivers/gpu/drm/i915/display/intel_dpt.c | 229 ++++++ drivers/gpu/drm/i915/display/intel_dpt.h | 19 + drivers/gpu/drm/i915/display/intel_fb.c | 481 +++++++++++++ drivers/gpu/drm/i915/display/intel_fb.h | 20 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 2 + 9 files changed, 752 insertions(+), 716 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.c create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.h
I believe it would be good to add a /** DOC: */ or at least a simple comment block explaining a bit what DPT is.
But other than that the series looks good, so, up to you:
(for the series)
Quoted 4 lines
Signature · 2 lines
-- 2.20.1
Quoted 24 lines · Rodrigo Vivi
Quoted 10 lines · Jani Nikula
Make some forward progress on reducing
intel_display.csize.Jani Nikula (6):
drm/i915/display: split out dpt out ofintel_display.cdrm/i915: addHAS_ASYNC_FLIPSfeature macro drm/i915/fb: moveintel_tile_width_bytes()tointel_fb.cdrm/i915/fb: moveintel_fb_align_height()tointel_fb.cdrm/i915/fb: moveintel_surf_alignment()tointel_fb.cdrm/i915/fb: move user framebuffer stuff tointel_fb.cQuoted 12 lines
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 709 +------------------ drivers/gpu/drm/i915/display/intel_display.h | 6 - drivers/gpu/drm/i915/display/intel_dpt.c | 229 ++++++ drivers/gpu/drm/i915/display/intel_dpt.h | 19 + drivers/gpu/drm/i915/display/intel_fb.c | 481 +++++++++++++ drivers/gpu/drm/i915/display/intel_fb.h | 20 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 2 + 9 files changed, 752 insertions(+), 716 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.c create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.h
Quoted 2 lines
I believe it would be good to add a /** DOC: */ or at least a simple comment block explaining a bit what DPT is.
I agree, but I'm not signing up for that!
Quoted 4 lines
But other than that the series looks good, so, up to you:
Reviewed-by Rodrigo Vivi <[email protected]>(for the series)
Thanks,
Jani
Quoted 5 lines
Quoted 5 lines
Signature · 2 lines
-- 2.20.1
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Quoted 30 lines · Jani Nikula
Quoted 24 lines · Rodrigo Vivi
Quoted 10 lines · Jani Nikula
Make some forward progress on reducing
intel_display.csize.Jani Nikula (6):
drm/i915/display: split out dpt out ofintel_display.cdrm/i915: addHAS_ASYNC_FLIPSfeature macro drm/i915/fb: moveintel_tile_width_bytes()tointel_fb.cdrm/i915/fb: moveintel_fb_align_height()tointel_fb.cdrm/i915/fb: moveintel_surf_alignment()tointel_fb.cdrm/i915/fb: move user framebuffer stuff tointel_fb.cQuoted 12 lines
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_display.c | 709 +------------------ drivers/gpu/drm/i915/display/intel_display.h | 6 - drivers/gpu/drm/i915/display/intel_dpt.c | 229 ++++++ drivers/gpu/drm/i915/display/intel_dpt.h | 19 + drivers/gpu/drm/i915/display/intel_fb.c | 481 +++++++++++++ drivers/gpu/drm/i915/display/intel_fb.h | 20 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 2 + 9 files changed, 752 insertions(+), 716 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.c create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.hQuoted 2 lines
I believe it would be good to add a /** DOC: */ or at least a simple comment block explaining a bit what DPT is.
I agree, but I'm not signing up for that!
Quoted 7 lines
Quoted 4 lines
But other than that the series looks good, so, up to you:
Reviewed-by Rodrigo Vivi <[email protected]>(for the series)
Thanks,
Jani
And pushed.
BR,
Jani.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Signature · 2 lines
-- 2.20.1
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center