powerpc/pseries/dlpar: handle ibm, configure-connector delay status
PATCH 1/1 powerpc/pseries/dlpar: handle ibm, configure-connector delay status
dlpar_configure_connector() has two problems in its handling of ibm,configure-connector's return status:
1. When the status is -2 (busy, call again), we call ibm,configure-connector again immediately without checking whether to schedule, which can result in monopolizing the CPU.
2. Extended delay status (9900..9905) goes completely unhandled, causing the configuration to unnecessarily terminate.
Fix both of these issues by using rtas_busy_delay().
--- arch/powerpc/platforms/pseries/dlpar.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
arch/powerpc/platforms/pseries/dlpar.c +3 -4
@@ -127,7 +127,6 @@ void dlpar_free_cc_nodes(struct device_node *dn)#define NEXT_PROPERTY 3#define PREV_PARENT 4#define MORE_MEMORY 5 -#define CALL_AGAIN -2#define ERR_CFG_USE -9003 struct device_node *dlpar_configure_connector(__be32 drc_index,
@@ -168,6 +167,9 @@ struct device_node *dlpar_configure_connector(__be32 drc_index,spin_unlock (&rtas_data_buf_lock); +if (rtas_busy_delay (rc)) +continue ; +switch (rc) {case COMPLETE :break ;
@@ -216,9 +218,6 @@ struct device_node *dlpar_configure_connector(__be32 drc_index, last_dn = last_dn->parent;break ; -case CALL_AGAIN : -break ; -case MORE_MEMORY :case ERR_CFG_USE :default :
Signature · 1 line
2.29.2
Quoted 9 lines · Nathan Lynch
dlpar_configure_connector()has two problems in its handling of ibm,configure-connector's return status:1. When the status is -2 (busy, call again), we call ibm,configure-connector again immediately without checking whether to schedule, which can result in monopolizing the CPU.
2. Extended delay status (9900..9905) goes completely unhandled, causing the configuration to unnecessarily terminate.
Quoted 4 lines
Fix both of these issues by using
rtas_busy_delay().Fixes ab519a011caa ("powerpc/pseries: Kernel DLPAR Infrastructure")Signed-off-by Nathan Lynch <[email protected]>
Just following up and adding some people to cc in hopes of getting some review for this.
Quoted 38 lines
--- arch/powerpc/platforms/pseries/dlpar.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)arch/powerpc/platforms/pseries/dlpar.c +3
-4@@ -127,7 +127,6 @@ void dlpar_free_cc_nodes(struct device_node *dn)#define NEXT_PROPERTY 3#define PREV_PARENT 4#define MORE_MEMORY 5 -#define CALL_AGAIN -2#define ERR_CFG_USE -9003 struct device_node *dlpar_configure_connector(__be32 drc_index,@@ -168,6 +167,9 @@ struct device_node *dlpar_configure_connector(__be32 drc_index,spin_unlock (&rtas_data_buf_lock); +if (rtas_busy_delay (rc)) +continue ; +switch (rc) {case COMPLETE :break ;@@ -216,9 +218,6 @@ struct device_node *dlpar_configure_connector(__be32 drc_index, last_dn = last_dn->parent;break ; -case CALL_AGAIN : -break ; -case MORE_MEMORY :case ERR_CFG_USE :default :Signature · 1 line
2.29.2
Re: [PATCH] powerpc/pseries/dlpar: handle ibm,configure-connector delay status
In reply to Nathan LynchQuoted 9 lines · Nathan Lynch
dlpar_configure_connector()has two problems in its handling of ibm,configure-connector's return status:1. When the status is -2 (busy, call again), we call ibm,configure-connector again immediately without checking whether to schedule, which can result in monopolizing the CPU.
2. Extended delay status (9900..9905) goes completely unhandled, causing the configuration to unnecessarily terminate.
Quoted 4 lines
Fix both of these issues by using
rtas_busy_delay().Fixes ab519a011caa ("powerpc/pseries: Kernel DLPAR Infrastructure")Signed-off-by Nathan Lynch <[email protected]>
Michael Ellerman
AppliedQuoted 10 lines · Nathan Lynch
dlpar_configure_connector()has two problems in its handling of ibm,configure-connector's return status:1. When the status is -2 (busy, call again), we call ibm,configure-connector again immediately without checking whether to schedule, which can result in monopolizing the CPU.
2. Extended delay status (9900..9905) goes completely unhandled, causing the configuration to unnecessarily terminate.[...]
Applied to powerpc/next.
[1/1] powerpc/pseries/dlpar: handle ibm, configure-connector delay status
https://git.kernel.org/powerpc/c/768d70e19ba525debd571b36e6d0ab19956c63d7
cheers