Skip to contentSkip to conversation

package/gstreamer1/gst1-plugins-bad: dvbsubenc needs gcc 4.9

PATCH New Fabrice Fontaine 2 participants 2 messages Nov 9, 2020 – Nov 10, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-bad: dvbsubenc needs gcc 4.9

dvbsubenc fails to build with gcc 4.8 due to restrict keyword and for loop declarations:

../gst/dvbsubenc/libimagequant/blur.c:10:46: error: expected ';', ',' or ')' before 'src'
transposing_1d_blur (unsigned char *restrict src, unsigned char *restrict dst,

                                              ^
../gst/dvbsubenc/libimagequant/blur.c: In function 'liq_min3':
../gst/dvbsubenc/libimagequant/blur.c:101:5: error: 'for' loop initial declarations are only allowed in C99 mode
     for (unsigned int i = 0; i < width - 1; i++) {
     ^

Fixes:
- http://autobuild.buildroot.org/results/183e876d63340b5c204f47a4653cbfebb0523277

---
 package/gstreamer1/gst1-plugins-bad/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/gstreamer1/gst1-plugins-bad/Config.in +4 -0
index 191820df1d..87a047b779 100644
@@ -89,9 +89,13 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DEBUGUTILS
 
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DVBSUBENC
 	bool "dvbsubenc"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 	help
 	  DVB subpicture encoding support
 
+comment "dvbsubenc plugin needs a toolchain w/ gcc >= 4.9"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_DVBSUBOVERLAY
 	bool "dvbsuboverlay"
 	help
Signature · 1 line
2.28.0
#1 lore raw

PATCH 1/1 package/gstreamer1/gst1-plugins-bad: dvbsubenc needs gcc 4.9

Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

dvbsubenc fails to build with gcc 4.8 due to restrict keyword and for loop declarations:

Quoted 7 lines

../gst/dvbsubenc/libimagequant/blur.c:10:46: error: expected ';', ',' or ')' before 'src'
transposing_1d_blur (unsigned char *restrict src, unsigned char *restrict dst,

                                              ^
../gst/dvbsubenc/libimagequant/blur.c: In function 'liq_min3':
../gst/dvbsubenc/libimagequant/blur.c:101:5: error: 'for' loop initial declarations are only allowed in C99 mode
     for (unsigned int i = 0; i < width - 1; i++) {
     ^

I have instead pushed a commit to pass -std=c99 in CFLAGS. The festival plugin also had issues with this toolchain because of the old glibc version, so I pushed another commit to fix that as well.

Signature · 1 line
Bye, Peter Korsgaard