Skip to contentSkip to conversation

package/python-gobject: depend on python2

PATCH Superseded aduskett at gmail.com 3 participants 4 messages Dec 1, 2019 – Dec 6, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/python-gobject: depend on python2

From: Adam Duskett <[email protected]>

Version 2.86.6 of python-gobject is quite old and no longer works with Python versions > 3.7. When importing a user will recieve the following error:

Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.8/site-packages/gobject/__init__.py", line 26, in <module>
File "/usr/lib/python3.8/site-packages/glib/__init__.py", line 22, in <module>
SystemError: initialization of _glib raised unreported exception

Because new versions of python-gobject require gobject-introspection, which is not currently available in Buildroot, add a dependency on python2 to prevent users from receiving the above error.

---
 package/python-gobject/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/python-gobject/Config.in +1 -0
index 475ff25185..fa801cd411 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_PYTHON_GOBJECT
 	depends on BR2_USE_WCHAR # libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_USE_MMU # libglib2
+	depends on BR2_PACKAGE_PYTHON # Broken with python 3.8
 	select BR2_PACKAGE_LIBGLIB2
 	help
 	  Python bindings for the GLib/GObject library
Signature · 1 line
2.23.0
#1 lore raw

PATCH 2/2 support/testing: add python-gobject test

From: Adam Duskett <[email protected]>

Add a simple test case that imports the module.

---
 DEVELOPERS                                            |  1 +
 .../testing/tests/package/sample_python_gobject.py    |  1 +
 support/testing/tests/package/test_python_gobject.py  | 11 +++++++++++
 3 files changed, 13 insertions(+)
 create mode 100644 support/testing/tests/package/sample_python_gobject.py
 create mode 100644 support/testing/tests/package/test_python_gobject.py
DEVELOPERS +1 -0
index 16e8510b0a..90aa50d789 100644
@@ -75,6 +75,7 @@ F:	package/setools/
 F:	package/sngrep/
 F:	package/spidermonkey/
 F:	package/systemd/
+F:	support/testing/tests/package/test_python_gobject.py
 
 N:	Adam Heinrich <[email protected]>
 F:	package/jack1/
support/testing/tests/package/sample_python_gobject.py new file +1 -0
new file mode 100644
index 0000000000..84ebee7362
@@ -0,0 +1 @@
+import gobject  # noqa
support/testing/tests/package/test_python_gobject.py new file +11 -0
new file mode 100644
index 0000000000..0a59447adb
@@ -0,0 +1,11 @@
+from tests.package.test_python import TestPythonPackageBase
+
+
+class TestPythonPy2Gobject(TestPythonPackageBase):
+    __test__ = True
+    config = TestPythonPackageBase.config + \
+        """
+        BR2_PACKAGE_PYTHON=y
+        BR2_PACKAGE_PYTHON_GOBJECT=y
+        """
+    sample_scripts = ["tests/package/sample_python_gobject.py"]
Signature · 1 line
2.23.0
#2 lore raw

PATCH 1/2 package/python-gobject: depend on python2

In reply to aduskett at gmail.com
Quoted 12 lines · On Sat, 30 Nov 2019 19:06:55 -0800 aduskett at gmail.com wrote:

From: Adam Duskett <[email protected]>

Version 2.86.6 of python-gobject is quite old and no longer works with Python versions > 3.7. When importing a user will recieve the following error:

Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.8/site-packages/gobject/__init__.py", line 26, in <module>
File "/usr/lib/python3.8/site-packages/glib/__init__.py", line 22, in <module>
SystemError: initialization of _glib raised unreported exception

Quoted 5 lines

Because new versions of python-gobject require gobject-introspection, which is not currently available in Buildroot, add a dependency on python2 to prevent users from receiving the above error.

This commit "fixes" bug https://bugs.busybox.net/show_bug.cgi?id=12286

package/python-gobject/Config.in config BR2_PACKAGE_PYTHON_GOBJECT · line 6

Quoted 9 lines
package/python-gobject/Config.in +1 -0
index 475ff25185..fa801cd411 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_PYTHON_GOBJECT
 	depends on BR2_USE_WCHAR # libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_USE_MMU # libglib2
+	depends on BR2_PACKAGE_PYTHON # Broken with python 3.8

You forgot to update the Config.in comment regarding this new dependency. I don't know if we need to show a comment about this being not available with Python 3.x, but at least the existing comment about threads/wchar dependency should only be shown if BR2_PACKAGE_PYTHON=y.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/2 package/python-gobject: depend on python2

In reply to aduskett at gmail.com
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"aduskett" == aduskett <[email protected]> writes:

From: Adam Duskett <[email protected]>
Version 2.86.6 of python-gobject is quite old and no longer works with Python versions > 3.7. When importing a user will recieve the following error:

Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.8/site-packages/gobject/__init__.py", line 26, in <module>
File "/usr/lib/python3.8/site-packages/glib/__init__.py", line 22, in <module>
SystemError: initialization of _glib raised unreported exception

Quoted 5 lines

Because new versions of python-gobject require gobject-introspection, which is not currently available in Buildroot, add a dependency on python2 to prevent users from receiving the above error.

Committed to 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard