Skip to contentSkip to conversation

fs/tar: explicitly set extended header values to ensure binary reproducibility

PATCH New Atharva Lele 2 participants 3 messages Jul 6, 2019 – Jul 31, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 fs/tar: explicitly set extended header values to ensure binary reproducibility

Since we use --xattrs-include='*' to include all extended attributes, tar creates a PAX formatted archive. The archive metadata captures atime and ctime of files. To fix this, GNU recommends that we pass this added argument to tar to create binary reproducible packages. Setting of mtime is handled in fs/common.mk using touch on all files.

Diffoscope output pre-change: https://gitlab.com/snippets/1871111
Diffoscope output after change is blank i.e. binary reproducibile rootfs is created.

GNU Recommendation: https://www.gnu.org/software/tar/manual/tar.html#SEC147

---
Changes v2 -> v2:
- Add comment (suggested by Peter)
- Does not depend on BR2_REPRODUCIBLE since we don't need atime/ctime anyway
Changes v1 -> v2:
- Added comment about mtime handling

---
 fs/tar/tar.mk | 3 +++
 1 file changed, 3 insertions(+)
fs/tar/tar.mk +3 -0
index 4c6327ace8..393d01bfe8 100644
@@ -8,6 +8,9 @@ TAR_OPTS := $(call qstrip,$(BR2_TARGET_ROOTFS_TAR_OPTIONS))
 
 ROOTFS_TAR_DEPENDENCIES = $(BR2_TAR_HOST_DEPENDENCY)
 
+# do not store atime/ctime in PaxHeaders to ensure reproducbility
+TAR_OPTS += --pax-option=exthdr.name=%d/PaxHeaders/%f,atime:=0,ctime:=0
+
 define ROOTFS_TAR_CMD
 	(cd $(TARGET_DIR); find -print0 | LC_ALL=C sort -z | \
 		tar $(TAR_OPTS) -cf $@ --null --xattrs-include='*' --no-recursion -T - --numeric-owner)
Signature · 1 line
2.22.0
#1 lore raw

PATCH v3 1/1 fs/tar: explicitly set extended header values to ensure binary reproducibility

Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Atharva" == Atharva Lele <[email protected]> writes:

Since we use --xattrs-include='*' to include all extended attributes, tar creates a PAX formatted archive. The archive metadata captures atime and ctime of files. To fix this, GNU recommends that we pass this added argument to tar to create binary reproducible packages. Setting of mtime is handled in fs/common.mk using touch on all files.

Diffoscope output pre-change: https://gitlab.com/snippets/1871111
Diffoscope output after change is blank i.e. binary reproducibile rootfs is created.

Quoted 8 lines

GNU Recommendation: https://www.gnu.org/software/tar/manual/tar.html#SEC147

---
Changes v2 -> v2:
- Add comment (suggested by Peter)
- Does not depend on BR2_REPRODUCIBLE since we don't need atime/ctime anyway

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v3 1/1 fs/tar: explicitly set extended header values to ensure binary reproducibility

In reply to Atharva Lele
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Atharva" == Atharva Lele <[email protected]> writes:

Since we use --xattrs-include='*' to include all extended attributes, tar creates a PAX formatted archive. The archive metadata captures atime and ctime of files. To fix this, GNU recommends that we pass this added argument to tar to create binary reproducible packages. Setting of mtime is handled in fs/common.mk using touch on all files.

Quoted 8 lines

Diffoscope output pre-change: https://gitlab.com/snippets/1871111
Diffoscope output after change is blank i.e. binary reproducibile rootfs is created.

GNU Recommendation: https://www.gnu.org/software/tar/manual/tar.html#SEC147

Committed to 2019.02.x and 2019.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard