Skip to contentSkip to conversation

package/rpm: fix build with NLS

PATCH New Fabrice Fontaine 2 participants 3 messages May 12, 2019 – May 26, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/rpm: fix build with NLS

Add TARGET_NLS_LIBS to LIBS to definitely fix linking with lintl instead of calling autoreconf

Fixes:
- http://autobuild.buildroot.org/results/a1446b419f5f59f65fe80849182e38457de203b5

---
 package/rpm/rpm.mk | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
package/rpm/rpm.mk +2 -3
index 6d1068194a..bcdc8c5fee 100644
@@ -20,8 +20,6 @@ RPM_DEPENDENCIES = \
 	$(TARGET_NLS_DEPENDENCIES)
 RPM_LICENSE = GPL-2.0 or LGPL-2.0 (library only)
 RPM_LICENSE_FILES = COPYING
-# Needed to fix an issue with -lintl linking
-RPM_AUTORECONF = YES
 
 RPM_CONF_OPTS = \
 	--disable-python \
@@ -95,6 +93,7 @@ endif
 # ac_cv_prog_cc_c99: RPM uses non-standard GCC extensions (ex. `asm`).
 RPM_CONF_ENV = \
 	ac_cv_prog_cc_c99='-std=gnu99' \
-	CFLAGS="$(TARGET_CFLAGS) $(RPM_CFLAGS)"
+	CFLAGS="$(TARGET_CFLAGS) $(RPM_CFLAGS)" \
+	LIBS=$(TARGET_NLS_LIBS)
 
 $(eval $(autotools-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/rpm: fix build with NLS

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Add TARGET_NLS_LIBS to LIBS to definitely fix linking with lintl instead of calling autoreconf

Fixes:
- http://autobuild.buildroot.org/results/a1446b419f5f59f65fe80849182e38457de203b5

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/rpm: fix build with NLS

In reply to Fabrice Fontaine
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Add TARGET_NLS_LIBS to LIBS to definitely fix linking with lintl instead of calling autoreconf

Fixes:
- http://autobuild.buildroot.org/results/a1446b419f5f59f65fe80849182e38457de203b5

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard